Received-SPF: pass (google.com: domain of linux-kernel+bounces-119485-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 17:40:28 +0100
From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: clock: qcom: add SA8540P gpucc
Message-ID: <ZgL6fE8bFx7H41kr@hovoldconsulting.com>
References: <20240326140108.21307-1-johan+linaro@kernel.org>
 <20240326140108.21307-2-johan+linaro@kernel.org>
 <a6fbbfd3-516b-4269-b4b2-611979b62fd7@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a6fbbfd3-516b-4269-b4b2-611979b62fd7@kernel.org>

On Tue, Mar 26, 2024 at 04:59:43PM +0100, Krzysztof Kozlowski wrote:
> On 26/03/2024 15:01, Johan Hovold wrote:
> > The SA8540P platform is closely related to SC8280XP but differs in that
> > it uses an external supply for the GX power domain.
> > 
> > Add a new compatible string for the SA8540P GPU clock controller so that
> > the OS can determine which resources to look for.
> > 
> > Fixes: e60b95d2b687 ("dt-bindings: clock: qcom: Allow VDD_GFX supply to GX")
> 
> I don't get why adding new device support is a fix. Commit msg did not
> help me to understand it.

Yeah, perhaps I could have expanded on the problem a bit more here.

Hopefully it's clear if you look at the cover letter, but the commit
referred to above should have added a new compatible for SA8540P which
uses the new supply so that the OS can determine when it should try to
look it up and when it is required.

The Fixes tag can also be dropped, I admit this is not clear-cut.

> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/clock/qcom,gpucc.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> > index f57aceddac6b..5b385e4976b6 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> > @@ -28,6 +28,7 @@ properties:
> >    compatible:
> >      enum:
> >        - qcom,sdm845-gpucc
> > +      - qcom,sa8540p-gpucc
> 
> This looks fine and pretty trivial, but I really do not understand why
> skipping our list for automated testing.
> 
> <standard letter>
..
> </standard letter>

Spare me the rant. This was obviously a mistake from reusing and
manually amending a git-send-email command from shell history and
failing to notice that this series also should have been CCed the
devicetree list.

Johan