Received-SPF: pass (google.com: domain of linux-kernel+bounces-119574-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7d3a83b5-6dc7-40d2-8a2e-bd5157a3f8ea@acm.org>
Date: Tue, 26 Mar 2024 10:20:13 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions
Content-Language: en-US
To: Avri Altman <avri.altman@wdc.com>,
 "James E . J . Bottomley" <jejb@linux.ibm.com>,
 "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bean Huo <beanhuo@micron.com>, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240326083253.1303-1-avri.altman@wdc.com>
 <20240326083253.1303-2-avri.altman@wdc.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240326083253.1303-2-avri.altman@wdc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/26/24 01:32, Avri Altman wrote:
> @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
>   
>   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
>   {
> -	/* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> -	if (hba->ufs_version <= ufshci_version(1, 1))
> -		return UFS_UNIPRO_VER_1_41;
> -	else
>   		return UFS_UNIPRO_VER_1_6;
>   }

Please fix the indentation of the only remaining return statement in
this function.

> @@ -5565,15 +5524,13 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
>   		ufshcd_release_scsi_cmd(hba, lrbp);
>   		/* Do not touch lrbp after scsi done */
>   		scsi_done(cmd);
> -	} else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||
> -		   lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> -		if (hba->dev_cmd.complete) {
> -			if (cqe) {
> -				ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> -				lrbp->utr_descriptor_ptr->header.ocs = ocs;
> -			}
> -			complete(hba->dev_cmd.complete);
> +	} else {
> +		WARN_ON(!hba->dev_cmd.complete);
> +		if (cqe) {
> +			ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> +			lrbp->utr_descriptor_ptr->header.ocs = ocs;
>   		}
> +		complete(hba->dev_cmd.complete);
>   	}
>   }

The above is a functional change that has not been mentioned in the
patch description. Please undo the functional change or explain in the
patch description why this is considered correct.

Thanks,

Bart.