Received-SPF: pass (google.com: domain of linux-kernel+bounces-119630-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 18:49:03 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave@sr71.net>, Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH 1/1] headers/deps: x86/fpu: Make task_struct::thread
 constant size
Message-ID: <20240326174903.GA4539@redhat.com>
References: <20240320131908.2708438-1-mingo@kernel.org>
 <20240320131908.2708438-2-mingo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240320131908.2708438-2-mingo@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)

On 03/20, Ingo Molnar wrote:
>
> --- a/arch/x86/kernel/fpu/init.c
> +++ b/arch/x86/kernel/fpu/init.c
> @@ -38,7 +38,7 @@ static void fpu__init_cpu_generic(void)
>  	/* Flush out any pending x87 state: */
>  #ifdef CONFIG_MATH_EMULATION
>  	if (!boot_cpu_has(X86_FEATURE_FPU))
> -		fpstate_init_soft(&current->thread.fpu.fpstate->regs.soft);
> +		fpstate_init_soft(current->thread.fpu->fpstate->regs.soft);
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Typo? it should be

	&current->thread.fpu->fpstate->regs.soft

> +static struct fpu x86_init_fpu __read_mostly;
> +
>  static void __init fpu__init_system_early_generic(void)
>  {
> +	{
> +		int this_cpu = smp_processor_id();
> +
> +		fpstate_reset(&x86_init_fpu);
> +		current->thread.fpu = &x86_init_fpu;
> +		per_cpu(fpu_fpregs_owner_ctx, this_cpu) = &x86_init_fpu;
> +		x86_init_fpu.last_cpu = this_cpu;
> +	}

Can't x86_init_fpu be declared inside the block above?

>  void __init fpu__init_system(void)
>  {
> -	fpstate_reset(&current->thread.fpu);
>  	fpu__init_system_early_generic();
> +	fpstate_reset(current->thread.fpu);

It seems that fpstate_reset(current->thread.fpu) is not needed after the
change in fpu__init_system_early_generic() above.

Oleg.