Received-SPF: pass (google.com: domain of linux-kernel+bounces-119626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 10:49:53 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, <peterz@infradead.org>,
	<torvalds@linux-foundation.org>
CC: Bjorn Helgaas <bhelgaas@google.com>, Ira Weiny <ira.weiny@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, Ilpo =?iso-8859-1?Q?J=E4rvinen?=
	<ilpo.jarvinen@linux.intel.com>, Lukas Wunner <lukas@wunner.de>, "Jonathan
 Corbet" <corbet@lwn.net>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] cleanup: Add usage and style documentation
Message-ID: <66030ac1e78fd_4a98a29415@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <171097196970.1011049.9726486429680041876.stgit@dwillia2-xfh.jf.intel.com>
 <171140738438.1574931.15717256954707430472.stgit@dwillia2-xfh.jf.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <171140738438.1574931.15717256954707430472.stgit@dwillia2-xfh.jf.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+5wbbaNK3IJOmvKGHkNKc4mxxhcoV2KFdM3R04XK7WoESydSX45+QMATQ10l?=
 =?us-ascii?Q?+lBsJfFS86N7nFthp5/BPKmrn4Eu6RCSRmNmFo7VKUfg9RHomZEGBcOjcgNC?=
 =?us-ascii?Q?Syxc+euLlgq/s9m8tIeTOXcJOaYLidsPSzFG4GOwC3MApl0Fd8fOudriVOUz?=
 =?us-ascii?Q?7mtiiblaSGD0YIyxtlS5YszyEeTMYBAZ5OjfUGyPmLPHQWF9C2CTGreuL2le?=
 =?us-ascii?Q?npYJJbTV4+OemqcrlHwRmfF/gfqAWonXo0OILLWDT+e6XT/bs9nKULjREkho?=
 =?us-ascii?Q?jeh3orb4SosCEPl1+4omCh1zAxN2xrnGaxw5pqbh3cl0djV+gwPdtvt6ckD0?=
 =?us-ascii?Q?q38XVlOx+TGolXEUh3z0lzrLVkE9VJWvRKeUll4en6QrTvK0QTHXBjnljDA3?=
 =?us-ascii?Q?2RP4g6o1i9ON5sNaUjcjgqWC5gszDGtIJtk40W0djOnKJVEVEHkYSKI09h3f?=
 =?us-ascii?Q?MUfcDjMkE+zJHLSflqJRM6XBEfWZkau/VIWDCZ4HU8PT2aojxiNRnin3yh9X?=
 =?us-ascii?Q?9bwKipUswxP28k861qsZk0dHbmdopvmrHAQbn9KqirDUj3zhbVpEay9gfZNc?=
 =?us-ascii?Q?5wl8SIQtSEYp0V8K6WJ2byYAIiowrocM4BlyLdw6/UjNp156dXriwSKmwbW1?=
 =?us-ascii?Q?4KmwFXexM6RPvmv2yw6NFfuZB0yTGntFGo5auF38Pys/0YfipOYkN0HyMNc+?=
 =?us-ascii?Q?6JPsWOvoQeyJem33oiwRaPakPJdHHAwy7p3eOa64amwH57PO2RD3UM2EStOr?=
 =?us-ascii?Q?dEvofz4cijZakTPUhATG+UM89xTKljhDydejtRUMg69PT4r8qLb2gxm1w68p?=
 =?us-ascii?Q?nH48pqFNhWcXFWscidpDVrf9UFC4Fs271F3SgG+gdon+FxTY0q+EtZypMB1p?=
 =?us-ascii?Q?+Cc6d8qEs/W+0+Ja/O0ztCdxb3Rs6KGdZvxnmsPYeH7BqBHg9OndNiFCFnva?=
 =?us-ascii?Q?iBqQ+5e8Md0OkkW1JGY2xz3A5CbKd7Vg/7A5Q5Hiy7g2CauMEnjswnlQ6w25?=
 =?us-ascii?Q?lmEhytKAAaODzV9nmWKG1dUNLe9InKhaLX898hiRNHxYO4BJLcHfHtngDi0R?=
 =?us-ascii?Q?n4OR8JptYpx/ItNFCuNZJYEj3ATmx3UV5FChxQ//CuHj/eA2eq0NzKi5Y/EL?=
 =?us-ascii?Q?XJZGKShESqKOgva4w/fC3GhX7rGGYBEGuumzQPHV66WP5m5TymXUOPkmX5Fl?=
 =?us-ascii?Q?SNd3tTsRYuBuDnPLuiLZph0DR6WHlT8B48rH2GdWRPDDjcifi98Xls2b77m2?=
 =?us-ascii?Q?/8+tleKzrf4GUz061Gx5Jsr44Kj15N9q4lUPCL7DEdHP+Nt3TfQwIMYl6+Ev?=
 =?us-ascii?Q?OW+j5fYpjeJzQ987PA+yTHP4X6asuVukY7AHGL8QLg4OpJvU/6W7dL26QUTY?=
 =?us-ascii?Q?rKqWCYu4ht1bAwTEkuxlrT+a11AuqjbpGuqpbWazAlteRt3iLPRZc2PW8IUP?=
 =?us-ascii?Q?UdrgTmxUI+Pzx5wZMLjh3kE556vPqfrP11aQDnbOnmHpKlqL+onPSE6Uqsie?=
 =?us-ascii?Q?1hO9qdOwR8muT8YGAQ0GcrHGA3n8hI9eAAVaqleSS8KJGfSkpUog93O4SQ1J?=
 =?us-ascii?Q?o3CkSY8Ma3ppc1vQ7Pj6CdGGwcLRFmY3kWLuSzrBUNu3cCsrVQAhNOj++Nnh?=
 =?us-ascii?Q?ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7b82d6-3e8d-4939-b3f8-08dc4dbd2637
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 17:49:56.7299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mYQk/NcuLwChcvJHuTQCcicWxOYj2Ia+m3Z9AIPnrJvNdxXVPF9gAXSZbTgzpTKb+ZqXnN35lBFdq9jMbZDZXEg+45fBG3AdYdD9ksIutAI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7776
X-OriginatorOrg: intel.com

Dan Williams wrote:
[..]
> diff --git a/include/linux/cleanup.h b/include/linux/cleanup.h
> index c2d09bc4f976..8ef2d91c2cbf 100644
> --- a/include/linux/cleanup.h
> +++ b/include/linux/cleanup.h
[..]
> + * When the unwind order matters it requires that variables be defined
> + * mid-function scope rather than at the top of the file.  Take the
> + * following example and notice the bug highlighted by "!!":
> + *
> + * ::
> + *
> + *	LIST_HEAD(list);
> + *	DEFINE_MUTEX(lock);
> + *
> + *	struct object {
> + *	        struct list_head node;
> + *	};
> + *
> + *	static struct object *alloc_add(void)
> + *	{
> + *	        struct object *obj;
> + *
> + *	        lockdep_assert_held(&lock);
> + *	        obj = kfree(sizeof(*obj), GFP_KERNEL);

This should be kzalloc(), and I should note that this example is of the
UNTESTED variety.