To: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sct@redhat.com
Subject: Re: [PATCH] Convert ext3_ioctl() to an unlocked_ioctl
References: <1200573450-1246-1-git-send-email-mathieu.segaud@regala.cx>
	<1200573450-1246-2-git-send-email-mathieu.segaud@regala.cx>
From: Mathieu SEGAUD <mathieu.segaud@regala.cx>
Date: Fri, 18 Jan 2008 00:48:29 +0100
In-Reply-To: <1200573450-1246-2-git-send-email-mathieu.segaud@regala.cx> (Mathieu Segaud's message of "Thu\, 17 Jan 2008 13\:37\:29 +0100")
Message-ID: <87wsq89foy.fsf@barad-dur.regala.cx>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1040
Lines: 43

Vous m'avez dit r?cemment :

> --- a/fs/ext3/ioctl.c
> +++ b/fs/ext3/ioctl.c
> @@ -17,12 +17,19 @@
>  #include <linux/smp_lock.h>
>  #include <asm/uaccess.h>
>  
> -int ext3_ioctl (struct inode * inode, struct file * filp, unsigned int cmd,
> +long ext3_ioctl(struct file *filp, unsigned int cmd,
>  		unsigned long arg)
>  {
> -	struct ext3_inode_info *ei = EXT3_I(inode);
> +	struct ext3_inode_info *ei;
> +	struct inode *inode;
>  	unsigned int flags;
>  	unsigned short rsv_window_size;
> +	long retval = 0;
> +
> +	lock_kernel();
> +
> +	inode = filp->f_dentry->d_inode;

I guess this should be
        inode = filp->f_path.dentry->d_inode;


I will repost a fixed patch
sorry for this one.


> +	ei = EXT3_I(inode);
>  
>  	ext3_debug ("cmd = %u, arg = %lu\n", cmd, arg);
>  

-- 
Mathieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/