Received-SPF: pass (google.com: domain of linux-kernel+bounces-119611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0033d14d-f1ad-4e18-8b9d-42aa255391c5@amd.com>
Date: Tue, 26 Mar 2024 23:04:54 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: add support of bios dump in devcoredump
To: Alex Deucher <alexdeucher@gmail.com>, Sunil Khatri <sunil.khatri@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 Shashank Sharma <shashank.sharma@amd.com>, amd-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 Hawking Zhang <Hawking.Zhang@amd.com>,
 Felix Kuehling <Felix.Kuehling@amd.com>, Lijo Lazar <lijo.lazar@amd.com>
References: <20240326143750.2292945-1-sunil.khatri@amd.com>
 <CADnq5_Nm6gyMf1mhGiyVDe6n69yabdf8EN5t=OmzJ7oBVZmEtQ@mail.gmail.com>
Content-Language: en-US
From: "Khatri, Sunil" <sukhatri@amd.com>
In-Reply-To: <CADnq5_Nm6gyMf1mhGiyVDe6n69yabdf8EN5t=OmzJ7oBVZmEtQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZnFqUkM2eEVOblhLMGhrSkV4elR0eGdxNU1sN0dNTkJESWVObS9LUmpPOFBX?=
 =?utf-8?B?WjhKT3ZVTXpubzQ1cHFRUWRibzBXVFB4KzVmVzg4ZTNhcGpoQWtpOEdlR2FW?=
 =?utf-8?B?VUJ6OVBHMmJGblo5MlRMOUhuOFNLd0p2QmYwT25SSUJTU014SUJ6TkpnVDJu?=
 =?utf-8?B?bGNqTlo4aEJMSmpYRXA5UlR4ZHdtYWtuUUtaNlBjWDBlcCtXUm5vc0pPTnVW?=
 =?utf-8?B?WE45bEx6Q3c3WkJFZnRVRGg1RFZ1R2t5Y3B2ZlVYWUJQaXJtUVg2MDgrbUl2?=
 =?utf-8?B?eWpmQmt4MmcwOUpraFFmckc4S0RXZnVRbWRoSXBSV3FxL2Jhd28wemplVVl0?=
 =?utf-8?B?SFptY3ZheUg2eFkzdHFENlhXUVBjU2lZR1RFazUzYmFCRnpTL011VnZTZFdH?=
 =?utf-8?B?OFNKem5idUlhRTc3Q0hjSXFGZlA4aS9zOEV0K3JVN1ZzcDJVdi9wVWY0VkZr?=
 =?utf-8?B?eWgrV1I5c2FqcTkybjZTMlk1M0h1SktGU2hrK25zRFZodzBXMnU4NXNkTEJX?=
 =?utf-8?B?YUUyMXdxUFFpMHJMeEp5WkRBSDZiejFQUngrN2VwR2RvOFpVTWo1U1cyUDd1?=
 =?utf-8?B?VTd2YUU2K0xzUUNRWFF0SlBxeGNqZFhIdGVOaFNVMkIvUmdZdHU4UWZXUmRX?=
 =?utf-8?B?UzJTSjd5QVNhb3RnSjhpQndWTlVSZWM2MzlEeTNYQzVjdldlL29OWmxiR2tz?=
 =?utf-8?B?UVhFdmFPZGMzTU9rRDVhM3h3VHE5RTJYWHhPSGdtZVE2RkhLVkhrb3NCYWZY?=
 =?utf-8?B?c3dtUE1TaFA0TzEreDhVenVFUk5tZ0NrVUdqZGp2NDR0ZS9qL0E4RGZhdUk4?=
 =?utf-8?B?QlRXVXIraU5DWU1WOEZiY3F1Q3M1MHFTWWt2elJyNElsa3hJdU53enVGK0pM?=
 =?utf-8?B?TGFodWRaVFRzblhXRlk0Qm01RndXM0hUUnUydkhveG9yQ3o2VXhGRktxbDVs?=
 =?utf-8?B?UUpHaXcrbk5PTU8rR2xNaTZqWXN1V1JmZzdvb1Z1VGtGOUYreXBWUE5PODZM?=
 =?utf-8?B?REpCeHdCelRFSFZSSy91aFFjR2V6RzJicFN4NEI4WGFtR1NEU0hlZmVWMEdG?=
 =?utf-8?B?eUFVdlVIdTRaQVNTM1UrYks5OFZKcXJCOTlSNlA0SnB5dmZ2VHVnVjU4UkI4?=
 =?utf-8?B?NDdsYUtiTXQ0M1NFZytmOC9xNkFIQjdYUko5WFM1am96MlIvaUVnZm5qc240?=
 =?utf-8?B?NTB0TkJQaDJDWGVYRGJzZzFWZTVDalE5aUJZSE9LT0FmOWVSMktBMGNZZ2Fx?=
 =?utf-8?B?SU1OT0NjYURkWXRjZHJKcktLZU9IMDdIKzkvMm9ZWUcwdVFDTE9WVXpsRnJu?=
 =?utf-8?B?Y2tnYWZtVmo2YzJQa3dnWlZlWm9kTmpLV28ySXJ2SVNRTisrOCtKVWZkNmlD?=
 =?utf-8?B?SW1JdkM4L0FEMHBVbDhlTWltN3dLbEIxL051Qi9oOVFFOXBjck9oRGNlUVJj?=
 =?utf-8?B?Y2R6TGx0MW1kNVN0Uk9ZL1BFSHZDUGtnSW16Tnl6SHkyOE5lb0Y1V3dMSEN4?=
 =?utf-8?B?RUpVaXkxUi9FVDdvMWJDWHdPamg0N3E4Zjg4QlA1TVdhSjFtZ2ZzeG9EV1ND?=
 =?utf-8?B?ald4NHdXeURGcWhaUndDTEVxWVBtK0dzS1hsQUp0aDkrQUR5UUVDVWc1d1ZZ?=
 =?utf-8?B?T1U3SjVlRU5oUG1zTmsvVHpWUjdjR2hPVkVzdTdYSUtQY25VQ3VKMlNFWVZv?=
 =?utf-8?B?b1E5RmVVcm91QTM3U2dDNXRQRlZZVk1Tc2llRTY1UGphd2pyUnAxV2cvcndP?=
 =?utf-8?B?WlljRFMwNkJBZkgrQXNtS3lnbDVuSjhsRU5lODFVUGpSakszcnEzdUVRWkFk?=
 =?utf-8?B?K1RwcXA1Nll2cy93R2Vld0JNTFhNQW5ieC9RcHRHZTRIWkV3YWZ2Y0FJOGZI?=
 =?utf-8?B?eDExb2Q0WGtKU2RjVEhVdC91aXFac29XbHVUQ3BPY21ncm5sUVUvRlljUTM3?=
 =?utf-8?B?MWRJbXlGNEVYSzQzVmNOdWxTdFkrUFFiMUZ1VkU2cmpEUHZhL0h0dTV3ZG04?=
 =?utf-8?B?SXZ5V1JzMW9tcmhuaTRxUUcvSzVpVlZPdnFrS1pYQUNEanAyc1JKUWE4bXJn?=
 =?utf-8?B?bW5oMlRBWFNhaHpjZ0dRRllCTXlWZUErV3VvaGZLKzdtSDFrSmY5RDN6Q2lH?=
 =?utf-8?Q?cwG1Gjf5fwVu9V/MuOUriwvvs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd8514fa-93b4-4748-7eee-08dc4dbb11f1
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5596.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 17:35:03.8486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qArqkOm09c4BxPpYjZzoSS21QcrwCukG71xhZPTv0aXuYid7Ct1nsaRybfimAyWE6MbWNT+BG08m62iQdKVzOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6247


On 3/26/2024 10:23 PM, Alex Deucher wrote:
> On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri <sunil.khatri@amd.com> wrote:
>> dump the bios binary in the devcoredump.
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
>> ---
>>   .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c  | 20 +++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> index 44c5da8aa9ce..f33963d777eb 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
>> @@ -132,6 +132,26 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>>          drm_printf(&p, "Faulty page starting at address: 0x%016llx\n", fault_info->addr);
>>          drm_printf(&p, "Protection fault status register: 0x%x\n\n", fault_info->status);
>>
>> +       /* Dump BIOS */
>> +       if (coredump->adev->bios && coredump->adev->bios_size) {
>> +               int i = 0;
>> +
>> +               drm_printf(&p, "BIOS Binary dump\n");
>> +               drm_printf(&p, "Valid BIOS  Size:%d bytes type:%s\n",
>> +                          coredump->adev->bios_size,
>> +                          coredump->adev->is_atom_fw ?
>> +                          "Atom bios":"Non Atom Bios");
>> +
>> +               while (i < coredump->adev->bios_size) {
>> +                       /* Printing 15 bytes in a line */
>> +                       if (i % 15 == 0)
>> +                               drm_printf(&p, "\n");
>> +                       drm_printf(&p, "0x%x \t", coredump->adev->bios[i]);
>> +                       i++;
>> +               }
>> +               drm_printf(&p, "\n");
>> +       }
> I don't think it's too useful to dump this as text.  I was hoping it
> could be a binary.  I guess, we can just get this from debugfs if we
> need it if a binary is not possible.


Yes , this dumps in text format only and the binary is already available 
in debugfs. So discarding the patch.

>
> Alex
>
>
>> +
>>          /* Add ring buffer information */
>>          drm_printf(&p, "Ring buffer information\n");
>>          for (int i = 0; i < coredump->adev->num_rings; i++) {
>> --
>> 2.34.1
>>