Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759913AbYAQXuS (ORCPT ); Thu, 17 Jan 2008 18:50:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756647AbYAQXuF (ORCPT ); Thu, 17 Jan 2008 18:50:05 -0500 Received: from def92-3-81-56-114-101.fbx.proxad.net ([81.56.114.101]:38858 "EHLO barad-dur.regala.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbYAQXuD (ORCPT ); Thu, 17 Jan 2008 18:50:03 -0500 To: linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sct@redhat.com Subject: Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl References: <1200573450-1246-1-git-send-email-mathieu.segaud@regala.cx> <1200573450-1246-2-git-send-email-mathieu.segaud@regala.cx> <1200573450-1246-3-git-send-email-mathieu.segaud@regala.cx> From: Mathieu SEGAUD Date: Fri, 18 Jan 2008 00:50:01 +0100 In-Reply-To: <1200573450-1246-3-git-send-email-mathieu.segaud@regala.cx> (Mathieu Segaud's message of "Thu\, 17 Jan 2008 13\:37\:30 +0100") Message-ID: <87sl0w9fme.fsf@barad-dur.regala.cx> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 36 Vous m'avez dit r?cemment : as well for this one, > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -17,12 +17,18 @@ > #include > #include > > -int ext4_ioctl (struct inode * inode, struct file * filp, unsigned int cmd, > - unsigned long arg) > +long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > { > - struct ext4_inode_info *ei = EXT4_I(inode); > + struct ext4_inode_info *ei; > + struct inode *inode; > unsigned int flags; > unsigned short rsv_window_size; > + long retval = 0; > + > + lock_kernel(); > + > + inode = filp->f_dentry->d_inode; this should be inode = filp->f_path.dentry->d_inode; I will update this one too, sorry for this one as well :-) -- Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/