Received-SPF: pass (google.com: domain of linux-kernel+bounces-119653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Avri Altman <Avri.Altman@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>, Bart Van Assche
	<bvanassche@acm.org>
CC: "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen"
	<martin.petersen@oracle.com>, Bean Huo <beanhuo@micron.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions
Thread-Topic: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions
Thread-Index: AQHaf1hBCRqbUYC+WEG5POc3Xd9iP7FKRQiAgAAArICAAAzeIA==
Date: Tue, 26 Mar 2024 18:09:00 +0000
Message-ID:
 <DM6PR04MB65759B575F7D218385BBB4B7FC352@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20240326083253.1303-1-avri.altman@wdc.com>
 <20240326083253.1303-2-avri.altman@wdc.com>
 <7d3a83b5-6dc7-40d2-8a2e-bd5157a3f8ea@acm.org>
 <ZgMEXZffmEqyRgVU@infradead.org>
In-Reply-To: <ZgMEXZffmEqyRgVU@infradead.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?AltgCZZOKKbc0q0l+s6uUe3y2wJL1HYKPnFeC5r//h8GK4BRgFYr2CULlRNP?=
 =?us-ascii?Q?Y7YAhnjRIz6L1lJ8XUyOPuzPthLqSgstUqGoMQmC5fBeNLZmT9UuBPzZTLUh?=
 =?us-ascii?Q?L493bHO4GFJNbv316JdorAwPbTCjJQvi1/0hcTBtRu3AW2KHaPMjSE/nD7mw?=
 =?us-ascii?Q?3C1qgjga0PWPE5QErJxPZhHle/nhgb1H2oX9Rsc+CgBTmNJmCbcaGH+uaUl1?=
 =?us-ascii?Q?vus/pUXBTDA8bhn+2R9Hwq9OQWD8KwHcFUEBmpny/bWUHqSFUaYJ5tfGMTkM?=
 =?us-ascii?Q?qHsAmQMORXDOALBJbz97N4BbDmg9a7zr1D/X87XNG4NHxcPrwtl432qviX/k?=
 =?us-ascii?Q?zy/3htZVwoTijJJrom1H56tR+rO9nRrUIn4vPA7t1Z7ohjt5EkcZ7U2SgWcE?=
 =?us-ascii?Q?eheInF4zGPoBIU4y63TUe6oRqhMvtiKBFkObawLN1KRKiRp03H97keW1IOtO?=
 =?us-ascii?Q?503KWuQ1JX4c+Dgw7sUk1WGB0fvs9cRcrmjywyPD/9Lg/RJta7NbaPbZUWku?=
 =?us-ascii?Q?RWtQrNPLpsP+swL+4rN65qdFNdRzImUMyODb88s4bw3s4jPy06sh5DDCI6yT?=
 =?us-ascii?Q?JVFhOP85liKMjNR5QUPyRZGjbDxodQOO6FxmXRGwLwyQiMc56boPsMqS1GX8?=
 =?us-ascii?Q?+4xzMCpyiT6gz/wgzL0CnZBLaobMXrLZaO3AXT6yO49fYHGhhVPD1MM/c476?=
 =?us-ascii?Q?KnIKWg8sHkXz9HNalZCUZXXwxbGXHrbW0w9ldUdzGXXxJpgn7GQHB1kJt2Cn?=
 =?us-ascii?Q?OiXCkiMnt1k4OFjpPJDTVQwvmG8RnES7dtuRi7W7WH8EHM4GS0aU6M06rNzd?=
 =?us-ascii?Q?Ib77gtVLuybjucsLvmJuUc+JgksKITM2n4IUxov4cBnB0beSi1E0IfaPOSfX?=
 =?us-ascii?Q?iMzoruznPADu+Ui6EK3/NNbe5kJVWyssyqFo0oGZh9lJ0AR+aRqsBIMZjV/R?=
 =?us-ascii?Q?Y13kTPxSQWo8KUif3+jzCrSqT9s8kFNLGwEgCrRIo2UatCGKeTQRQIfWiSO1?=
 =?us-ascii?Q?Aa6K+HPA9QzJ8PZX02nj4XZPOavzZDztrkmvsxhG38c3tfRWAUr9zgdbR+Sp?=
 =?us-ascii?Q?ZgaHSsG7AJl8RZ3fnxLATa0Z3XsaULvgnVPQySi6R39VOTLcnCzTKIRQnfjC?=
 =?us-ascii?Q?bg9OtP6sHQ/m09XW5wU6mfMUGq3oyBQSipUIUR7uL9Z1URnxI7MPFFZodfuI?=
 =?us-ascii?Q?5NLCTznJ+cywQhkzAryrIpJgnGdlG3PusUbfgBXPVjMwzoEkrqkhMkHLNrsN?=
 =?us-ascii?Q?2mxd8INy7DXA9usBcBDivF0AkkVHyhqcrJt3zSSt0TA3IfnpeF0Q7X9BDqX9?=
 =?us-ascii?Q?ADiZoOq/0Gaz/W5q0lnpS8zoRx28mXMWyi07L1bpOAyczl2CC75r/L/LyBUH?=
 =?us-ascii?Q?2VEFrIKJlm9+kaf/ub1n4Eq9TV0dsjMVRLv6g0SOahykXkrookFEh3K+/PA7?=
 =?us-ascii?Q?/tHtALCH9k53xmUwtW2fMrMI2jQEGNC73eH1d82iUNwl4ajtMgCPyP4T3Ktn?=
 =?us-ascii?Q?08vE1R/DIb8JSDyZw2NFqXYKermnBeQ5sN1ffnfEgNiqsgDCm/Smz6ul9J7t?=
 =?us-ascii?Q?SW6s4UgRvsOp2RTCFgJDVVGqxeBUzhGIP4wCUXFm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	8zlFKoEw4dLmAOGaltk0aeIAGRStR8tPpUzPWsBiZ+MJkxe2z8kxSlbemGNnOG86k1ZN35BcA8qVCP9azBKImrvzNLvWUdW/Ksz1crNFp8XnSjXBddCgq90LhLCF9MVV/0plz1rsvJAJWm/GYtWUYFy029YsurSfwMJnNBbX4AB8SpzvdiZCJedvKYq2Dbk3b3VrApkS+My4XBTLbuZEQ/u8Y8c6VUZNrd9oFuu7wZZ9bxbh4TaQXzFn0zQ97QJ5ilnrcoKjLg/Y41Xat2Vlp15/AlJn7UGx+0duOZvwN0HklEC9WuwZOsd4qF6kGjLh7MZjI2y3anoObFc9Uq8mohkJlN5j4odXwz+G81bnu7OoJjygYolgSJn/l8aJSBZN/dZZL0TuATe9unilyExjn1Ft2Lqy7p7c3YGRyPzqu0uwPexMqxReZ4RjQwDU+7XLMxkPNUC+kR5goq6YB4BhklPjoHSpNIA2Jx2HxtbiVXruawziSflzPqyKtNz8O1ftYF0kt58dtw/Mc/4Wi/t3haTIkbyxP74f5JkFoo+KbJpj7jCGwegUrNc7lQO4LVwBdEslhJNmS5/Pet8vfx6o+v3c2o+Dii1x11uXXm9H3fh0a7FNsHLzp3hUKUiO1yih
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c5993ab-c606-4c29-0dc1-08dc4dbfd065
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 18:09:00.8653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IdpetTTqQJN9rBaqHLryZmmUkAnljLd/KrkfEN7N2BHs8f/Bmoj2zTXg1fPcIPp0F9301UY+ejfTeHylmJUUEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR04MB8581

> On Tue, Mar 26, 2024 at 10:20:13AM -0700, Bart Van Assche wrote:
> > On 3/26/24 01:32, Avri Altman wrote:
> > > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> > >   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> > >   {
> > > -   /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > > -   if (hba->ufs_version <=3D ufshci_version(1, 1))
> > > -           return UFS_UNIPRO_VER_1_41;
> > > -   else
> > >             return UFS_UNIPRO_VER_1_6;
> > >   }
> >
> > Please fix the indentation of the only remaining return statement in
> > this function.
>=20
> Even better just remove the function and use UFS_UNIPRO_VER_1_6 directly
> in the two callers.
Done.

Thanks,
Avri