Received-SPF: pass (google.com: domain of linux-kernel+bounces-119689-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 18:32:39 +0000
From: Conor Dooley <conor@kernel.org>
To: Tan Chun Hau <chunhau.tan@starfivetech.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Ley Foon Tan <leyfoon.tan@starfivetech.com>,
	Jee Heng Sia <jeeheng.sia@starfivetech.com>,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
 support
Message-ID: <20240326-maternity-alive-6cb8f6b2e037@spud>
References: <20240326095457.201572-1-chunhau.tan@starfivetech.com>
 <20240326095457.201572-2-chunhau.tan@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="hN0bqbopRWGDKaVk"
Content-Disposition: inline
In-Reply-To: <20240326095457.201572-2-chunhau.tan@starfivetech.com>


--hN0bqbopRWGDKaVk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> controller.

Your commit message should explain what makes this incompatible with
existing devices. That inforatiion does appear to be in the driver
patch, but should also be here. Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

>=20
> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml =
b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 363cf8bd150d..525f5f3932f5 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -21,6 +21,7 @@ properties:
>        - snps,axi-dma-1.01a
>        - intel,kmb-axi-dma
>        - starfive,jh7110-axi-dma
> +      - starfive,jh8100-axi-dma
> =20
>    reg:
>      minItems: 1
> --=20
> 2.25.1
>=20

--hN0bqbopRWGDKaVk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgMUxwAKCRB4tDGHoIJi
0vGxAP0e/9BfT/Cc5S7oAvgGnrjYwSinfk93mUrAKWU7SUAcWgD9EksxI511Ha//
B3vFWbGOJJZDcakWwlM9rjiatGEljAQ=
=Dmpe
-----END PGP SIGNATURE-----

--hN0bqbopRWGDKaVk--