Received-SPF: pass (google.com: domain of linux-kernel+bounces-119694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 18:37:25 +0000
To: Yazen Ghannam <yazen.ghannam@amd.com>, "bp@alien8.de" <bp@alien8.de>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
From: A <akira.2020@protonmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled
Message-ID: <tcsBk3Aptyd1jl1fHPAjd-OSYS1s-scsu-L24w59jkOzzblk20pNrYU5d_1j_rllZWVp5pxgzxfx4dkxT4zvnAfWw-bCIcDx0Q9TRU_Aja8=@protonmail.com>
In-Reply-To: <656a7134-4984-4577-93eb-60c0c28adf93@amd.com>
References: <20240325183755.776-1-bp@alien8.de> <eede2586-f143-4107-a065-2860ed413d0a@amd.com> <i2PhAcMufioQc2nhVgO9T23CcF8UsgJo8CWPOl_7lV3iF00GdywfpQa2Hu-yPX3bD4o5wpfUtIsRBIhFH1j3k9aNoUJfgGALNWUUjMokpFc=@protonmail.com> <656a7134-4984-4577-93eb-60c0c28adf93@amd.com>
Feedback-ID: 7267082:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tuesday, March 26th, 2024 at 14:29, Yazen Ghannam <yazen.ghannam@amd.com=
> wrote:

>=20
>=20
> On 3/26/24 10:20, A wrote:
> [...]
>=20
> > > diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h
> > > index 4749ccdeeba1..ab95831e7710 100644
> > > --- a/drivers/ras/debugfs.h
> > > +++ b/drivers/ras/debugfs.h
> > > @@ -4,6 +4,10 @@
> > >=20
> > > #include <linux/debugfs.h>
> > >=20
> > > +#if IS_ENABLED(DEBUG_FS)
> > > struct dentry *ras_get_debugfs_root(void);
> > > +#else
> > > +static inline struct dentry ras_get_debugfs_root(void) { return NULL=
; }
> > > +#endif / DEBUG_FS /
> > >=20
> > > #endif / RAS_DEBUGFS_H */
> >=20
> > this also works, just tested
> >=20
> > this time round, `make oldconfig` asks if i want to build RAS_FMPM, i b=
uilt it as module, compilation succeeds.
>=20
>=20
> Thanks for testing!
>=20
> Would you mind including your "Tested-by" tag? I can include this when I
> send a proper patch.
>=20
> Thanks,
> Yazen

sure, tested-by:  anthony s. knowles <akira.2020@protonmail.com>

kind regards,
a.s.k