Subject: Re: [PATCH] fix wrong sized spinlock flags argument
From: Daniel Walker <dwalker@mvista.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Maxim Levitsky <maximlevitsky@gmail.com>,
       Mauro Carvalho Chehab <mchehab@infradead.org>
In-Reply-To: <alpine.LFD.1.00.0801171542390.2957@woody.linux-foundation.org>
References: <20080117205205.878723737@mvista.com>
	 <alpine.LFD.1.00.0801171542390.2957@woody.linux-foundation.org>
Content-Type: text/plain
Date: Thu, 17 Jan 2008 16:05:06 -0800
Message-Id: <1200614706.18731.170.camel@imap.mvista.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 26


On Thu, 2008-01-17 at 15:48 -0800, Linus Torvalds wrote:
> Applied.
> 
> However, the patch itself didn't apply cleanly, because in my souce tree, 
> these two lines are in a different order:
> 
> On Thu, 17 Jan 2008, Daniel Walker wrote:
> >  
> >  	pci_set_power_state(pci_dev, PCI_D0);
> >  	pci_restore_state(pci_dev);
> 
> but I actually think your order is the *correct* one (because I'm not at 
> all sure that config space writes are even guaranteed to make a difference 
> when in D3cold).

I was actually using 2.6.24-rc8-mm1 . The code looked similar enough,
but I must have overlooked the fact that the lines above got switched..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/