Received: by 2002:a05:7208:3003:b0:81:def:69cd with SMTP id f3csp161526rba; Tue, 26 Mar 2024 12:03:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVygsc0l1a11DUtaJX2ualYrQpAYF/XwTOfmIj51D9vxozbTisgrgOACcsa9ws4yqufmRvgrxlHcGGvmcfwWjgZVeVVB8iI5CmtpkhH0A== X-Google-Smtp-Source: AGHT+IHcMFXaeIQP/4vr7RiWX1JHij9ZgidLy9sXk1kmyhf6/EnbKGBfKEsACt8bKKml2jPrTn0/ X-Received: by 2002:a05:620a:569a:b0:78a:6a4b:3e32 with SMTP id wg26-20020a05620a569a00b0078a6a4b3e32mr641414qkn.52.1711479830603; Tue, 26 Mar 2024 12:03:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711479830; cv=pass; d=google.com; s=arc-20160816; b=ZUijdGnvVLd1hhlZjsSsIJ1OLWb4h8AJKuTAbmozxso7U9bZzLseKFdUXTtRNR4kEs Ky5X0cfdrzRm2UQPTze1xf7YbS5rnkZvhNbJkCVz4V3c84rLzNwaU75Gx9dviOzBQ7EE CNOhGGdkBZrUha6VgxpiFYGtOqJypVXPEDdMNfyS1z2rDvIAQ+NNuJ7lKVLDEYXBeFnU /ACEZAUaUYn+PHAmiP5m+6cAKCu1LnAHp4Y0CU3C01ySfo5NwIekRk/4zxEEe6YrLTFk GRtLO2iThtfFhrqmG3c5/f57nD4c9ztiH9IGaabQDrMCVXZe7LkkaWosm+7OMKllEhM9 tcLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=58Og6mClFpuZYo8vUqhr3GDNl3GwXaf3odQm281+asM=; fh=jNyvWRPoNESYJjuGBz6Pbi/OkRTLgSXagzQ2TFmUqUw=; b=JB39EmL3d8B0K72PbuO1MQ6z6PoAUDS/1pPG8XItl2cARG6nHpBlMFl4aXUnO9y8+m AiSYoRr0/iHQ7fxCULdcY/fhl+dgjLbutvnQoHFRL/KQANVSXAftVXOvsBMIZrlQx0W/ dgiEwmLCWqcFg8/nBU0bvdR59qN5oPqPHrTt6aBXCOSCxLtH26GUVikEHsygMLqsD0fR OkAP0PAa2QWH7jR4GXpH9dsWh8pR7OXua+JBPXXzEzm10mK84q4InWZ5YPQDcr121MLx d/KAMPKlMIAmwbUJzQsvMp8LuRIl4Rwqpq9zbo2oqAfbpSeAhBoM7Oh3eeRd3Nq9lxxg juig==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ihaYLwbg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119740-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id cx20-20020a05620a51d400b0078a684134fbsi1294798qkb.248.2024.03.26.12.03.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 12:03:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ihaYLwbg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119740-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5835C1C27E91 for ; Tue, 26 Mar 2024 19:03:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6A0313CA9F; Tue, 26 Mar 2024 19:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ihaYLwbg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA63714265; Tue, 26 Mar 2024 19:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479820; cv=none; b=N8CHiy2sAIJy6hElRVrAQXpJbf9nAw8X9RGJz07I/f0NxeJUJPwEc3KCk10DkTYFIRhuta1hz8Q25pjpXZEYNmoJVdCS30FzSlPbAHf9w4puVkAoOUTHS4zGcRavZXBZin1hZcjRYX1pnh/czVrYsrPdfDhkkh1m/ow/mKAlYVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479820; c=relaxed/simple; bh=2O7P9bmVcg0Kq2po/kca7Jb6SbR0Yf2nXAhLTI+L0LQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l9Pb+MpqMNC2G2B7zB/VPXpgciBM+HT9+5VaDILXvxhtWkKFCWNwOYqg7RTDu1LwdqgzeKulMfzsdarjgLmv2/7bsqMs0RXW41p5Z8SEh0UCPOeuTJbydgeKMozaKwAnm8PmJ9hcJ3+vfT/GFN3em/dj93kXCEou5TwEUHTmtwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ihaYLwbg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD9FDC433C7; Tue, 26 Mar 2024 19:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479820; bh=2O7P9bmVcg0Kq2po/kca7Jb6SbR0Yf2nXAhLTI+L0LQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ihaYLwbg6ft4kMBgQSW12OfNiBgvASonphe8YsY2QnG1VZFlZYfBRQzwIb/fha5Vw hHCfKvytFVvPJYU+WHCeVzOkIFwpjlec4XkHtw8lrphvdsImcp/usqP1jIfVODZDsV biEz59XE2frgLDLpP3MENKY6x8dR+ORYaaLJMqDofBfHbQboTqG4uCOpqE/AAUPcAO e+OwLZLKsngtlGI6pJ1KLkMYGaG3DQHmNytjaEIctskuLrx2/8HX6AF/a8xsJ8FSTx WuJ0W8DDJGHy3iW5IFPXeOIGInopzLc3sDrTJ1xAVWtwExD0WwtkhCYHb/CL3T6MTg Wh9t8BAWMNxDg== Date: Tue, 26 Mar 2024 20:03:36 +0100 From: Andi Shyti To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/64] i2c: bcm2835: reword according to newest specification Message-ID: References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com> <20240322132619.6389-10-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322132619.6389-10-wsa+renesas@sang-engineering.com> Hi Wolfram, > @@ -391,7 +391,7 @@ static u32 bcm2835_i2c_func(struct i2c_adapter *adap) > } > > static const struct i2c_algorithm bcm2835_i2c_algo = { > - .master_xfer = bcm2835_i2c_xfer, > + .xfer = bcm2835_i2c_xfer, Here you are breaking the alignment (even though I think a "tab" alignment is not needed). Andi