Received-SPF: pass (google.com: domain of linux-kernel+bounces-119788-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 26 Mar 2024 15:20:05 -0400
From: Sasha Levin <sashal@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Nicholas Piggin <npiggin@gmail.com>,
	Geoff Levand <geoff@infradead.org>
Subject: Re: [PATCH 6.6 430/638] powerpc/ps3: Fix lv1 hcall assembly for
 ELFv2 calling convention
Message-ID: <ZgMf5YDxqK3mD043@sashalap>
References: <20240324230116.1348576-1-sashal@kernel.org>
 <20240324230116.1348576-431-sashal@kernel.org>
 <87wmppip8g.fsf@mail.lhotse>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87wmppip8g.fsf@mail.lhotse>

On Tue, Mar 26, 2024 at 03:36:15PM +1100, Michael Ellerman wrote:
>Sasha Levin <sashal@kernel.org> writes:
>> From: Nicholas Piggin <npiggin@gmail.com>
>>
>> [ Upstream commit 6735fef14c1f089ae43fd6d43add818b7ff682a8 ]
>>
>> Stack-passed parameters begin at a different offset in the caller's
>> stack in the ELFv2 ABI.
>>
>> Reported-by: Geoff Levand <geoff@infradead.org>
>> Fixes: 8c5fa3b5c4df ("powerpc/64: Make ELFv2 the default for big-endian builds")
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>> Tested-by: Geoff Levand <geoff@infradead.org>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> Link: https://msgid.link/20231227072405.63751-2-npiggin@gmail.com
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>>  arch/powerpc/include/asm/ppc_asm.h  |  6 ++++--
>>  arch/powerpc/platforms/ps3/hvcall.S | 18 +++++++++---------
>>  2 files changed, 13 insertions(+), 11 deletions(-)
>
>This commit is OK on its own, but it doesn't have any effect unless the
>full series up to 914d081ead11 ("Revert "powerpc/ps3_defconfig: Disable
>PPC64_BIG_ENDIAN_ELF_ABI_V2"") is backported.
>
>I don't think the full series warrants backporting, it's really enabling
>a new feature (ELFv2 build for ps3).
>
>So IMHO please drop this patch from 6.6, 6.7, 6.8.

Dropped, thanks!

-- 
Thanks,
Sasha