Received-SPF: pass (google.com: domain of linux-kernel+bounces-119829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0aaae9ce-00ae-cd0b-ed25-4d52d1620ab5@intel.com>
Date: Tue, 26 Mar 2024 12:44:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 31/31] x86/resctrl: Move the resctrl filesystem code to
 /fs/resctrl
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Reinette Chatre <reinette.chatre@intel.com>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, H Peter Anvin <hpa@zytor.com>, Babu Moger
	<Babu.Moger@amd.com>, <shameerali.kolothum.thodi@huawei.com>, "D Scott
 Phillips OS" <scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-32-james.morse@arm.com>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20240321165106.31602-32-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWlhT0lDRlZQQzVxL3ZxcER3N1V2YStEejZJTHlCR3ZQOXFIaGlYZ1pIN1Br?=
 =?utf-8?B?MWhJVGlDdFkrS3VLUG1rNDVlU05UMFRZZEQrNzlMOUwvb0NPeGZWWlZENWJX?=
 =?utf-8?B?MmdjTHhNM0I1WWVFTkFocm5OYkhGYXRQR0hPNzVla1ZSWmNYdmdwRVVVZVhm?=
 =?utf-8?B?dmN3cFdjNWgvekFTTklzZmlzL3JydjN3V1VyRnhkS0RFTWR3VUltTDNQdlBZ?=
 =?utf-8?B?WXZRZUtiQ2J3WUY2UjgvNWlyTTNaNWRET2lQZ0hMRTB2bDMzY1NXMG9aSTBr?=
 =?utf-8?B?N3MvbThlc3pUNXNIMDgvOExoMEZxMnZXSnRBVmZTNXVHejgzQmE5Q1cranJ4?=
 =?utf-8?B?cHlneTBNWW1DbTk0Vkp6dXRjYlFNM3RtVExKRXc4VUtSSTRoelhzaXNrVWRU?=
 =?utf-8?B?dUpoREdUY3h5bVN4Zlc1VmRJRVM5aDdOakltZDZKOU54V1hWaEh6L2lLMVFN?=
 =?utf-8?B?eEM3THRtdWpLS2xIUFJzTzNjYnVRSEN4Y1Q3UVgvL01BT2orSnZqRWJjeCtT?=
 =?utf-8?B?U1Z0Y1U3QUpLMVloTERqaUpDaitoQWdWN1hoNFFsamZYc284dUl3SWdBOXNC?=
 =?utf-8?B?Skc1dGdGVmZsTGxGSHYyYXMxSlg3cnhlR2c2UVpMTXovdFFIdStuQmtaRWZ5?=
 =?utf-8?B?Um14SHJHYk1JQVp0SzIxQjBoNUxrdDdJK2NiUXluSEsvNWNWQm1FNkZjVERu?=
 =?utf-8?B?L3ZnNkN0ZGZ3VVVnL0hpRE1LMEozN3Q3dGhLSEZqQWdXSG1DM1NaWjVtQWha?=
 =?utf-8?B?blJ1bUFkdDVROHlUbDVHS0UwTjc5ZFZpSXRFWW5uUUt4c1BhTDVXOEVqd0NV?=
 =?utf-8?B?Q0dSeS9Od3FWTlpYb0dSR2I1NFU5MW9aQnlpYmxkN3pwUTZqT2FnNlE4ZDNX?=
 =?utf-8?B?WGdJNEtaREd6VUNYMTBMSGxQRkdoUW9JTTArWjFJaGdORnRUaGF2KzFlR2dU?=
 =?utf-8?B?V1NvMWNIcmRUVVlDb1N5SnYvdS9QTTJlRnpKaGdZanAxbDJhVUk5RmpidTU5?=
 =?utf-8?B?TEtEMmIzZUliL04xay9LZG9IeGltOWg2YkJNeXd3eFc1TjZlQWJSWktsNWxQ?=
 =?utf-8?B?VVYzaGE0MGhiSWVaV1JzeStoWlBuNVlKSUp5UVBOS01sM1hPSWJsUkFTaXF6?=
 =?utf-8?B?WXZJR09KVXhPVnkrQ2ptV2trNkU2NXlBeGZxVGhqVHI0OHZNMitvRlRpZHJ0?=
 =?utf-8?B?b2dKNE92MnkrRXlqSGN3OHNQSXkvYWgxSFI0bjZJakxwVnZMNEZsRXpzdnBo?=
 =?utf-8?B?NGpiYnFlVXpjYzdZYlg1clJ6MVFxeElzdFI4MUxGcXdzbUJYak0wcGNLeWJo?=
 =?utf-8?B?SGl1S1NRMFFtL1o1RjRVWUllNG9CNW1HZHNFRk5tZituRnVTY0UyTXdVNzZk?=
 =?utf-8?B?ZXpDZlJlcEh4OGc5bmdMT3p5a2RFaHordExOazlCL21uenJmRVNJY0N4OFpD?=
 =?utf-8?B?cnZyTXRCakpKV3hPdytLUGVwOVBCdTljOU1sSGU3a2JPSHFjVnZFYmw1UXZI?=
 =?utf-8?B?SVRnbHh5Wkl5dlpxNWtqWitlVFBUMnppUkY1dmd4bjBXSXcvOVdoMWpwSmhO?=
 =?utf-8?B?clBhZC9XLzFHeVI1YjVCM09uOG9QTE00UHV5bmIzaFY0SEJCL3RBNllSMmxj?=
 =?utf-8?B?SVdwbU12RkZhaXZhb0dTYlZvRkVQVDAxS0NVMTNwakFPOHZ4b1N3dXJ6eE1r?=
 =?utf-8?B?RVNOdS9paW8vZ0tqZkVWbklla2hoRHgxd21UcHdDOVY2cnA0R0tscHZsTEZD?=
 =?utf-8?B?dUhuM2RZaFI3ZzB3bDJoZkFmbGN1NWRPRm8xdCsvaFNkeWdvRFNPZHBIWEN4?=
 =?utf-8?B?MkdtR0NmVTlDL1ZmUjBPeEJZekxYdUR2K3MyOFcvVWllektYV0EvcGdhQXpP?=
 =?utf-8?B?UmdPSm1TdkVOY3dvdzl5Y3VXMWlTek9RbEZ2R1hkMTZpMFdXVzVJK29nNFEz?=
 =?utf-8?B?MzdxejRuZ2dxU0R2UnNpWWZOc0c0cUhsVVhYV2tjbmtVRnROZlhpc0Vpd1lu?=
 =?utf-8?B?dzQwWXJlNVR6dFpBUG9DVHlGUk42cHBuWi8yU2l6cFErTWxGeWFaaFNDYmpn?=
 =?utf-8?B?MU5Ub3Eva3pDVUlkMHZMS2lvQnFEQkJvay9IbzYxaGJQMzlJQlV2VTlIcFJN?=
 =?utf-8?Q?uYztoPQHWt6thhl/qfbcPnoES?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e209c4d8-7dc3-4f38-6076-08dc4dcd1f4f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 19:44:17.1340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +BOQqD72pgYxyg8CRRhCp9qqDVu8xVH0IQyendaucEXXN3Ye5T+SrBTqlCbv7Qhdw6Jskde5/EfdnKqvjSdVWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8595
X-OriginatorOrg: intel.com

Hi, James,

On 3/21/24 09:51, James Morse wrote:
> resctrl is linux's defacto interface for managing cache and bandwidth
> policies for groups of tasks.
> 
> To allow other architectures to make use of this pseudo filesystem,
> move it live in /fs/resctrl instead of /arch/x86.
> 
> This move leaves behind the parts of resctrl that form the architecture
> interface for x86.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> Discussion needed on how/when to merge this, as it would conflict with
> all outstanding series. It's probably worth deferring to some opportune
> time, but is included here for illustration.
> ---
>   arch/x86/kernel/cpu/resctrl/core.c        |   15 -
>   arch/x86/kernel/cpu/resctrl/ctrlmondata.c |  505 ---
>   arch/x86/kernel/cpu/resctrl/internal.h    |  310 --
>   arch/x86/kernel/cpu/resctrl/monitor.c     |  821 -----
>   arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 1093 ------
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 3994 --------------------
>   fs/resctrl/ctrlmondata.c                  |  527 +++
>   fs/resctrl/internal.h                     |  340 ++
>   fs/resctrl/monitor.c                      |  843 +++++
>   fs/resctrl/psuedo_lock.c                  | 1122 ++++++
>   fs/resctrl/rdtgroup.c                     | 4013 +++++++++++++++++++++
>   11 files changed, 6845 insertions(+), 6738 deletions(-)
> 

checkpatch reports warnings and checks on this patch. Please fix them. e.g.

CHECK: Blank lines aren't necessary before a close brace '}'
#13340: FILE: fs/resctrl/rdtgroup.c:3184:
+
+	}

Thanks.

-Fenghua