Received-SPF: pass (google.com: domain of linux-kernel+bounces-119844-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0280fa9a-cdb0-5bf7-7940-3c2cda1da829@quicinc.com>
Date: Tue, 26 Mar 2024 12:56:03 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error:
 variable 'out' set but not used
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Rob Clark
	<robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
        Marijn Suijten
	<marijn.suijten@somainline.org>,
        David Airlie <airlied@gmail.com>, Daniel
 Vetter <daniel@ffwll.ch>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        <freedreno@lists.freedesktop.org>,
        linux-kernel
	<linux-kernel@vger.kernel.org>
References: <CANiq72mjc5t4n25SQvYSrOEhxxpXYPZ4pPzneSJHEnc3qApu2Q@mail.gmail.com>
 <CAA8EJprTNFgKJ_3cdZz4f_LCkYFghi-cfaj3bZmYh3oA63my6A@mail.gmail.com>
 <85204b78-7b24-61cd-4bae-3e7abc6e4fd3@quicinc.com>
 <CAA8EJppqrF10J1qExM=gopiF4GPDt7v4TB6LrQxx5OGyAL9hSg@mail.gmail.com>
 <671d2662-df4e-4350-0084-476eb1671cc1@quicinc.com>
 <CAA8EJpppre8ibYqN7gZObyvzR08yVbTevC6hDEDCKQVf8gRVRg@mail.gmail.com>
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <CAA8EJpppre8ibYqN7gZObyvzR08yVbTevC6hDEDCKQVf8gRVRg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/26/2024 12:47 PM, Dmitry Baryshkov wrote:
> On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>
>>
>>
>> On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
>>> On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>>>
>>>>
>>>>
>>>> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
>>>>> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
>>>>> <miguel.ojeda.sandonis@gmail.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> In today's next, I got:
>>>>>>
>>>>>>        drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
>>>>>> 'out' set but not used [-Werror,-Wunused-but-set-variable]
>>>>>>
>>>>>> `out` seems to be there since commit 64d6255650d4 ("drm/msm: More
>>>>>> fully implement devcoredump for a7xx").
>>>>>>
>>>>>> Untested diff below assuming `dumper->iova` is constant -- if you want
>>>>>> a formal patch, please let me know.
>>>>>
>>>>> Please send a proper patch that we can pick up.
>>>>>
>>>>
>>>> This should be fixed with https://patchwork.freedesktop.org/patch/581853/.
>>>
>>> Is that a correct fix? If you check other usage locations for
>>> CRASHDUMP_READ, you'll see that `out` is the last parameter and it is
>>> being incremented.
>>>
>>
>> Right but in this function out is not the last parameter of CRASHDUMP_READ.
> 
> Yes. I think in this case the patch from this email is more correct.
> 

Alright, in that case, Miguel can you please repost this with the Fixes 
tags and in a patch form.

>>
>> Maybe you or Rob can correct me but I thought the fix looked sane
>> although noone commented on that patch.
> 
>>
>>>>
>>>> We can pickup that one with a Fixes tag applied.
>>>>
>>>>>>
>>>>>> Cheers,
>>>>>> Miguel
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>>>> b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>>>> index 1f5245fc2cdc..a847a0f7a73c 100644
>>>>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>>>>>> @@ -852,7 +852,7 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
>>>>>>                 (block->type << 8) | i);
>>>>>>
>>>>>>             in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE,
>>>>>> -            block->size, dumper->iova + A6XX_CD_DATA_OFFSET);
>>>>>> +            block->size, out);
>>>>>>
>>>>>>             out += block->size * sizeof(u32);
>>>>>>         }
>>>>>
>>>>>
>>>>>
>>>
>>>
>>>
> 
> 
>