Received-SPF: pass (google.com: domain of linux-kernel+bounces-119578-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Mar 2024 10:22:37 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Avri Altman <avri.altman@wdc.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Bean Huo <beanhuo@micron.com>, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions
Message-ID: <ZgMEXZffmEqyRgVU@infradead.org>
References: <20240326083253.1303-1-avri.altman@wdc.com>
 <20240326083253.1303-2-avri.altman@wdc.com>
 <7d3a83b5-6dc7-40d2-8a2e-bd5157a3f8ea@acm.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d3a83b5-6dc7-40d2-8a2e-bd5157a3f8ea@acm.org>

On Tue, Mar 26, 2024 at 10:20:13AM -0700, Bart Van Assche wrote:
> On 3/26/24 01:32, Avri Altman wrote:
> > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> >   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> >   {
> > -	/* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > -	if (hba->ufs_version <= ufshci_version(1, 1))
> > -		return UFS_UNIPRO_VER_1_41;
> > -	else
> >   		return UFS_UNIPRO_VER_1_6;
> >   }
> 
> Please fix the indentation of the only remaining return statement in
> this function.

Even better just remove the function and use UFS_UNIPRO_VER_1_6
directly in the two callers.