Received: by 2002:ab2:f03:0:b0:1ef:ffd0:ce49 with SMTP id i3csp37995lqf; Tue, 26 Mar 2024 13:34:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCZqWOUQNN4j8ttompgA0ZVg/SP84/7WH2NuqPmaYsx8DSNfBnaceg1oGpeilDyeLpvvUXoCY/MeJOThoNjUR4HMPG2sG1kmUeWD+VDg== X-Google-Smtp-Source: AGHT+IFrN1fGhR77J+hVW6bKtZEQBvIMvwKqr/368URE31l1/WCyRT8j/NkWmkRobMBrNm5LhM1y X-Received: by 2002:a17:90b:787:b0:2a0:4685:c102 with SMTP id l7-20020a17090b078700b002a04685c102mr9955026pjz.23.1711485248972; Tue, 26 Mar 2024 13:34:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711485248; cv=pass; d=google.com; s=arc-20160816; b=faYNbZ4Khiz2yVUC0uUIz63H/CF/Z3sexipTzu4jAYznPzZHUnVurCrRo9zzU1uTG2 7h30ethij4R4/tpig0r6loIMzCFbKcP1NxKojljLmsRtMl5lhUW6n1OY7WxlZSad3G5N iy3La+N/tZJqoh7lMMTHnJgyv/Q/9q7CmrLbxtg/vuDzKx85/NUUOkktfR+wnwMdS6TL e3av+E8MLFJT7G6D/HmyKuw3VVhdgZcaAsL+AmTYVn1ntbDtjllrmaCyY60NM86CaWlS JOl6MPOV2O5W7wg8Uokm7o1hsLBvbW282N1B3rbf/fAew6JeU7tY1eVQvocG9vKzkKG1 AifQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=TM8yQ9QyFzi5QxUwkAfctOGoes45jiRy2j5+NoahEAU=; fh=vLJDppnjWSOAXeb8zdHksz8xgdA/ABv7DpcZZ+9PrTM=; b=RUf49bT5GgIcEgnbugDOpeOFRQisc4PtLnwnbzPFb9VnxdviWhJzBRFYDrMCc+Yupv rbXHeqcBeW2tL127JFm0W4fTttD9Ro90nj6kAAUwzm0O0/EwH4uM77qgC8vidyaiuL2A ds/NlV1KO9INNrWofhcobCbpJgzZ2HonzQlPH5SZjmLvvy3KYBbtVw+1FjxoskJofXFz sTBOYvseIo880lpT6hYnvDBhDu6HGywhgkgNVGdJnTr9dw/GXOjLv3LjRxZfSSj+ySlR 89b4/PVMo47SJ24Xx4Aul2D9IV8hxrRDaPQABldN3uc2Y94YOkG8otLWuBzaedFr7CPJ j0OQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=NpetpB26; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-119911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119911-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j20-20020a17090ae61400b002a090b8a871si4605pjy.130.2024.03.26.13.34.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 13:34:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=NpetpB26; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-119911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119911-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D302E32815C for ; Tue, 26 Mar 2024 20:34:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7025413D53F; Tue, 26 Mar 2024 20:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="NpetpB26" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9274113D240 for ; Tue, 26 Mar 2024 20:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711484847; cv=none; b=ZEXX9hYmV1g+ZUjLTxnT7iOG/U0OVJhJyy6fSB6KpePi25qJKeHGazAqR4lPRIz1rhQQaoateFbfhj8vdsuCKddm9CoUePtuDByUTk3hfCmSaxhwfln+8BCoSUc9RvRzULmAWN8iaxVdHAGYihkd5KIB/Hf1igH4E2Y+PMnCbb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711484847; c=relaxed/simple; bh=RMc55HDt1Iu9wEhlfvQPgk2yHzSGgjRT7fuSwVCTZQ0=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=eUYml4XdazKjju/Pab9YLSJGYvujW0gJVTnYBO65ZnR29PVJsn15dO8f560/m512d/LMGWnA9Qmoef8MRB16+Xk3ammTjAxCpdTwniZQFLwE6kJ70R+iFOsUK3lKA6goXyOhIKDM8ru6uk9c5pfA9dDxPNUtCh4ihq0MdAIi8WQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=NpetpB26; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F54C433C7; Tue, 26 Mar 2024 20:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711484847; bh=RMc55HDt1Iu9wEhlfvQPgk2yHzSGgjRT7fuSwVCTZQ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NpetpB26CHhvYKzvBW/oKi5wtOnub6rL5aP+YF9Y6dCvsmN12zKb5dHIZ5CfCYKcn mhpXZyqvSxsBryWoD/L3dVJ01wZpPDe2ffb+0OvtOWbu8EvYvgn6fD5h7/2417uMPL RI0ydEygACM/q2kOjDEnIbOri4aJ/Y/b5mxPbfOs= Date: Tue, 26 Mar 2024 13:27:26 -0700 From: Andrew Morton To: peterx@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, SeongJae Park , Jason Gunthorpe , Mike Rapoport , Matthew Wilcox , kernel test robot Subject: Re: [PATCH] mm/arch: Provide pud_pfn() fallback Message-Id: <20240326132726.67e82559a928ac1636c8050c@linux-foundation.org> In-Reply-To: <20240323151643.1047281-1-peterx@redhat.com> References: <20240323151643.1047281-1-peterx@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 23 Mar 2024 11:16:43 -0400 peterx@redhat.com wrote: > From: Peter Xu > > The comment in the code explains the reasons. We took a different approach > comparing to pmd_pfn() by providing a fallback function. > > Another option is to provide some lower level config options (compare to > HUGETLB_PAGE or THP) to identify which layer an arch can support for such > huge mappings. However that can be an overkill. > > ... > > If we care about per-commit build errors (and if it is ever feasible to > reorder), we can move this patch to be before the patch "mm/gup: handle > huge pud for follow_pud_mask()" in mm-unstable to unbreak build on that > commit. I temporarily disabled that whole series a few days ago. Because of multiple build issues, iirc. Let's make that permanent. Please redo the whole series against mm-unstable and resend?