Received: by 2002:ab2:f03:0:b0:1ef:ffd0:ce49 with SMTP id i3csp39656lqf; Tue, 26 Mar 2024 13:37:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOgycj/AKZu/6FNGbguDHGzGo1NhcLYYOCtXjoumpOMGj0uSgN4HgFy+q2pGNRXp9OlmQBwQJSEF/27ug2MwIRni2CZhCqm0mRKiXS0w== X-Google-Smtp-Source: AGHT+IFTi3itFYXO6A2DORCfE8NToX04bVi84rlOYBAPJ30pRYUe5CuOVfCu3xt2MMfUwPJ1O9Hy X-Received: by 2002:a05:6214:c6c:b0:696:8ecf:5742 with SMTP id t12-20020a0562140c6c00b006968ecf5742mr3947863qvj.4.1711485478301; Tue, 26 Mar 2024 13:37:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711485478; cv=pass; d=google.com; s=arc-20160816; b=Io7qdkTwGUdLRuIX6yXPcNnawWJmlAo75604UIH1YqeX17BJkzM0cTb+H/hU3IMvPA l7jRjwKTIO8W9tVSloVfmPGIBhVXMXK1AZcsGBV1n12qMy8fr9L2vYGzNEAV/dtxD/T7 +1nbUX4+qbXngzmKgdI94TeWGcnRrhAXQESrZv/MgEk9dqKiMS+rt6/S5vqy1s6RyrvT Q+RDXIaVhjGsbQTbtVwsdRsU4eqb9ofm7dw/hyr8pfdprHjLGkdexk819/CL7I9nieC1 X1N4Of+6xemr+5t4MF/IMwyVyYkmu0Hb4E2Y1/GscITqpZ+AxV0ONvWvuPazYvu/d4q2 dmpw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=6VDCXcE5QdWHR9kG4pOhacMN9bewYQsjsFRjYTaqxso=; fh=/56ksoLrL1wFIwh1K6X9ANPJz8ir1aYlyMqEboaEoSk=; b=rLfUghB6x7FQ9KrMN78TFYtFVK9Aycw5ExQAa8jKb5deN3dA8tOcykiRdJKVukicpe 6es3PCOPPEWLkckwwWvSo4Rr9AQzo1ptels5HkXN40qMeNdpQ6Y9etyo+hslQjNHnKRV dniKx63dIYxwAKG3M96nx4vJ8sIAA9OUMbfcRHrmocQ3+XHpL6G9PUeM4CTrKuDRMSwO Ftd9Spq8n4QKCnoOcB/fL4l3/9WrUFIyY3l/P/9oiNT2TwbSlMiFvHsf8zS/1/jcQAbo Xk3NFQzpkGICwT8KZqQrmzwHvOSgoimJYIrkBB/xxlIjJl7ElbC7ZrmSQdE4X3tZmOzV U/Tw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BmqphAjS; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-119926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id fq3-20020a056214258300b00696831463b4si6986505qvb.187.2024.03.26.13.37.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 13:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BmqphAjS; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-119926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CCD6D1C2EFDA for ; Tue, 26 Mar 2024 20:37:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE87A13D89F; Tue, 26 Mar 2024 20:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BmqphAjS" Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DEF13D883 for ; Tue, 26 Mar 2024 20:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711485141; cv=none; b=EID6Nq9Jiz/T4DWLvZal4Bf9A512W3NIk1eatbbGQZL4v51JSL+duomLuMAeG5gQfTCPjXVIfvbt8uQx797KWqydahDlbERjRWacXCIiLapaZTH2/xR4cZ27wX4EmBUlV7R6V1azpME2Z27YyqnzN4X9ldO4hPJ4In3WnpWlTiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711485141; c=relaxed/simple; bh=VgCPJU44QLSg2GKIOQSZ5MrtRTt0B2rcrRTt5IW/eKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=igCCIblogOTStl02tUZh9U6ZntTlnUDSnpfE4psAQ4TpoSIQ3NqX/dluiyKddZnMwuiG+NLCcZMqVyWpXHvluj6IhV+uNcq2UmnpSjd+T5ZnMG9fHboNb6ALqdwEuiS5Ifu3aAhc2sMFW1etrvM/bYkcuq1V6Cu+BSBZouMgJhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BmqphAjS; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-56c1922096cso2867928a12.0 for ; Tue, 26 Mar 2024 13:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711485137; x=1712089937; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6VDCXcE5QdWHR9kG4pOhacMN9bewYQsjsFRjYTaqxso=; b=BmqphAjSruJsmV55Jv1x5BFQzBs5AFEGs8aHf9dkyqCDtIjDBl3L1yqu8kz5bDjQvk U6C7YS8Ml1r9tGSKAPSM6aQy05CwAXkSyX8THki0j8pAhqYFA1VO2tNbxsahjSnAmIhJ NAG24yJ3/Ci7vUlpWIVkQrXzJ2W3j8lMTf6kQCDf/JvwfYKP3hYkeVurQNTFnKY9x6FK MLfAYwccPk3QUw5MsQ7L9PydTVBUn0MWuYHLLuZ7pSrDMj612gHmY9lqY9lmqWioG0nm IZu2ujkSQ4fuhCz97/jK+XvCz4c8pAAJ0PI6aAVZ8d+DZFOuyR92cn7HlEbjougbIHiU xfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711485137; x=1712089937; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6VDCXcE5QdWHR9kG4pOhacMN9bewYQsjsFRjYTaqxso=; b=tiu44HCMkpYEaSdwwlacx0tjKuPwjGjOfn8XfPkRL/7hv7D1lz0EqPaFyrTjWIWZQ3 8sbyv7xdWvqn7AZlI4K5ZTVX4M1EpoTezhFE8hVnYuhJ5fDS6Jt4DmKrXgIEWbI1ON8Q Uy4eoIrbqlE3lcp5YNGr/IzlG1Yoo8koZwkJWaODavuoOLAJkfwY0TaWF6uZrOiodX34 DoWCaFUGkHZmsLdBf9hissvotyTp7JHc4VtgG3tvhvFFN1h3ByLF20lw9NnGQ47NenbD IYFGKu0oWGoS6tu4qEMLayhu1xO5oobmxkRlVvovHSZ6zi72H3rDNFKwK85zHzc8UzAq 0XTA== X-Forwarded-Encrypted: i=1; AJvYcCXzCXR652iUtGO2iAxUJXhNoKah2OMXgO0aQLqg2UDefyu8mrSlCjryrpOdYfmFwChdqUD9O4OmrBJcbVkFOqWEHfz4FN2DRaiH/BJO X-Gm-Message-State: AOJu0YwFtmH3WyDwK9rp9W+0ZdbnsP/skWKyauUVsArJgH3f3z+P1YxA HLpNR/uk8OT9BJzIIpuc/kKTzWjfhXTd0j3sylJqqSLdrUhf53X9JNt5HCU9fR4= X-Received: by 2002:a17:906:4a0e:b0:a46:8c40:7a3a with SMTP id w14-20020a1709064a0e00b00a468c407a3amr1692821eju.26.1711485137449; Tue, 26 Mar 2024 13:32:17 -0700 (PDT) Received: from [192.168.92.47] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id lb25-20020a170907785900b00a3d11feb32esm4583167ejc.186.2024.03.26.13.32.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 13:32:17 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 21:32:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] interconnect: qcom: sm6115: Unspaghettify SNoC QoS port numbering To: Dmitry Baryshkov Cc: Bjorn Andersson , Georgi Djakov , Shawn Guo , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold References: <20240326-topic-rpm_icc_qos_cleanup-v1-0-357e736792be@linaro.org> <20240326-topic-rpm_icc_qos_cleanup-v1-1-357e736792be@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26.03.2024 9:13 PM, Dmitry Baryshkov wrote: > On Tue, 26 Mar 2024 at 21:43, Konrad Dybcio wrote: >> >> When I was creating this driver, my bright mind overlooked the existence >> of desc->qos_offset and decided to make up for the difference it made by >> adding 21 (0x15) to the port index on SNoC and its downstream buses. >> >> Undo this mistake to make the indices actually mean something. > > So, what is the meaning of qos_port? "The index of the [data?] port that we're applying the QoS settings to" Konrad