Received: by 2002:ab2:f03:0:b0:1ef:ffd0:ce49 with SMTP id i3csp45936lqf; Tue, 26 Mar 2024 13:53:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUC3Fyd6hJpKtxJOjAjlMy4+mbJaIOpOWhZru6zFhQSL4YW/K8k2x1VAaFkoMUO32nNC4zwDnGFWATLvrq4r3CBZ/19Sb+yKNTDvWgF2A== X-Google-Smtp-Source: AGHT+IHaN2J62Da+O1t6TTYEgUzSEf1q1zs1P9KgzcjScPnKNY/A2tirT6W3iEvD4/nunbdoXCoi X-Received: by 2002:a05:6512:2187:b0:513:572f:88f1 with SMTP id b7-20020a056512218700b00513572f88f1mr561774lft.27.1711486420110; Tue, 26 Mar 2024 13:53:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711486420; cv=pass; d=google.com; s=arc-20160816; b=UZLMDEkJsm9i4pHvHn+3Hw3/YdjERyBo1ApCEzyAuE5zj5MZa7FpSI+XU0ojvSxSBT 73TtPFrT8BZCe30snxpHDqYO7Xe9nfcv1+ZCFwSw/EeDS4dHQ9csWInot0i60QgbLG6m S4xTOGFliFSi+vsrTWyfpQxQnV8ZNQtXvPSnlh4lRXlQMxCiU/yFJNnhr9mZA+oDB869 XhVrmIhpo4Rs/ObQhxeXPjE2t0C5dIMhZN/hfFrTD9Gg2+O42671ZRbwGLRZ3HtuIeQB xDHiEOhNRsnIe0/wxZQ1DMXF2ECQFWF7um/B0ifzJR6tzwooTQcVa/JE/tUXbOpFOCQ6 mmPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=cFD+9YnsTm4KSytJU+1RD9J6zHRpakIFy2iHC5xgpLM=; fh=6s6ytHZ5fbt/0Rci8Av9znUGQKGUoC1ubYUNrsX7sjY=; b=z4jHuBBz3BIRvoL/N75g15VIXC925N79oIWQdQ4GbXEfOR9XRWTYB3Au3R/5Ro0fGw Qzb1b+NvhZQnFS36tvGVaDFayrR4g/ZD2Tqccv7WdRf8t1UP11UZZ00V6JFUIFDU+6mG h8I6baYqz6QAVBFdgO9Q+42WzYB2kwRBvVvtdCmTYDXbfFTNY178G0UtV96jmYFVUpjn 8sci1lOE1omPwo4NHm/Y5LYpbKnesTYhukwsrEXopvcLFgIz3G4XVl16A14D/Pt1Y5K4 4260wW0fn1XFAqehgKIVuuz+73Ldwf9xPUmwgqukXUiOyMQgdepqTO4sLqeVKEKiOHTo 6CsA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-119941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119941-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e22-20020a17090681d600b00a45ed887cc1si3794064ejx.1008.2024.03.26.13.53.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 13:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-119941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119941-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3070D1F393B8 for ; Tue, 26 Mar 2024 20:41:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9102313F423; Tue, 26 Mar 2024 20:36:14 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F0B013E04F; Tue, 26 Mar 2024 20:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711485374; cv=none; b=f85bKCP1lRI6t9JX6wNWv1Cud80wMKJtiJnujFy46B0NPXRWc1wxw3B16TT/9Iwbjr55cjRfr0PhvSTCiJSYXXjd+fPIdTjk4Je2K3TZ67ElJ9t2q3//huX4FEmxF4jqKMSDjRw+atSsKY1Tjdj2iupsfWFncGl893081LXoN64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711485374; c=relaxed/simple; bh=vxP2g7nMxgBwL/7W9b8XPK++/O/kUS8yVNPzMMrQVvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aU8mIyK6IM3kKys0vt+kWs9AzaKE4joHBOtoISf3Bf7Uc3bcEkceRV2TUDWtkHKG2tCZ32Bi2PXv1s+W0ppKfPCbjPxN4W+dR4E9bPBmOMldNTYm/4G5sp//Jbl+Z3chJHoiJ6pCryGOg2ZcwNV9xKcX0SLPZhvXzzdf8tlNxII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E73B2F4; Tue, 26 Mar 2024 13:36:45 -0700 (PDT) Received: from [10.57.71.219] (unknown [10.57.71.219]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC1C93F64C; Tue, 26 Mar 2024 13:36:09 -0700 (PDT) Message-ID: <96b5c2a1-b259-47ea-ba61-384526c5a3b4@arm.com> Date: Tue, 26 Mar 2024 20:36:08 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND][PATCH v2 2/4] PM: EM: Change the em_adjust_new_capacity() to re-use code Content-Language: en-US To: Dietmar Eggemann Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240322110850.77086-1-lukasz.luba@arm.com> <20240322110850.77086-3-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/26/24 10:51, Dietmar Eggemann wrote: > On 22/03/2024 12:08, Lukasz Luba wrote: > > Maybe better : "PM: EM: Refactoring em_adjust_new_capacity()" ? > >> There is going to be a new update function addressing chip binning. >> Therefore, some common code which can be refactored and called from >> upcoming changes and em_adjust_new_capacity(). In this way the code >> duplication can be avoided. > > IMHO, that's hard to digest. > > Extract em_table_dup() and em_recalc_and_update() from > em_adjust_new_capacity(). Both functions will be later reused by the > 'update EM due to chip binning' functionality. That looks good, I'll update it. > > [...] > >> +static int em_recalc_and_update(struct device *dev, struct em_perf_domain *pd, >> + struct em_perf_table __rcu *em_table) >> +{ >> + int ret; >> + >> + ret = em_compute_costs(dev, em_table->state, NULL, pd->nr_perf_states, >> pd->flags); >> - if (ret) { >> - dev_warn(dev, "EM: compute costs failed\n"); >> - return; >> - } >> + if (ret) >> + goto free_em_table; > > There seems to be a subtle change in this patch. When em_compute_costs() > fails now em_table_free() is called. This wasn't the case before when > em_compute_costs() was directly called from em_adjust_new_capacity(). Yes, I've refactored it to explicitly call to the same free_em_table for both fails in the new code. It should have been done in old code. > > [...]