Received-SPF: pass (google.com: domain of linux-kernel+bounces-119983-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Mar 2024 14:08:46 -0700 (PDT)
Subject:     Re: [PATCH] riscv: compat_vdso: install compat_vdso.so.dbg to /lib/modules/*/vdso/
In-Reply-To: <1a1bf141-9fbf-4d30-bdd3-fd20f6170c3f@ghiti.fr>
CC: masahiroy@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
  aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
From: Palmer Dabbelt <palmer@dabbelt.com>
To: alex@ghiti.fr
Message-ID: <mhng-db45f75f-4c54-4ade-9c88-cfd6015a9203@palmer-ri-x1c9a>
Precedence: bulk
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On Mon, 18 Mar 2024 13:53:42 PDT (-0700), alex@ghiti.fr wrote:
> Hi Masahiro,
>
> On 15/03/2024 05:06, Masahiro Yamada wrote:
>> On Thu, Mar 7, 2024 at 5:12 AM Alexandre Ghiti <alex@ghiti.fr> wrote:
>>> Hi Masahiro,
>>>
>>> On 24/02/2024 04:37, Masahiro Yamada wrote:
>>>> Ping x 2 ?
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Jan 21, 2024 at 6:48 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>> On Fri, Nov 17, 2023 at 9:58 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>>> 'make vdso_install' installs debug vdso files to /lib/modules/*/vdso/.
>>>>>>
>>>>>> Only for the compat vdso on riscv, the installation destination differs;
>>>>>> compat_vdso.so.dbg is installed to /lib/module/*/compat_vdso/.
>>>>>>
>>>>>> To follow the standard install destination and simplify the vdso_install
>>>>>> logic, change the install destination to standard /lib/modules/*/vdso/.
>>>>>>
>>>>>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>>>>>> ---
>>>>> Ping?
>>>>> (in case "yet more RISC-V updates" happens)
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>    arch/riscv/Makefile | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>>>>>> index a74be78678eb..5cbe596345c1 100644
>>>>>> --- a/arch/riscv/Makefile
>>>>>> +++ b/arch/riscv/Makefile
>>>>>> @@ -146,7 +146,7 @@ endif
>>>>>>    endif
>>>>>>
>>>>>>    vdso-install-y                 += arch/riscv/kernel/vdso/vdso.so.dbg
>>>>>> -vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg:../compat_vdso/compat_vdso.so
>>>>>> +vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>>>>>>
>>>>>>    ifneq ($(CONFIG_XIP_KERNEL),y)
>>>>>>    ifeq ($(CONFIG_RISCV_M_MODE)$(CONFIG_ARCH_CANAAN),yy)
>>>>>> --
>>>>>> 2.40.1
>>>>>>
>>>>> --
>>>>> Best Regards
>>>>> Masahiro Yamada
>>>>
>>>> --
>>>> Best Regards
>>>> Masahiro Yamada
>>>>
>>>> _______________________________________________
>>>> linux-riscv mailing list
>>>> linux-riscv@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>>
>>> Couldn't changing this library install path break some existing
>>> application? I mean it kind of breaks where the library is expected to
>>> be right?
>>
>> Do you have a particular library in mind?
>
>
> None in particular.
>
>
>>
>>
>> RISV-V is the only architecture that installs a debug vdso
>> to a different location than the
>> standard lib/modules/*/vdso/.
>>
>>
>> I regard this as a fix.
>
>
> You're probably right, I don't see why the search path would be
> different on riscv, unless it was fixed in userspace but I think this is
> the right thing to do, so:

We do have some weirdness with multlib paths, but I don't think that's 
related to the VDSO paths.

>
> Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
>
> Thanks,
>
> Alex
>
>
>>
>>
>>
>>
>>