Received-SPF: pass (google.com: domain of linux-kernel+bounces-119997-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240326-zswap-xarray-v9-1-d2891a65dfc7@kernel.org>
 <CANeU7Q=8p4whMu+H9GXqQc4Ehjt0_kCtNdg34TiW4bWFw03dbw@mail.gmail.com> <CAKEwX=MLFaA-1kYbKT0bMuTsJDqK9ZfoJ+WUyxM4tBu_owyPYA@mail.gmail.com>
In-Reply-To: <CAKEwX=MLFaA-1kYbKT0bMuTsJDqK9ZfoJ+WUyxM4tBu_owyPYA@mail.gmail.com>
From: Chris Li <chrisl@kernel.org>
Date: Tue, 26 Mar 2024 14:20:58 -0700
Message-ID: <CANeU7Qmr-cirRJxm7JyfoFH+d782tHCvuC6wtEBzF4bpd5aeyg@mail.gmail.com>
Subject: Re: [PATCH v9] zswap: replace RB tree with xarray
To: Nhat Pham <nphamcs@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, Yosry Ahmed <yosryahmed@google.com>, 
	Johannes Weiner <hannes@cmpxchg.org>, "Matthew Wilcox (Oracle)" <willy@infradead.org>, 
	Chengming Zhou <zhouchengming@bytedance.com>, Barry Song <v-songbaohua@oppo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Yosry, Johannes and Nhat,

Thank you for your review. I have sent out V10 to revert the comment.

Chris

On Tue, Mar 26, 2024 at 2:04=E2=80=AFPM Nhat Pham <nphamcs@gmail.com> wrote=
:
>
> On Tue, Mar 26, 2024 at 11:42=E2=80=AFAM Chris Li <chrisl@kernel.org> wro=
te:
> >
> > > -        * When reading into the swapcache, invalidate our entry. The
> > > +        * When reading into the swapcache, erase our entry. The
> > >          * swapcache can be the authoritative owner of the page and
> > >          * its mappings, and the pressure that results from having tw=
o
> > >          * in-memory copies outweighs any benefits of caching the
> > > @@ -1649,8 +1581,12 @@ bool zswap_load(struct folio *folio)
> > >          * the fault fails. We remain the primary owner of the entry.=
)
> > >          */
> > >         if (swapcache)
> > > -               zswap_rb_erase(&tree->rbroot, entry);
> > > -       spin_unlock(&tree->lock);
> > > +               entry =3D xa_erase(tree, offset);
> > > +       else
> > > +               entry =3D xa_load(tree, offset);
> >
> > This is the place I make the modification for the conflict resolution.
> > It depends on the swapcache to execute xa_erase() or xa_load().
> > Obviously, the xa_load() will not delete the entry from the tree.
> >
>
> The conflict resolution itself LGTM. I'll let you and Johannes decide
> on the comment (but FWIW, the original meaning still holds, so I don't
> see why we need to fix it).
>
> Reviewed-by: Nhat Pham <nphamcs@gmail.com>
>