Received-SPF: pass (google.com: domain of linux-kernel+bounces-120002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.87 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.87; helo=repost-eu.tmcas.trendmicro.com; pr=C
Message-ID: <df50fd2e-bac4-4e58-98ba-4a7c3de538d5@seco.com>
Date: Tue, 26 Mar 2024 17:25:30 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4.19 134/148] usb: phy: generic: Get the vbus supply
Content-Language: en-US
To: Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
Cc: stable <stable@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20240324235012.1356413-1-sashal@kernel.org>
 <20240324235012.1356413-135-sashal@kernel.org>
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20240324235012.1356413-135-sashal@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 CCDzocujdAogocGXrNF70+e0vCw3+oo0MjkJL2Anhv+DXp/BBOMbk+QbiRw7f/F1PUcmeqIG+7RSkO2khHg9/CvZyZl6QbWmYiPsXxg/5PKrmm+jt30ATGxYLUu8g4oSM5rMJ/vM1NOvYZGETPv+0QcpqyFK4UICkguDVZ85Lh1I/xHqZ8EeRTiocHCFm73C7UvyAeduEJUdev4gl2xn//4hhkYCwn/IlPRYCIOo1GlTa7tSjW1y0pR3YEiktgDEGQdA4Wk74KR1npx9k9i6y6giS0WxrC3d0/lacjs46giE1DFktw3OYSPW3eJlGf4/2hsz2jraby/bOih7HAdyNZ22K60131WK+nrXbcEqgWDRnXFSav0ztdgqLbU+E3NkHcGjPwv+Tr1JoIfGA1FP8zGmE5KpB4CA7tHoolykU6opI1agUQoYPXuW5QjJFDjqmsdeol7/Gl4SjNQ09qaFW5iFJqKZYreUCycnxRHi9BvWMbcDb7k6dX50at+dErw6SzJ2NZBbAn2cO5SUjf3OK/V0HYXjisnGpJCbzqmY+p0KNfBZxPsU/L97Blqwg7B62bEHdFhag04RkV8xj/J9SQv/+cd1+9pzwPMht9s9HtOtw+jGRACFtZi42Ph8kV+CkLgaMbwYbV0FNFh5w7Deint93sqyFNJEPlIM6ilb4B4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7637
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DU6PEPF0000A7DF.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f17d371a-599f-41b8-3e40-08dc4ddb4bad
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wOpClJtWAYmCOWRNUHmmjih3mDT5hEc4qfqFxl0KrcTZ2HbVs1GeFhyQzJ6G7nywtQB5Yei2fmE0TIhmO7guXGYA213BVDuluv5yO5bacOpbcwcIYGvuCxvt9qrb1Azr8hlsoi64Jg53ENnJNDCmtLczKMmjsU99hhI0FJ2227B9zxM+KyQmDgBrnrCpkMiCn3Ri5Alx3RDYRMiPqnRv5X31xrwt9ChhAmMgKO0kyUL5e74e9iPXPzBLxaGje+7TOpX+BhtSM/6bmjGFsFsXgkBUIz8XxBeEeBGXT/rZOata9GcpoIlHNmkfXBubhILlzahc2scEobhU4szPSflSNkpagIAOGI/dG0WLDpjyVb7/e14oCPweN9DaAA1h0J/8VQkWGJcyRk6onLpi01sCFOtnvCzETs9KJ2PtshkaP4f8Utg0GugULg3q8MnxNCMWdEgcc6NjJbXVwjMDBchrPj9LM0Cc31zXW6o+FFxwHFtL0fxlLc4YZfPycCUIvxHrRLhi98xK9/n/BkHLh8EJdPza/gDPwqz4HEPadjlGGZlbaD8DCnmhvSSsxnpfOuGT53pTpV7nYXB2dRy4qkMuRaIKD6y6v1tWEiESfRvY8Ju0V/OVcewyY0MnCz86zrZE5cUKEgyLvD4NQpoq6rkjM9KuSYxeYJFMwdTANTm+EVHHwXWMwAub8DxPNFXxa7mGfTkAiKUpNcb7IrHMDD4SFA==
X-Forefront-Antispam-Report:
	CIP:20.160.56.87;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 21:25:44.1807
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f17d371a-599f-41b8-3e40-08dc4ddb4bad
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.87];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DU6PEPF0000A7DF.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6531

On 3/24/24 19:49, Sasha Levin wrote:
> From: Sean Anderson <sean.anderson@seco.com>
>
> [ Upstream commit 03e607cbb2931374db1825f371e9c7f28526d3f4 ]
>
> While support for working with a vbus was added, the regulator was never
> actually gotten (despite what was documented). Fix this by actually
> getting the supply from the device tree.
>
> Fixes: 7acc9973e3c4 ("usb: phy: generic: add vbus support")
> Cc: stable <stable@kernel.org>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Link: https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query=
?url=3Dhttps%3a%2f%2flore.kernel.org%2fr%2f20220425171412.1188485%2d3%2dsea=
n.anderson%40seco.com&umid=3Dd6ce00f6-eb02-4c45-a2bb-d42fb98e3d79&auth=3Dd8=
07158c60b7d2502abde8a2fc01f40662980862-664a4cc6c56716c0ff040724728033a1bce8=
7ec7
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/usb/phy/phy-generic.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.=
c
> index a53b89be53248..8a04b157f19f3 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -283,6 +283,13 @@ int usb_phy_gen_create_phy(struct device *dev, struc=
t usb_phy_generic *nop,
>                       return -EPROBE_DEFER;
>       }
>
> +     nop->vbus_draw =3D devm_regulator_get_exclusive(dev, "vbus");
> +     if (PTR_ERR(nop->vbus_draw) =3D=3D -ENODEV)
> +             nop->vbus_draw =3D NULL;
> +     if (IS_ERR(nop->vbus_draw))
> +             return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
> +                                  "could not get vbus regulator\n");
> +
>       nop->dev                =3D dev;
>       nop->phy.dev            =3D nop->dev;
>       nop->phy.label          =3D "nop-xceiv";

TBH I would rather not backport this if possible. This will increase the
chance of someone using this behavior which is going to change in
562898808cb1 ("usb: phy: generic: Implement otg->set_vbus").

--Sean

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>