Received-SPF: pass (google.com: domain of linux-kernel+bounces-120137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Mar 2024 00:31:12 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: nikita.shubin@maquefel.me
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, 
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 05/38] power: reset: Add a driver for the ep93xx reset
Message-ID: <oxvj7wmugkxzeddmrzyowr6lxxahbo766sbip22a564qeczxoy@oagxcoathnsr>
References: <20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me>
 <20240326-ep93xx-v9-5-156e2ae5dfc8@maquefel.me>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bxlmjncesy7eix7u"
Content-Disposition: inline
In-Reply-To: <20240326-ep93xx-v9-5-156e2ae5dfc8@maquefel.me>


--bxlmjncesy7eix7u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 26, 2024 at 12:18:32PM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
>=20
> Implement the reset behaviour of the various EP93xx SoCS
> in drivers/power/reset.
>=20
> It used to be located in arch/arm/mach-ep93xx.
>=20
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> Acked-by: Sebastian Reichel <sre@kernel.org>
> ---

If another round is needed, please use devm_register_sys_off_handler()
instead of register_restart_handler().

Greetings,

-- Sebastian

>  drivers/power/reset/Kconfig          | 10 +++++
>  drivers/power/reset/Makefile         |  1 +
>  drivers/power/reset/ep93xx-restart.c | 84 ++++++++++++++++++++++++++++++=
++++++
>  3 files changed, 95 insertions(+)
>=20
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index fece990af4a7..389d5a193e5d 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -75,6 +75,16 @@ config POWER_RESET_BRCMSTB
>  	  Say Y here if you have a Broadcom STB board and you wish
>  	  to have restart support.
> =20
> +config POWER_RESET_EP93XX
> +	bool "Cirrus EP93XX reset driver" if COMPILE_TEST
> +	depends on MFD_SYSCON
> +	default ARCH_EP93XX
> +	help
> +	  This driver provides restart support for Cirrus EP93XX SoC.
> +
> +	  Say Y here if you have a Cirrus EP93XX SoC and you wish
> +	  to have restart support.
> +
>  config POWER_RESET_GEMINI_POWEROFF
>  	bool "Cortina Gemini power-off driver"
>  	depends on ARCH_GEMINI || COMPILE_TEST
> diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
> index a95d1bd275d1..10782d32e1da 100644
> --- a/drivers/power/reset/Makefile
> +++ b/drivers/power/reset/Makefile
> @@ -7,6 +7,7 @@ obj-$(CONFIG_POWER_RESET_ATC260X) +=3D atc260x-poweroff.o
>  obj-$(CONFIG_POWER_RESET_AXXIA) +=3D axxia-reset.o
>  obj-$(CONFIG_POWER_RESET_BRCMKONA) +=3D brcm-kona-reset.o
>  obj-$(CONFIG_POWER_RESET_BRCMSTB) +=3D brcmstb-reboot.o
> +obj-$(CONFIG_POWER_RESET_EP93XX) +=3D ep93xx-restart.o
>  obj-$(CONFIG_POWER_RESET_GEMINI_POWEROFF) +=3D gemini-poweroff.o
>  obj-$(CONFIG_POWER_RESET_GPIO) +=3D gpio-poweroff.o
>  obj-$(CONFIG_POWER_RESET_GPIO_RESTART) +=3D gpio-restart.o
> diff --git a/drivers/power/reset/ep93xx-restart.c b/drivers/power/reset/e=
p93xx-restart.c
> new file mode 100644
> index 000000000000..57cfb8620faf
> --- /dev/null
> +++ b/drivers/power/reset/ep93xx-restart.c
> @@ -0,0 +1,84 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Cirrus EP93xx SoC reset driver
> + *
> + * Copyright (C) 2021 Nikita Shubin <nikita.shubin@maquefel.me>
> + */
> +
> +#include <linux/bits.h>
> +#include <linux/container_of.h>
> +#include <linux/delay.h>
> +#include <linux/errno.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/notifier.h>
> +#include <linux/reboot.h>
> +#include <linux/slab.h>
> +
> +#include <linux/soc/cirrus/ep93xx.h>
> +
> +#define EP93XX_SYSCON_DEVCFG		0x80
> +#define EP93XX_SYSCON_DEVCFG_SWRST	BIT(31)
> +
> +struct ep93xx_restart {
> +	struct ep93xx_regmap_adev *aux_dev;
> +	struct notifier_block restart_handler;
> +};
> +
> +static int ep93xx_restart_handle(struct notifier_block *this,
> +				 unsigned long mode, void *cmd)
> +{
> +	struct ep93xx_restart *priv =3D
> +		container_of(this, struct ep93xx_restart, restart_handler);
> +	struct ep93xx_regmap_adev *aux =3D priv->aux_dev;
> +
> +	/* Issue the reboot */
> +	aux->update_bits(aux->map, aux->lock, EP93XX_SYSCON_DEVCFG,
> +			 EP93XX_SYSCON_DEVCFG_SWRST, EP93XX_SYSCON_DEVCFG_SWRST);
> +	aux->update_bits(aux->map, aux->lock, EP93XX_SYSCON_DEVCFG,
> +			 EP93XX_SYSCON_DEVCFG_SWRST, 0);
> +
> +	return NOTIFY_DONE;
> +}
> +
> +static int ep93xx_reboot_probe(struct auxiliary_device *adev,
> +			       const struct auxiliary_device_id *id)
> +{
> +	struct ep93xx_regmap_adev *rdev =3D to_ep93xx_regmap_adev(adev);
> +	struct device *dev =3D &adev->dev;
> +	struct ep93xx_restart *priv;
> +	int err;
> +
> +	if (!rdev->update_bits)
> +		return -ENODEV;
> +
> +	priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	priv->aux_dev =3D rdev;
> +
> +	priv->restart_handler.notifier_call =3D ep93xx_restart_handle;
> +	priv->restart_handler.priority =3D 128;
> +
> +	err =3D register_restart_handler(&priv->restart_handler);
> +	if (err)
> +		return dev_err_probe(dev, err, "can't register restart notifier\n");
> +
> +	return 0;
> +}
> +
> +static const struct auxiliary_device_id ep93xx_reboot_ids[] =3D {
> +	{
> +		.name =3D "soc_ep93xx.reset-ep93xx",
> +	},
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(auxiliary, ep93xx_reboot_ids);
> +
> +static struct auxiliary_driver ep93xx_reboot_driver =3D {
> +	.probe		=3D ep93xx_reboot_probe,
> +	.id_table	=3D ep93xx_reboot_ids,
> +};
> +module_auxiliary_driver(ep93xx_reboot_driver);
>=20
> --=20
> 2.41.0
>=20
>=20

--bxlmjncesy7eix7u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYDWrwACgkQ2O7X88g7
+ppn2A/7BgKXlLfayzxDGsLA+7oVEcxwjQwTAffSwpyYzOUL4p+nfQLNMPUJ5G+o
bchGTHW9eGaWN8sL/bXyTtJZSIPisxtd0qKwGKLJH+kPY4ZFK7UAm+kxzeygXRbk
JhHksfeuhefcbpZRGWOJaXamMRLWa5o2Mj+O/5+fK/p2bJuQUCyBuRNbvdnFfUmu
E4cOcgnT4OlBH4REKwiQCtXIFmdv+BIJoFSW2qpqH4efjd9H14eZ75DSzFdANaQc
2WqfGBccwOx1oYlkkocxlzMPwlEaKLpj3XtpyGwCD2uIhGSFRapud+i4h5hDB0fE
0nYi4/orD91lWJpxg5awMlw7BiKyDnwH2OBFuWXmF+FVerLO49f4/OO9T89PbXzz
ECQNWg35sMqA7Y8p2YhkeDH5Fa8CFtbFyAivuBM4pbFTwJrsW8+iaSI5dVW/ATVx
CvzSPogVyiwzawupz00TMvlVPOgF3dxYA+hgh0GVRT2Wdo8YCWj2WGl9pUKW1/XZ
nROizDuPIAYxrheZnCbSQuiBnWDzlypMzXLX/pP0w/yS1cUEa4teAdVE+ZJbqn2y
yPaZ5KCJTNk30JoGMaSXAe1NbeFisVhtDCIb3W5/vTLTMRmnrk4JT5FuacWLDQZM
/Cq5IfTTg4ougV87UZcz/Cn37z2733DRNZgjrmSQULhVRh8QkLM=
=Q8qH
-----END PGP SIGNATURE-----

--bxlmjncesy7eix7u--