Received-SPF: pass (google.com: domain of linux-kernel+bounces-120166-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <0000000000006f876b061478e878@google.com> <a402206e-a9c9-40bd-bf78-710054506071@linux.dev>
In-Reply-To: <a402206e-a9c9-40bd-bf78-710054506071@linux.dev>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Tue, 26 Mar 2024 18:07:34 -0700
Message-ID: <CAADnVQLXyQ_o5hSA0OpHYj231WKPFNRNMyr0NePMr2ypusiLmg@mail.gmail.com>
Subject: Re: [syzbot] [bpf?] [net?] KMSAN: uninit-value in dev_map_lookup_elem
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: Alexei Starovoitov <ast@kernel.org>, Andrii Nakryiko <andrii@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Yonghong Song <yonghong.song@linux.dev>, 
	syzbot <syzbot+1a3cf6f08d68868f9db3@syzkaller.appspotmail.com>, 
	bpf <bpf@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Eddy Z <eddyz87@gmail.com>, 
	Hao Luo <haoluo@google.com>, Jesper Dangaard Brouer <hawk@kernel.org>, 
	John Fastabend <john.fastabend@gmail.com>, Jiri Olsa <jolsa@kernel.org>, 
	KP Singh <kpsingh@kernel.org>, Jakub Kicinski <kuba@kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, Network Development <netdev@vger.kernel.org>, 
	Stanislav Fomichev <sdf@google.com>, Song Liu <song@kernel.org>, 
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 5:54=E2=80=AFPM Martin KaFai Lau <martin.lau@linux.=
dev> wrote:
>
> On 3/25/24 2:36 AM, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit:    5e74df2f8f15 Merge tag 'x86-urgent-2024-03-24' of git:/=
/gi..
> > git tree:       upstream
> > console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D148872a5180=
000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=3De6bd769cb79=
3b98a
> > dashboard link: https://syzkaller.appspot.com/bug?extid=3D1a3cf6f08d688=
68f9db3
> > compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for D=
ebian) 2.40
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D15921a6e1=
80000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D12e081f1180=
000
> >
> > Downloadable assets:
> > disk image: https://storage.googleapis.com/syzbot-assets/1a82880723a7/d=
isk-5e74df2f.raw.xz
> > vmlinux: https://storage.googleapis.com/syzbot-assets/fd3046ac43b9/vmli=
nux-5e74df2f.xz
> > kernel image: https://storage.googleapis.com/syzbot-assets/2097be59cbc1=
/bzImage-5e74df2f.xz
> >
> > IMPORTANT: if you fix the issue, please add the following tag to the co=
mmit:
> > Reported-by: syzbot+1a3cf6f08d68868f9db3@syzkaller.appspotmail.com
> >
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > BUG: KMSAN: uninit-value in __dev_map_lookup_elem kernel/bpf/devmap.c:4=
41 [inline]
> > BUG: KMSAN: uninit-value in dev_map_lookup_elem+0xf3/0x170 kernel/bpf/d=
evmap.c:796
> >   __dev_map_lookup_elem kernel/bpf/devmap.c:441 [inline]
> >   dev_map_lookup_elem+0xf3/0x170 kernel/bpf/devmap.c:796
> >   ____bpf_map_lookup_elem kernel/bpf/helpers.c:42 [inline]
> >   bpf_map_lookup_elem+0x5c/0x80 kernel/bpf/helpers.c:38
> >   ___bpf_prog_run+0x13fe/0xe0f0 kernel/bpf/core.c:1997
> >   __bpf_prog_run256+0xb5/0xe0 kernel/bpf/core.c:2237
>
> It should be in the interpreter mode.
>
> The C reproducer is trying to run the following bpf prog:
>
>     0: (18) r0 =3D 0x0
>     2: (18) r1 =3D map[id:49]
>     4: (b7) r8 =3D 16777216
>     5: (7b) *(u64 *)(r10 -8) =3D r8
>     6: (bf) r2 =3D r10
>     7: (07) r2 +=3D -229
>             ^^^^^^^^^^
>
>     8: (b7) r3 =3D 8
>     9: (b7) r4 =3D 0
>    10: (85) call dev_map_lookup_elem#1543472
>    11: (95) exit
>
> I think this KMSAN report (and a few others related to lookup/delete_elem=
)
> should only happen in the interpreter mode.
>
> Does it worth to suppress it by always initializing the stack in the inte=
rpreter
> mode considering the interpreter is not very speed sensitive ?

Maybe we can mark it as initialized from kmsan pov ?
There are kasan_poison/unpoison helpers that may fit ?