Received-SPF: pass (google.com: domain of linux-kernel+bounces-120172-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <1711346195-24555-1-git-send-email-zhiguo.niu@unisoc.com> <8a6b2768-8ab6-4275-8c4e-05b4eca83987@kernel.org>
In-Reply-To: <8a6b2768-8ab6-4275-8c4e-05b4eca83987@kernel.org>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Wed, 27 Mar 2024 09:26:58 +0800
Message-ID: <CAHJ8P3J3xK2uz7egvShyCeAjGFJ87AvqKxVN=NFiKDgMLMJDPg@mail.gmail.com>
Subject: Re: [PATCH V2] f2fs: fix to adjust appropirate defragment pg_end
To: Chao Yu <chao@kernel.org>
Cc: Zhiguo Niu <zhiguo.niu@unisoc.com>, jaegeuk@kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, 
	ke.wang@unisoc.com, hongyu.jin@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 7:11=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/3/25 13:56, Zhiguo Niu wrote:
> > A length that exceeds the real size of the inode may be
> > specified from user, although these out-of-range areas
> > are not mapped, but they still need to be check in
> > while loop, which is unnecessary.
> >
> > Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > ---
> > v2: check i_size within inode lock according to Chao's suggestions
> > ---
> > ---
> >   fs/f2fs/file.c | 11 +++++++----
> >   1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 128e53d..cf63db7 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -2608,9 +2608,6 @@ static int f2fs_defragment_range(struct f2fs_sb_i=
nfo *sbi,
> >       bool fragmented =3D false;
> >       int err;
> >
> > -     pg_start =3D range->start >> PAGE_SHIFT;
> > -     pg_end =3D (range->start + range->len) >> PAGE_SHIFT;
> > -
> >       f2fs_balance_fs(sbi, true);
> >
> >       inode_lock(inode);
> > @@ -2629,10 +2626,16 @@ static int f2fs_defragment_range(struct f2fs_sb=
_info *sbi,
>
> pg_start =3D range->start >> PAGE_SHIFT;
> pg_end =3D min_t(pgoff_t, (range->start + range->len) >> PAGE_SHIFT,
>                         DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE));
>
> >
> >       /* writeback all dirty pages in the range */
> >       err =3D filemap_write_and_wait_range(inode->i_mapping, range->sta=
rt,
> > -                                             range->start + range->len=
 - 1);
> > +                                             min_t(loff_t, range->star=
t + range->len - 1,
> > +                                             i_size_read(inode) - 1));
>
> , pg_start << PAGE_SHIFT - 1, pg_end << PAGE_SHIFT - 1); ?
should be  pg_start << PAGE_SHIFT , pg_end << PAGE_SHIFT - 1)??
if range.start=3D0, pg_start is also 0, lstart in
filemap_write_and_wait_range is 0,
but pg_start << PAGE_SHIFT - 1 will get lstart=3D-1?
thanks=EF=BC=81
>
> Thanks,
>
> >       if (err)
> >               goto out;
> >
> > +     pg_start =3D range->start >> PAGE_SHIFT;
> > +     pg_end =3D min_t(pgoff_t,
> > +                             (range->start + range->len) >> PAGE_SHIFT=
,
> > +                             DIV_ROUND_UP(i_size_read(inode), PAGE_SIZ=
E));
> > +
> >       /*
> >        * lookup mapping info in extent cache, skip defragmenting if phy=
sical
> >        * block addresses are continuous.