MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
       LKML <linux-kernel@vger.kernel.org>,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Use v8086_mode helper, trivial unification
In-Reply-To: Harvey Harrison's message of  Thursday, 17 January 2008 17:15:52 -0800 <1200618952.5724.85.camel@brick>
References: <1200611078.5724.46.camel@brick>
	<478FDE76.3070309@zytor.com>
	<1200612389.5724.63.camel@brick>
	<478FF9F3.9030604@zytor.com>
	<1200618952.5724.85.camel@brick>
Message-Id: <20080118013712.4090526FA0B@magilla.localdomain>
Date: Thu, 17 Jan 2008 17:37:12 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 23

It's indeed true that &pt_regs is truly the esp value for x86-32
kernel-mode trap frames.  Because this nonobvious calculation is 
only right for a kernel mode pt_regs and not for a user-mode one,
I think it would be better to use a name for the inline/macro that
makes this quite clear, rather than one so generic as "stack_addr".

> I think this comes out of Roland's patches unifying some names eip/rip,
> eax/rax, etc.
> 
> CC'd in case he felt like more work ;-)

That was hpa, not me.  Harmonizing the signedness of the struct members
does seem to me like a reasonable and deobfuscatory thing to do.
But I don't plan to get involved in doing it.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/