Received-SPF: pass (google.com: domain of linux-kernel+bounces-120182-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Mar 2024 18:46:02 -0700
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Jameson Thies <jthies@google.com>
CC: <heikki.krogerus@linux.intel.com>, <linux-usb@vger.kernel.org>,
        <pmalani@chromium.org>, <bleung@google.com>,
        <abhishekpandit@chromium.org>, <andersson@kernel.org>,
        <dmitry.baryshkov@linaro.org>, <fabrice.gasnier@foss.st.com>,
        <gregkh@linuxfoundation.org>, <hdegoede@redhat.com>,
        <neil.armstrong@linaro.org>, <rajaram.regupathy@intel.com>,
        <saranya.gopal@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] usb: typec: ucsi: Check capabilities before cable
 and identity discovery
Message-ID: <20240327014602.GB2136359@hu-bjorande-lv.qualcomm.com>
References: <20240315171836.343830-1-jthies@google.com>
 <20240315171836.343830-2-jthies@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240315171836.343830-2-jthies@google.com>

On Fri, Mar 15, 2024 at 05:18:35PM +0000, Jameson Thies wrote:
> Check the UCSI_CAP_GET_PD_MESSAGE bit before sending GET_PD_MESSAGE to
> discover partner and cable identity, check UCSI_CAP_CABLE_DETAILS before
> sending GET_CABLE_PROPERTY to discover the cable and check
> UCSI_CAP_ALT_MODE_DETAILS before registering the a cable plug. Additionally,
> move 8 bits from reserved_1 to features in the ucsi_capability struct. This
> makes the field 16 bits, still 8 short of the 24 bits allocated for it in
> UCSI v3.0, but it will not overflow because UCSI only defines 14 bits in
> bmOptionalFeatures.
> 
> Fixes: 38ca416597b0 ("usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY")
> Link: https://lore.kernel.org/linux-usb/44e8142f-d9b3-487b-83fe-39deadddb492@linaro.org
> Suggested-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Jameson Thies <jthies@google.com>

Thanks you, Jameson, this resolve the regression I ran into on
qcs6490-rb3gen2 as well.

Tested-by: Bjorn Andersson <quic_bjorande@quicinc.com> # QCS6490 Rb3Gen2

Regards,
Bjorn