Received-SPF: pass (google.com: domain of linux-kernel+bounces-120219-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <23e1665d-7500-4ecb-a208-59d1c5514e87@gmail.com>
Date: Wed, 27 Mar 2024 10:33:27 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] x86/dumpstack: uniform die messages prompt
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, alexs@kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org
References: <20240202074512.563274-1-alexs@kernel.org>
 <20240326104306.GBZgKmuqvLPzppFxyD@fat_crate.local>
From: Alex Shi <seakeel@gmail.com>
In-Reply-To: <20240326104306.GBZgKmuqvLPzppFxyD@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/26/24 6:43 PM, Borislav Petkov wrote:
> On Fri, Feb 02, 2024 at 03:45:12PM +0800, alexs@kernel.org wrote:
>> @@ -405,8 +407,8 @@ static void __die_header(const char *str, struct pt_regs *regs, long err)
>>  		pr = IS_ENABLED(CONFIG_PREEMPT_RT) ? " PREEMPT_RT" : " PREEMPT";
>>  
>>  	printk(KERN_DEFAULT
>> -	       "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, ++die_counter,
>> -	       pr,
>> +	       DIE_PROMPT "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff,
> 
> Why do you need this DIE_PROMPT if you can simply do:
> 
> 		"Oops: %s: %04lx... "
> 
> ?
> 
> And yes, I think I'd prefer having an "oops" in there as it is a lot
> more prominent. It is called a "kernel oops" everywhere.

Uh, 'Oops' is also a good preempt. If no other objection, I'd like to change this. :)

Thank a lot!

> 
> Thx.
>