Received-SPF: pass (google.com: domain of linux-kernel+bounces-120244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: ChunHau Tan <chunhau.tan@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
CC: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>, Vinod Koul
	<vkoul@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Leyfoon Tan <leyfoon.tan@starfivetech.com>, JeeHeng Sia
	<jeeheng.sia@starfivetech.com>, "dmaengine@vger.kernel.org"
	<dmaengine@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
 support
Thread-Topic: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
 support
Thread-Index: AQHaf2Ox5nUOkqHZ30+sw9x0qtoLj7FKWS6AgACLBgA=
Date: Wed, 27 Mar 2024 02:50:32 +0000
Message-ID:
 <BJSPR01MB059504FC203190B95D9D1C549E34A@BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn>
References: <20240326095457.201572-1-chunhau.tan@starfivetech.com>
 <20240326095457.201572-2-chunhau.tan@starfivetech.com>
 <20240326-maternity-alive-6cb8f6b2e037@spud>
In-Reply-To: <20240326-maternity-alive-6cb8f6b2e037@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?v9vvQh4F6sKtE236U5J4C/URcbsRsh2jzICVzD4WVs5dq7B+dVNbFSmWGym3?=
 =?us-ascii?Q?cZTk7mdjExESabYJ/ehybOidLklOwcumqJZNEoGIE/jDTu7LJpbPm/VBlxFM?=
 =?us-ascii?Q?QZzFHbrgGRxHHvp0GVK/OLOWJdTMUcmcTfLqfxyM5tcEnbnoY7u7lhSwYBvm?=
 =?us-ascii?Q?5evJufOKUIQLJKLIVOvjIZyTkegBtfzHOdCGKkURaFni+RPSYdpWP0/HCRQg?=
 =?us-ascii?Q?rvInUrOLSn3zLyVQramPRAsYuoHp6F+eLKYMwjAFaDXbe6txICugIGPdW66I?=
 =?us-ascii?Q?8d0CNAx2xdkrapFC6dfJ0xtSIHEf/Ae4yGH0WOX1pjUS0HeEriKmqn3dJ74V?=
 =?us-ascii?Q?9g67FDt9w1EXfx+rtfKaTq6T/RPGJpTqbpYR51Bn8CrfT/HkLLIrCTv/zeWh?=
 =?us-ascii?Q?4SpU0syri6zlrSKz5rYP/TtznfGSP6pHEWm4E8SUVgwMyIv8boi655c2SrTr?=
 =?us-ascii?Q?wiHU+jFA5+jdoDK33uVt0ui9ZBQnkK1wdyF82kKlnywtsyXpmArbZvK01pbk?=
 =?us-ascii?Q?q2YtJPpFd2kcMH6YIw+fwPZzPVKHCuCYKlqsV5nqTYiXSlSCVc2nKmDIJ5Km?=
 =?us-ascii?Q?hh9a5fNtcd2IcloEnqrL0D30KGhTWFYfbuQuFxk57v8mF1MSyJvplkXibsQl?=
 =?us-ascii?Q?mjf4D1YrgVA7LmMniTIcwH8z7oiHqCKRdNnXgL2PH2K948YKnYI5f+X/abis?=
 =?us-ascii?Q?xyskLAjQnYlxlAfjLH4udiUfqt9PNhTCsI8fagb0BWCS8Q/JThh1+7AONg0I?=
 =?us-ascii?Q?9SSlhYWbBx7bcmAb84/qutv+yehxK+Wdv6TmM9IZKDgKcr60GmGi4sSaV1Rn?=
 =?us-ascii?Q?WJ3nKlAhZBPfDjeZITW+9wVUTYN4OgVv3qlmOC69mthFk6SV/nIZSFmPxSla?=
 =?us-ascii?Q?mIB1HQzKks1oQhaUkki6I8phvUyzTHECKklbgeHOaWNkZjhIxDAFuZtNnVBB?=
 =?us-ascii?Q?9Tps//4OV4VgVMBC21sWBSVz7QWyet9eg4QtYRwqR8HvMhf+3wegPU3YLPW3?=
 =?us-ascii?Q?6oIgT+lqVJRANsvrFyxe8UgKr5D5cQcY8lWukHRjIhfN6jiDOWh4snzpsF1P?=
 =?us-ascii?Q?opX/FZhQqkh/JfHnjE/v4Rmc23yqvbF4eZGDpN0vgRl9zZg9A9D9KlT+vo++?=
 =?us-ascii?Q?9s/9WkptQMQCFZDbYHvcHMLsj9tuMmijpDPr7cM2DGXmilhhCNWrfOyDKLLk?=
 =?us-ascii?Q?FlKIHBq8EZ6h3fJP3143HUrtCoJvNt+3HZAELyVos8+o2CiKu+k+14oIVPxP?=
 =?us-ascii?Q?+cJVy38hunDfsK4JWH9aZVr4IDxpUpEXRqBEdEj0ag5c1ORLtEGT7Pp0PurA?=
 =?us-ascii?Q?n/zirxoX9rAMjjMZpf626Ku/F6y6hu9lh10VVL/nCMlyaDmPNsRZV/NcmVBV?=
 =?us-ascii?Q?AOXjKt+Y1eQ4EBVob7iaRWkavlc/NYhuv8rzfMJgra6Z2tMg3TLpc92Y3m0U?=
 =?us-ascii?Q?UB535Gn5HtprWNtjUxeQHzyrc0M864tjwW34ezafNYJRrzjH8EwHD8dtIqA9?=
 =?us-ascii?Q?LMMcOB84bfF89gazTd+vIhQx4n7itIx//3ZwDewKpVAk0IurMoKBbL+WUscT?=
 =?us-ascii?Q?DEhZD0qJm8nzIENXuNRZQzAIreHCVHIRSQacsAO4Ki3W7s0OEbxWF2Uq8z1M?=
 =?us-ascii?Q?ZT7biMFmJksdPJQHNOXkhucHimmoa256AyzCM0O6KnihB6W22QtV/4V9TnUo?=
 =?us-ascii?Q?6ZaDBA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: b0b3e791-1897-42e3-4f59-08dc4e08ab94
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 02:50:32.4727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QA4Wqmf37vIKbPDZQUsOTm+MWKvkCOOkrzM5pmLOAm/J6EWdMqPA7GKwioN1IPt+fbrWgBNT0GJdHXDPXsKnSOwN1xg9i3Pz0WWZwtmr1EE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BJSPR01MB0547


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Wednesday, 27 March, 2024 2:33 AM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>; Vinod Koul
> <vkoul@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> support
>=20
> On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote:
> > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > controller.
>=20
> Your commit message should explain what makes this incompatible with exis=
ting
> devices. That inforatiion does appear to be in the driver patch, but shou=
ld also be
> here. Otherwise,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Okay, thank you for the feedback.
>=20
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> > ---
> >  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 363cf8bd150d..525f5f3932f5 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -21,6 +21,7 @@ properties:
> >        - snps,axi-dma-1.01a
> >        - intel,kmb-axi-dma
> >        - starfive,jh7110-axi-dma
> > +      - starfive,jh8100-axi-dma
> >
> >    reg:
> >      minItems: 1
> > --
> > 2.25.1
> >