Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp52923lqe; Tue, 26 Mar 2024 20:25:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX7rYZm9WUSBX7XX5em1tUZ4eDmGGjsgrSeeqjuah4i/XwncS4ajTeaqwAczess5YuxeFmxtsGgcZqX8qKIJ3e1NKeEAKkXGwjdMbajZw== X-Google-Smtp-Source: AGHT+IGaEo1iSP/PiJWnPaN4/qLiyas6D1Fz51BgBa0+n7NeTPLcy6oY25QqLq83dJZWCgKMZBEA X-Received: by 2002:a17:907:7da8:b0:a4a:33b1:2a30 with SMTP id oz40-20020a1709077da800b00a4a33b12a30mr3761123ejc.54.1711509902025; Tue, 26 Mar 2024 20:25:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711509902; cv=pass; d=google.com; s=arc-20160816; b=ommOuy+8k1Xh0BQg1LqVBfIMysoNeEvDUKRv6GhVVVycaLFkBfMlnreJpDmPskimEW kD/rXeL5/q6EqyzSMwERM7sVcdiyis4Blj4Jq1ewYooTirTWcWYS5Xle4OB1Jroo6evN fSt2QerH5SiEmAXK/M4qOUwXJLHcrRRj3O0gGwPWLjgEViZ97m6VC9FfDozGtewnab69 2Ki3fBMtyWKOXb6lZIZ4MOglF8VsPmPLezAqwNGFYzpYUSpvxsOVHyvfmXmIuoArRdDN nB4lkAv/cabnRZVw/YV/F5aSEN1nOrEPLw+zk9VHjRYdyEzrs+bJN4j3njRhRAMh7rL0 gB9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=p0hDdOTQa8Y5O29o8gY+xwgEVRFrYYj2PI3S9D/Qk9s=; fh=TjEnODwMWlIsMv7LF/23U7w7qxHJ7mWo1UhMxdg4SJM=; b=Vgzfp7jWafhh+8EbLPqVqpndKZNLOqxFly4c4lU0e0frhvb/HHyJ25R51m7B4/jMr+ EQ+3LSlY6Hih3Ip3C5hPdUpt4Tv+ZC4y3DXsW9H8MV+kkBs+wwMP6McBo9cWLhx8A+aO xhKWKl+FA2yDVkhnsV3FjsrKl30fN/iAwC1vfsYufqdBaiJ+ZUqvJVrseEnfltyzZSwR XAQOUwzOwZOxoEWLzAErrMIs5oFgoD/ETlal2z9SPGllirSkY9yaamvY8ivYEn0QTjYi CwOrR9dEd4FY9FApzUK6fJjwctGuLH3ZW5XIvShzp272V31lZ3K4ftKbll8KCIKUQq5B FIbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SDWU+iQW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-120259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e25-20020a170906081900b00a4dfbeac561si663435ejd.1013.2024.03.26.20.25.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 20:25:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SDWU+iQW; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-120259-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120259-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8D56B1F31244 for ; Wed, 27 Mar 2024 03:25:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F70B2261D; Wed, 27 Mar 2024 03:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SDWU+iQW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8573E224CE; Wed, 27 Mar 2024 03:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711509888; cv=none; b=g+Jhir92XJNeFkiNRmJE2rWhId+asD2jQsDP+KIhpZU6NIN5aKVJjxaZ6V6EMljCR6qpwMKVl8vZN8hY+br9E8Ha5zKzKXX7h4GdUoxScwt48g3Ltlu7fzNByIl+Ez3kAlkud3bgAF+xZCq40Pxr5c3J5BMi8k0MF+1TZmgjxAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711509888; c=relaxed/simple; bh=swRUZHqPSAsKm7MyUronTgrU3Z74pQl10GYnHPTJqgs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O/Dquk20RMGNpUsnA37cKpuPzwnsagXflVjNvn3A6doabxAvWfou4nCZg3FgV4m/7+tx3N61FaDWpEHdNCNIRDR/ZtUof1T9Mhg9u6jiDU9pLHKP/Ly/rLAVfcWuBAjX01qGO4WRxGg6yYDbclWQigJGdk0T/Ep3GnAbWWy2f60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SDWU+iQW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9040FC433F1; Wed, 27 Mar 2024 03:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711509888; bh=swRUZHqPSAsKm7MyUronTgrU3Z74pQl10GYnHPTJqgs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SDWU+iQWknd4MzlIneS396FveeIUkY+T2YYUwQ3Tyye/yN6k9jEyS2N9czQaCrill P5LvgTSi7NrLrcjtz/B6qeJRzD/5WeRahq+cViGih42x5cPJ/Fz2QC54Q41mkXpLh+ VYk6Hp/tuY//j2mTseUXSIkfjMHlxc+rPrmICcGBUX/EorrFeuNoeNNxgnfM5MTOpq Udx4Ua3e9C00tKCceySUDpW1duQpSFbIgZuKv67IFL2UMzEYXj+lvW5w0xOmweTxW7 TjDnk5SClokhNiAkf2pLvHfg9uvUrAxJQezaeHxULgnPzcodXfhp6t42p31lijeLXk demyyvsilfIDw== Date: Tue, 26 Mar 2024 20:24:42 -0700 From: Jakub Kicinski To: Ratheesh Kannoth Cc: Nikita Kiryushin , Michael Chan , Pavan Chebbi , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Rafael J. Wysocki" , , , , Michael Chan Subject: Re: [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend Message-ID: <20240326202442.6e80cf1a@kernel.org> In-Reply-To: <20240327024430.GA1370891@maili.marvell.com> References: <20240326183544.488242-1-kiryushin@ancud.ru> <20240327024430.GA1370891@maili.marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote: > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device *device) > > { > Please address Michael Chan's comment to make this function return type to "void" > instead of "int" It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?