Received-SPF: pass (google.com: domain of linux-kernel+bounces-120267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 20:40:37 -0700
From: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
To: Long Li <longli@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	Dexuan Cui <decui@microsoft.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio
 driver
Message-ID: <20240327034037.GA22340@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1710930584-31180-1-git-send-email-ssengar@linux.microsoft.com>
 <1710930584-31180-6-git-send-email-ssengar@linux.microsoft.com>
 <SJ1PR21MB3457E5B4D852A914CD691E53CE322@SJ1PR21MB3457.namprd21.prod.outlook.com>
 <20240321180705.GA12387@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240321180705.GA12387@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Thu, Mar 21, 2024 at 11:07:06AM -0700, Saurabh Singh Sengar wrote:
> On Thu, Mar 21, 2024 at 04:42:44PM +0000, Long Li wrote:
> > > Subject: [PATCH v2 5/7] tools: hv: Add new fcopy application based on uio driver
> > > 
> > > New fcopy application using uio_hv_generic driver. This application copies file
> > > from Hyper-V host to guest VM.
> > > 
> > > A big part of this code is copied from tools/hv/hv_fcopy_daemon.c which this new
> > > application is replacing.
> > > 
> > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> > > ---
> > > [V2]
> > > - Improve commit message.
> > > - Change (4 * 4096) to 0x4000 for ring buffer size
> > > - Removed some unnecessary type casting.
> > > - Mentioned in file copy right header that this code is copied.
> > > - Changed the print from "Registration failed" to "Signal to host failed".
> > > - Fixed mask for rx buffer interrupt to 0 before waiting for interrupt.
> > > 
> > >  tools/hv/Build                 |   3 +-
> > >  tools/hv/Makefile              |  10 +-
> > >  tools/hv/hv_fcopy_uio_daemon.c | 490
> > > +++++++++++++++++++++++++++++++++
> > >  3 files changed, 497 insertions(+), 6 deletions(-)  create mode 100644
> > > tools/hv/hv_fcopy_uio_daemon.c
> > > 
> > > diff --git a/tools/hv/Build b/tools/hv/Build index 6cf51fa4b306..7d1f1698069b
> > > 100644
> > > --- a/tools/hv/Build
> > > +++ b/tools/hv/Build
> > > @@ -1,3 +1,4 @@
> > >  hv_kvp_daemon-y += hv_kvp_daemon.o
> > >  hv_vss_daemon-y += hv_vss_daemon.o
> > > -hv_fcopy_daemon-y += hv_fcopy_daemon.o
> > > +hv_fcopy_uio_daemon-y += hv_fcopy_uio_daemon.o hv_fcopy_uio_daemon-y
> > > +=
> > > +vmbus_bufring.o
> > > diff --git a/tools/hv/Makefile b/tools/hv/Makefile index
> > > fe770e679ae8..944180cf916e 100644
> > > --- a/tools/hv/Makefile
> > > +++ b/tools/hv/Makefile
> > 
> > I'm not sure if vmbus_bufring will compile on ARM.
> > If it's not supported, can use some flags in Makefile to not build this.
> 
> You are right, this is not supported on ARM64. I can query uname in Makefile
> and compile this only for arch != aarch64.
> I will add this info in commit message as well.
> 
> - Saurabh

Greg/Long,

I will be sending the V3 fixing above comment. Hope there are no
further comments.

- Saurabh