Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760969AbYARBxz (ORCPT ); Thu, 17 Jan 2008 20:53:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757242AbYARBxq (ORCPT ); Thu, 17 Jan 2008 20:53:46 -0500 Received: from ms-smtp-03.nyroc.rr.com ([24.24.2.57]:33509 "EHLO ms-smtp-03.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753420AbYARBxp (ORCPT ); Thu, 17 Jan 2008 20:53:45 -0500 Date: Thu, 17 Jan 2008 20:52:47 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Linus Torvalds cc: LKML , Andrew Morton , Alexey Dobriyan , Kirill Korotaev , Ingo Molnar Subject: Re: [PATCH] printk deadlocks if called with runqueue lock held In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 36 On Thu, 17 Jan 2008, Linus Torvalds wrote: > IOW, I think this should be > > if (raw_irqs_disabled_flags(flags) && wake_klogd) > wake_up_klogd(); > > Of course, not all architectures seem to suport that thing (it's currently > only used by the CONFIG_TRACE_IRQFLAGS config option). > > Damn. So close, yet so far away. Perhaps we can define something like: #ifdef CONFIG_HAS_RAW_IRQS_DISABLED_FLAGS # define test_irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags) #else # define test_irqs_disabled_flags(flags) \ ({ (void)flags; irqs_disabled();}) #endif then we could do if (test_irqs_disabled_flags(flags) && wake_klogd) wake_up_klogd(); Or is this asking too much ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/