Received-SPF: pass (google.com: domain of linux-kernel+bounces-120290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 21:15:19 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: "Yin, Fengwei" <fengwei.yin@intel.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
	Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	"Li, Xiaoyao" <xiaoyao.li@intel.com>,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v8 00/14] KVM TDX: TDP MMU: large page support
Message-ID: <20240327041519.GD2444378@ls.amr.corp.intel.com>
References: <cover.1708933624.git.isaku.yamahata@intel.com>
 <8f7735aa-517f-4bb3-8e33-d58a27c2a822@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8f7735aa-517f-4bb3-8e33-d58a27c2a822@intel.com>

On Wed, Mar 27, 2024 at 08:53:50AM +0800,
"Yin, Fengwei" <fengwei.yin@intel.com> wrote:

> Hi Isaku,
> 
> On 2/26/2024 4:29 PM, isaku.yamahata@intel.com wrote:
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > This patch series is based on "v19 KVM TDX: basic feature support".  It
> > implements large page support for TDP MMU by allowing populating of the large
> > page and splitting it when necessary.
> To test the hugepage for TDX guest, we need to apply Qemu patch
> from Xiaoyao:
> https://lore.kernel.org/qemu-devel/20231115071519.2864957-4-xiaoyao.li@intel.com/
> 
> According to Xiaoyao, it's still under discussion. So he didn't
> send updated version patch. For folks want to try this series,
> it may be better to mention above link in this cover letter?

Makes sense.  Let me include it from the next versions.


> Test in my side showed several benchmarks got 10+% performance
> gain which is really nice. So:

So nice.

> Tested-by: Yin Fengwei <fengwei.yin@intel.com>

Thanks,
-- 
Isaku Yamahata <isaku.yamahata@intel.com>