Received-SPF: pass (google.com: domain of linux-kernel+bounces-120317-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240326121735.11994-1-animeshagarwal28@gmail.com> <7567a9b5-fd6d-4729-964e-14c4e129bcd7@kernel.org>
In-Reply-To: <7567a9b5-fd6d-4729-964e-14c4e129bcd7@kernel.org>
From: Animesh Agarwal <animeshagarwal28@gmail.com>
Date: Wed, 27 Mar 2024 10:24:23 +0530
Message-ID: <CAE3Oz83njHf3ZuOq_cVfLTH93H9Y-qBDokAneLmkJ1OLFvE1og@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Sorry for the typo, I'll add it.

On Tue, Mar 26, 2024 at 5:55=E2=80=AFPM Damien Le Moal <dlemoal@kernel.org>=
 wrote:
>
> On 3/26/24 21:17, Animesh Agarwal wrote:
> > Convert the ahci-da850 bindings to DT schema
>
> Missing a period at the end of the sentence.
>
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > ---
> >  .../devicetree/bindings/ata/ahci-da850.txt    | 18 ----------
> >  .../bindings/ata/ti,da850-ahci.yaml           | 36 +++++++++++++++++++
> >  2 files changed, 36 insertions(+), 18 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.tx=
t
> >  create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci=
yaml
> >
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Doc=
umentation/devicetree/bindings/ata/ahci-da850.txt
> > deleted file mode 100644
> > index 5f8193417725..000000000000
> > --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -Device tree binding for the TI DA850 AHCI SATA Controller
> > ----------------------------------------------------------
> > -
> > -Required properties:
> > -  - compatible: must be "ti,da850-ahci"
> > -  - reg: physical base addresses and sizes of the two register regions
> > -         used by the controller: the register map as defined by the
> > -         AHCI 1.1 standard and the Power Down Control Register (PWRDN)
> > -         for enabling/disabling the SATA clock receiver
> > -  - interrupts: interrupt specifier (refer to the interrupt binding)
> > -
> > -Example:
> > -
> > -     sata: sata@218000 {
> > -             compatible =3D "ti,da850-ahci";
> > -             reg =3D <0x218000 0x2000>, <0x22c018 0x4>;
> > -             interrupts =3D <67>;
> > -     };
> > diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b=
/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> > new file mode 100644
> > index 000000000000..d54f58c12e78
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI DA850 AHCI SATA Controller
> > +
> > +maintainers:
> > +  - Animesh Agarwal <animeshagarwal28@gmail.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: ti,da850-ahci
> > +
> > +  reg:
> > +    minItems: 2
> > +    maxItems: 2
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    sata@218000 {
> > +        compatible =3D "ti,da850-ahci";
> > +        reg =3D <0x218000 0x2000>, <0x22c018 0x4>;
> > +        interrupts =3D <67>;
> > +    };
>
> --
> Damien Le Moal
> Western Digital Research
>