Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp82694lqe; Tue, 26 Mar 2024 22:07:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUkErBSqtp7qW1+cRAMCmlOfCyBe89/iLb8prBvhwNnQXD+/tOaVDaT6no2gkLFhVr1vsr4Vg+q89gTFCg7yJj6YSmveAaE7d1/WBHuWg== X-Google-Smtp-Source: AGHT+IHEsSj3EoZ5Xc1ardTum6WZYIdIvQNd5y3/1s7z8w1faqrOnrDmCLM+MCEWLWro7zu5BWhr X-Received: by 2002:a17:906:314f:b0:a46:4e14:c9fd with SMTP id e15-20020a170906314f00b00a464e14c9fdmr3161488eje.23.1711516025397; Tue, 26 Mar 2024 22:07:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711516025; cv=pass; d=google.com; s=arc-20160816; b=uVKWntt6H7jP+B+ljDCkBymdupkSbvQjK9cBBt0rQzo+DSxkWf2uHVDjzSpfoIA6J/ mQMk9I+g8UNXzOKSNUo6ia/zPqGGzR/fHnF3MMwjhf86RkUt+9bndNNOwq89E4oCrBy+ I2pTkqRd6hm6nVJJ1uXl7lEirRjnAFDsm0XuuTHysL9br/Lwy9iCllUlhvmR/+QqFTvg b1YGXK02NJGxk1feLwuZ5M8P/XXDXtUILMqDuKMJ6Dkj+mnOAbz5XPKEgSKoLET4QXqq GMzBaM7GmV67au5TaS3pU4M2NUPO/X+tOQi8ZjhQk2faWltkHDb79YIt/jDN091TUTmJ sP+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=kgGCLKLZ6dShQHYFiEl6KvOJXuzdbTsRgs8rlzYf7mw=; fh=8nGaOLJfRslt22B+rBoOpe8jn6jq2j5HcO6JObEVqrE=; b=bBrkWdt4qfoszYt1sdQUXavxmqORLYRZtfRP9MThc7t41LEZUJnXcZoQECXm3IpX4O Jo5l6IEKZTrVejbksjPSQnkrvYDyX4nwrKdNTspB0xKSW7NHIQ/aWo9Cqemti9aKdtgR SBEpoYg0JOVml/ZhVx3hYicc83rBcVU0ksSa+U4jCKssI5XvPrIFtPsdQRPFZdZHYSqr 2Sj2n8M6phOxDeU8neu+eI2nf4tB3qB7TCBmgNHBxzdOZax4xRnEqIBVgQYE4aDIeRqi +oskOkZ7jxp4Oiee7oyC6GVLH2K38FTboT7634uFMoyB5nx54MZ04Dfn97ozurwfXPCt MARw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tbi3dzl8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-120319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m12-20020a17090607cc00b00a4df0767a31si1456407ejc.328.2024.03.26.22.07.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 22:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tbi3dzl8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-120319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BED4A1F2BD9C for ; Wed, 27 Mar 2024 04:59:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AEC76125; Wed, 27 Mar 2024 04:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tbi3dzl8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7412A4C61; Wed, 27 Mar 2024 04:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711515571; cv=none; b=HwPJYsfI8e5+q62v3vji8juKwVA1An6tWECbmTE2qMfD8vjaY89Vp88kUePew9aC5vVorhdhNsE6QzK7JC7dEmA9OXAdYqsuTG6OvyaOxSy2cv3gyl+iahXDZqBY4nMNMa/DRDhf2xBONYTStNC0prQMH88/VLBn7Qwc7qzRUiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711515571; c=relaxed/simple; bh=eSaJ+P0zeR4YINFS4ewCmBAtuOzyxpYOIev2jbmhPCQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lnu89U8imNi0XD6UIXsOykCT16WD2Fx/Mmf9yym53mt/OGxbwz94i/1YIum/Oz0TsEqbOz+HWhXaRmwyYyOOPh90m5gLOBJvoXz3yhO5m+kqY3+y7vALHz1GgwHmGO3wjOqrUL7rlJVJ0byCLfpHWwseLvbVUDvkNJ5cQXMfzYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tbi3dzl8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23AC9C433F1; Wed, 27 Mar 2024 04:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711515570; bh=eSaJ+P0zeR4YINFS4ewCmBAtuOzyxpYOIev2jbmhPCQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Tbi3dzl8AGyJphMbu8UKfUJtyxeNWv6xq+BoiiCkef1MD/HM+hjhU/sTrMtDAISCT /GGYxvTJqJOHP+0xOvXTB1qQjeZhKa4UzYN6wUpU19Z79y3aKER3EcWtvkIiL4paYs zL3V4gBYV00aul8dL21L9C2mNql56g3R9OUa1pxsCtQyh7YiOSe4yl3R/1PF3HYkEf lA6EmxWtMB4gKKU0pVVaIdLZgT5dSBUbzm+VexmaeMM5g12YD7JW9N7yxK6uIAqJfb 2h6mI9erMWYSTP+PYY756Uuv5ioD8l4x/rFNLj868t/itOmbHQZSITd2jMVyhcfgvq 9EiYQhGjRyE/Q== Message-ID: <03e1941b-0c8a-450d-9b83-76260817d303@kernel.org> Date: Wed, 27 Mar 2024 05:59:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver To: Pavan Holla Cc: Greg Kroah-Hartman , Heikki Krogerus , Benson Leung , Tzung-Bi Shih , Guenter Roeck , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Abhishek Pandit-Subedi , chrome-platform@lists.linux.dev References: <20240325-public-ucsi-h-v2-0-a6d716968bb1@chromium.org> <20240325-public-ucsi-h-v2-3-a6d716968bb1@chromium.org> <62b2c29f-ca1a-4131-910b-7b9b62a5577e@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/03/2024 04:39, Pavan Holla wrote: > Hi Krzysztof, > > Thanks for the review. > > On Tue, Mar 26, 2024 at 1:47 AM Krzysztof Kozlowski wrote: >> Nothing improved. > > Yes. I only added maintainers of drivers/platform/chrome in v2. I am > still investigating why MODULE_ALIAS() is required. Heh, I wrote why. You miss ID table. Best regards, Krzysztof