Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp117286lqe; Tue, 26 Mar 2024 23:57:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWRL3SIQFm4Sw4iEauOO21tdwE4Uvf7nLcq3cu3hbpXu9sHQMjuvdvD4QzPyD3nQG4/Lj76FfQg+aJGcumD3lT17GB7jpxYfbyjFzCvxA== X-Google-Smtp-Source: AGHT+IGFKucwK87J91BAnPwISFNN8s/XkOm5iNXsYEO+ZrTSdH6G19ToCx0duGhMwKNRps/537yo X-Received: by 2002:a05:6830:4c9:b0:6e6:832e:87e5 with SMTP id s9-20020a05683004c900b006e6832e87e5mr3900689otd.27.1711522657586; Tue, 26 Mar 2024 23:57:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711522657; cv=pass; d=google.com; s=arc-20160816; b=UnLkZxnGdk21+KLj6GxGgzw524AVGAoARvPPRAw/ZF9fmhi8YjuVf28JY0tq2ySa8G mwaozZLhsynPfS26yTEZJwz+QZXYXH/9jCV6LrQSpw3VVrI4/dRUtDNveu8jVvkweW9+ kzDK63fijJexkuKqdD1o326Px19NB/25xn84wwEk8JarUVGFdtPxxtcK3KjxsObNLgvR hgq0U6vZMzrn+29ocQ7M2MnmxvuujVeL0MV8+5KhrSx7I/D3mGvT/cILFlkJPDZ9yEYL d+KleZgzCo7/vE/E3heSSkLR4Ibw9vzJB/stRY9ooEYjosRNZJvkZP5lSJ1YUfRrjz+/ rucw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=SLe3EkoAmpsK8G38HlQexQFaGXpkqG9r7/RlGeZTW7w=; fh=4GHyKZsQEynSrksB4xUWAaW98+xx5mDW8n00Zy11MLU=; b=iYsokjCzwciVZDzbJUaouH92lzbVU4hlAxjbsEzXwZUeYIJJzoQjXWl6eG8r4ne1OV mBBn1OqXGEi+UPyzm6GIbgFeHsZJqCsZNJqmvTyjIHdHqtcgjsIRJm97iLhd67dsa7PU oeYDgcUG00qu9vKcmgwp75s0zNzulzlOZbr67oYP/vpHHu43AfYSzsfkGYiFZKy9rYUb +92RXNfBHWfGRITdQE1XjL4mp+NtTKG0U+KF3whxlHJxd6OrqY1uabedY93/UrKzahtG usCULr01dpW1HyAoHzOI9CHp1T2wzpE/t6+lmCjg7aUuwkH7Q2NPBs3uN5hmUwqTwjat SR0A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LXFx52Pj; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-120403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120403-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q2-20020a656242000000b005ce7efd2eb5si921492pgv.266.2024.03.26.23.57.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 23:57:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LXFx52Pj; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-120403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120403-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 007322A3E28 for ; Wed, 27 Mar 2024 06:57:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1E0E249EB; Wed, 27 Mar 2024 06:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LXFx52Pj" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74763241E1; Wed, 27 Mar 2024 06:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711522648; cv=none; b=pAC6nIu8VAhwJAJGCW8Iyh4O6U/i3kC+ZaZreaV9tczxbiXxLtM43KNlF+Sg9u877sJ9csp8rb2fxzi+aIEwdUCCydpX/izjCWonw1SdYpTDK9mGIkfrqv08Tzv3csUOm52XkQhh/O5UBCHKjDSm1d4Mm0GGw9tdeOMHftu5Gag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711522648; c=relaxed/simple; bh=SLe3EkoAmpsK8G38HlQexQFaGXpkqG9r7/RlGeZTW7w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=RcBTnc9IU94hLZDWOkcOAZy2ogKad6xIy0EXS5ufopfKVNAC5m6w62BTgOUY5/eckbjqT+dqqD3EaPkeGRqOQ+alpaq7gfjbQZfpTgwnZe3K+hV7nqVqMFf4W+2BB91mh225+KTwi4aS+s/GayXmQY6nmWvkLbLjsb97rKs+m18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LXFx52Pj; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56b8e4f38a2so8110742a12.3; Tue, 26 Mar 2024 23:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711522646; x=1712127446; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SLe3EkoAmpsK8G38HlQexQFaGXpkqG9r7/RlGeZTW7w=; b=LXFx52PjjNw0+ED8EE4gfujBsrIZ8MSviDj0zCkd5OpnYXQDqDN5hxrWIzqBvH+Kml 0l0OcetIto8sO6NJnZZb1/57QS5ErZBmvz2kVzHzqJU6V5rtDXL24nvyoHm5H8tiZJai TfOqN/XHSCWDhtiiTQfbVQAQE+RMvjHR67LCNm7F61n8Myb54ftsr4ALssQLQ4WLDGKr y1KD41KEAaodh2VpYSE3z0Fz1JtUj8vXFSfQpJJoqqQbRuUJiuJ5jPhXTvgwHCwdMS6Q l+NHmvDwi6RpWRwOTeNoFRrwYjJQxDGGh1JAjU70othm26Tc0npe+aXz56YzUFPPw+jM IF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711522646; x=1712127446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SLe3EkoAmpsK8G38HlQexQFaGXpkqG9r7/RlGeZTW7w=; b=RvAUuxifvjdISQ49XXYJhPoXl13BHm+ah1+95ml6bmQp5opvnKs5bKpRKGRJaTIu3X 8EeChA17hLyI6CmJrX05v7vu572lcgq2+pdxKxx1EaTQPE/0FD0jf7EJWEYZnMsKc8tJ heXUQxN7Hps++DoP0PaLsmu4Gm2InELGb9/c3k17pIM6raWW1qIGQL+vzt0QhocEkJj7 sZYb2nuCKJ+NIcJxCry0Eq5UFxaG0P/9bXOuVBTfgVg9hgFp9AEUpcMi/Avg2kB3Y/ec EK6CiKD2BhHFT1z+cTEEai4gwwRkosbo+6EbJdb0yo2cQ/LK25fziJFAMyZ6sEjmrWbN DKiQ== X-Forwarded-Encrypted: i=1; AJvYcCWrBcEqYY6RI61egIjulf/RZZQhgXHasLvGcg7wDS3S0kg63fPYFzCu5mmt1MsRFm78JsMSxpT8a0/qHn3/s/X+kl76TSeahYuloZ9tg5yvVCJlQlH8wbP55sjLGAUDbIk90yx75y19bWaJbRI4FdwkY9ODSWsdzzYwNxnjer7KTZ0Hu+pHrKg5 X-Gm-Message-State: AOJu0YzHnZObMPn615h1BJIe8BXM8sCo7vY5mA6Nq7WpMQsRoj2E/6Jb WREEJjKr3EKbufCX9fK84u5iTaxv7+MWuPFQi+0Kxth3n/QiNflKBams5eWpVdSAy7G1bEb5ImL o8OZuJ7blQG5v4LwPNM/58r2IGX0= X-Received: by 2002:a17:906:3c12:b0:a4d:f400:4e17 with SMTP id h18-20020a1709063c1200b00a4df4004e17mr2441213ejg.34.1711522645616; Tue, 26 Mar 2024 23:57:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <0c8b3e33dbf679e190be6f4c6736603a76988a20.1711475011.git.balazs.scheidler@axoflow.com> In-Reply-To: <0c8b3e33dbf679e190be6f4c6736603a76988a20.1711475011.git.balazs.scheidler@axoflow.com> From: Jason Xing Date: Wed, 27 Mar 2024 14:56:48 +0800 Message-ID: Subject: Re: [PATCH net-next v4 2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb To: Balazs Scheidler Cc: kuniyu@amazon.com, netdev@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Willem de Bruijn , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Balazs Scheidler , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2024 at 2:05=E2=80=AFAM Balazs Scheidler wrote: > > The udp_fail_queue_rcv_skb() tracepoint lacks any details on the source > and destination IP/port whereas this information can be critical in case > of UDP/syslog. > > Signed-off-by: Balazs Scheidler Looks good to me, thanks! Reviewed-by: Jason Xing