Received-SPF: pass (google.com: domain of linux-kernel+bounces-120438-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 27 Mar 2024 15:39:32 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Jisheng Zhang <jszhang@kernel.org>, 
	Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH RFC] riscv: dts: sophgo: add sdcard support for milkv duo
Message-ID:
 <IA1PR20MB495363491777ADC885D830D1BB342@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240217144826.3944-1-jszhang@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240217144826.3944-1-jszhang@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|CH3PR20MB6968:EE_
X-MS-Office365-Filtering-Correlation-Id: 427fa61c-dd3f-4d52-7e2d-08dc4e31065f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TUa60LCVu9+KtNAYJtF4AHztwgqnmhB/T3hVUXVDJtxarExAHISMaIyOEfEWTEKlq4f9KEUSq8BewTzzqYY65gKj0kI4pWpWtlPz1Hbl3/dRfdrPUo+8H5Hrr0MEefGjfKhAjL0IOL1SCuKnca4qB+oHq0FZt9vdzOdz07Clo87lem3hxHHLibdlYJMqDcfqoUjqNEpkT/i97FdCosv/YLeYYxGomBoU1c7XiooKC4N2NXtWDueFYdvb7PVu+E8Hp365QZR+m2ZpO9OMDGz7DEaHTGXZYd0abApF7TZjyRL/ra1MX3afDzB2lt2hjo1jBSRUUa5a72r0NpXdjcte/aag4d4Du9tw1o7UTSx4Z1gEE+I0p9pKNch+IkUiIXc/PP6xlNacPyrsXpfqUPwd9bHA+RTm6DKpEvLjTUxBcw22d+6y5Hi8ETuKmV/LlbGuHCBXmrgGhSlMjPccXo79B9fzaeuoBnudB0oaOAY2beauoN+uweEBXE1bCeHC3LBc+KowzFLmpNyJlf6N0OcihtZ7EYu6oshmbz1afokbsWi2Gg4EqhC3p+RDeRRjEzw9
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?poSLNEONaibh8HWpuxU4aQD2CNIr9v78Kgaxcj6E8JF7FwZxIKincKx4uzBR?=
 =?us-ascii?Q?PcZufairBma+DJID4E6CTb2iMmN2ljYT5IHZPW6WeIYSGN9T0bgB9XYnpxgx?=
 =?us-ascii?Q?pbE/BOkPTj04ENT6uwPFDQguxYSarE1mU5MZ+VsXd7PfEpYNXvOcURDfeUwj?=
 =?us-ascii?Q?dmMvWOvx+P5k/d05VEBPz2ZLRojT9WpwlG4/HRa6lSsMh6hezTCuv3bjA+zR?=
 =?us-ascii?Q?ASj6oToV/kBGFkhd7VIqLcPo04eGmdRTKRiEMc0ECrKYRUjRIApk5qsgp1u9?=
 =?us-ascii?Q?9YAY+EFP1yb4Y3j6KlACUNTLQMgTdal61NFutnMQ/BqR6tyXsapwm73BbjiK?=
 =?us-ascii?Q?yiYMqWKsOvu09LCxem16ieB4WQiYvbAT41P5SQmfxbFHJPIy0figxr2JF1Xe?=
 =?us-ascii?Q?niXDrOFDYN0NEv+9GhU2cK9bOVnBtn3/NeMMkxxGcCo7/AL9tHbYNnMXrQo/?=
 =?us-ascii?Q?DUbzzeUYcsEWzqfWp45Pa6MOaQ0oRwY3g3SuK/AZRUrCJuNtyqRoL14t+MKl?=
 =?us-ascii?Q?3ZGmGTTId0sot9Ts2Vi/+K0spjnCRfkLZUokC5KmpPPz4FQvpNX9fE6gatQW?=
 =?us-ascii?Q?ghhpl+UWC9RMbKR/YbzRzPmPg+Q/+e8YyvzYbp9PE1V3B4IML8Y+FDoRxTtM?=
 =?us-ascii?Q?jklxipPyjoFdWF+Fr8c+4kMqZPt8fJtKqTXUTRAoL7pWoekecuCfLNCupDVM?=
 =?us-ascii?Q?HiS4OjtADUZ0IceZQfeVlD92pEb8lBJKPhONRKhGP3037O20DOvurwsmMm81?=
 =?us-ascii?Q?AxXtH3CXobdmWS2bqNJTQNywnFgpyqbOwOwwFRhtNIOdbmFpjTOgOo6A9XlU?=
 =?us-ascii?Q?Z43IO7IDgJNtg2XzyDYkYmeQX05kUB9wjhVocYLkYk/s6j/UW/xCt1S68j8T?=
 =?us-ascii?Q?9jBupBKQjgsee+lNtdm/EOq5O7jChe8txjUGUY6u1yFcgS9pOiQ1LUkHrc5n?=
 =?us-ascii?Q?dd6qIiyJB/J5XoZ3woixq/X7XaaITXGf31oB+b+r4NF3jV9E1a7AZEESuv2T?=
 =?us-ascii?Q?XwPzaEU30Y4sifuD+xTndSZka2pkJQq6/ARhyNVNvILkl3ybaNW5AROfhZKH?=
 =?us-ascii?Q?KXDjs8d1aWbJcgNv5DvHsJuv+tfZ/ezm/Ch3/VnfGg7jW68Y/albdYuGE4/T?=
 =?us-ascii?Q?YQD4lwNxoG3+UergERhp20DSYzq2CJy28/FYwPWdUnPcAhW4aDtn1adHlq4O?=
 =?us-ascii?Q?wc+Mc3vwpEp43Sk1Ydss9Dx7+NKkDkj2odazYoRDJTvPm6TyxYcZYFpKofEk?=
 =?us-ascii?Q?ZSi/NdEdcr4Gs71k1M9c?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 427fa61c-dd3f-4d52-7e2d-08dc4e31065f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 07:39:26.8885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR20MB6968

On Sat, Feb 17, 2024 at 10:48:26PM +0800, Jisheng Zhang wrote:
> Add sdhci dt node in SoC dtsi and enable it in milkv duo dts.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

LGTM.

Reviewed-by: Inochi Amaoto <inochiama@outlook.com>

> ---
> Since cv1800b's clk support isn't in, this patch uses fixed dummy clk
> and just RFC, I will send formal patch after clk support is ready.
> 
>  .../riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts |  8 ++++++++
>  arch/riscv/boot/dts/sophgo/cv18xx.dtsi          | 17 +++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> index 3af9e34b3bc7..94e64ddce8fa 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> @@ -33,6 +33,14 @@ &osc {
>  	clock-frequency = <25000000>;
>  };
>  
> +&sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	no-mmc;
> +	no-sdio;
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
> diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> index 2d6f4a4b1e58..405f4ba18392 100644
> --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi
> @@ -4,6 +4,7 @@
>   * Copyright (C) 2023 Inochi Amaoto <inochiama@outlook.com>
>   */
>  
> +#include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  
>  / {
> @@ -45,6 +46,13 @@ osc: oscillator {
>  		#clock-cells = <0>;
>  	};
>  
> +	sdhci_clk: sdhci-clock {
> +		compatible = "fixed-clock";
> +		clock-frequency = <375000000>;
> +		clock-output-names = "sdhci_clk";
> +		#clock-cells = <0>;
> +	};
> +
>  	soc {
>  		compatible = "simple-bus";
>  		interrupt-parent = <&plic>;
> @@ -175,6 +183,15 @@ uart4: serial@41c0000 {
>  			status = "disabled";
>  		};
>  
> +		sdhci0: mmc@4310000 {
> +			compatible = "sophgo,cv1800b-dwcmshc";
> +			reg = <0x4310000 0x1000>;
> +			interrupts = <36 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&sdhci_clk>;
> +			clock-names = "core";
> +			status = "disabled";
> +		};
> +
>  		plic: interrupt-controller@70000000 {
>  			reg = <0x70000000 0x4000000>;
>  			interrupts-extended = <&cpu0_intc 11>, <&cpu0_intc 9>;
> -- 
> 2.43.0
>