Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp135734lqe; Wed, 27 Mar 2024 00:45:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVSmzqd39Eh4x0I5Q0keiEOrTsiuDSvZLP1EcPGn3g+lAw4x1MLrc9RcwKfrX+QuWNXL2uv8dOGraMH2mIjqnAUnDdF0TNQ4j75nNilug== X-Google-Smtp-Source: AGHT+IGUWYWNP9iR6r92JqdcZwOM3ja0pXFyJvu7+esk7v6aRoTytwQqHP/WwE3IMmjQWHqsxJp6 X-Received: by 2002:a05:6a00:3a1c:b0:6ea:aaf5:e088 with SMTP id fj28-20020a056a003a1c00b006eaaaf5e088mr5217088pfb.5.1711525545272; Wed, 27 Mar 2024 00:45:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711525545; cv=pass; d=google.com; s=arc-20160816; b=qyB1Uua1WPQTcLMQJs05rZbCtZzlzBeHLcadLowmdf6A9gU30B14hBKLaPs2ns24zW v2Kx8X72QHqMccd2VRGWIAIAeD8XIXkkubiIk+YWZnGoolzuzDsx5yJGXu4lXFt1CClO p1Z1c6jomfFzk7bteAZWtPoWg+oI5LAFEWvskkZzZZXO3HDgJy2BExEqT1BnA1nUaVfW TE5jWhOBqabqJAuyvyQZcCA50NnwzcTw1YKnzYWcOHouthVzQMC8KwTQFeZc1FjEydv+ yV7kZu4ABhujRiYaobp9wQDC/LYxPIMUqGCGwJ9k4FowO/YAzKY6Z+oRyF+ya6xw9nE0 l6dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QY3HLOfVVC65tl0eSUhsUEO/4NTS6NQKZYZT8QqXT2A=; fh=orh2zKSd7Im9a0GkvoikBkBBeYkDgaqhARTitOWa4z0=; b=tub/GrMvWrA3JZpQYiSB6DSoHhzC9RxzfCwdL7P3gtBQ2uEsHzZdxF356Xk79f7GSE Jrd4HaN/S1McbTiRnN7IyiOisCfWv4sV5WkrCwY27TlkpjDK2+kJrBR3tw3kFMHaGHdy HGsUBKS4jFZuuir8x/7gjOMGPD3yQHhRZze0UuVU5LKOK6Biz7iGn+e5PCvTqv86aG62 JJLe0xIUvj91zy7cSMn+8Knu4YFdU2857zH53A96A0rKy+OcCJ/C4SbVIqFLCfp0QX4g lIrLVmSZgctHOuEDl8eIIKIbfYJ/NbJetLA1+UPqWq1gRtFpajXrI0BH6r9OL5u50bse jQ5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CIv7bUYu; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-120447-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id w14-20020a63490e000000b005dc365174desi11432916pga.377.2024.03.27.00.45.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 00:45:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120447-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CIv7bUYu; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-120447-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120447-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1BF40B221BB for ; Wed, 27 Mar 2024 07:45:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 272DD33080; Wed, 27 Mar 2024 07:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CIv7bUYu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8682E84F; Wed, 27 Mar 2024 07:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711525493; cv=none; b=j8RxJZheyB0+8mnaQ2/hcHIaTv4wyTd98GEJsIGi0X1AM2kzDumSZm6P4D7GDIIOFc6O4fwdcRkB0KgUSsRh5cKaqfZiFz2JL7AmjMRAaOcbkZTaC6ddjf6W+7YePVTQvMaiqrflMoCk/gl9+EYy+pz5cNNC7Mpy8naad/ibRAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711525493; c=relaxed/simple; bh=Vo4tpCBhH8KPWILqOFDHjrb/brtS1Awao540EB/KPuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=csuwJwZRFNTtPxp8ZNN1o7g1KElVy+LwEWdSo1YkU56rnY+UQEXq7Uo2Qk5+YqsUEYFund9R2L8ksEkqzyH8kkxH42knb2yFs1bHFL3Md7+POGZZMEXy3B4tS/S7+uRUzOjH7c8ng0qRazUyLPfUuJtP1BEW2r7MSerTDOm15gI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CIv7bUYu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39F61C433F1; Wed, 27 Mar 2024 07:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711525492; bh=Vo4tpCBhH8KPWILqOFDHjrb/brtS1Awao540EB/KPuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIv7bUYuMv9e1s3cMH9nfYHCAYTvSpkFc9yT8AtQgxaRr1c3NzUjWn/t7SrqhP5bZ LtKGtCJccNCaO6Rqqqa6T1FXB/zyPTFk1Q/XMC8uNNqzhwcdpY9AFMUJqyYyBNNJNW dhruLWIm6Albrld8kCIJy3il66qOYPjTA0bvsfdI= Date: Wed, 27 Mar 2024 08:44:49 +0100 From: Greg KH To: Norihiko Hama Cc: "stern@rowland.harvard.edu" , "linux-usb@vger.kernel.org" , "usb-storage@lists.one-eyed-alien.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb-storage: Optimize scan delay more precisely Message-ID: <2024032745-transfer-dazzler-2e15@gregkh> References: <20240327055130.43206-1-Norihiko.Hama@alpsalpine.com> <2024032757-surcharge-grime-d3dd@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 27, 2024 at 07:39:55AM +0000, Norihiko Hama wrote: > > Sorry, but module parameters are from the 1990's, we will not go back to that if at all possible as it's not easy to maintain and will not work properly for multiple devices. > > > > I can understand wanting something between 1 and 0 seconds, but adding yet-another-option isn't probably the best way, sorry. > 1 second does not meet with performance requirement. Who is requiring such a performance requirement? The USB specification? Or something else? > I have no good idea except module parameter so that we can maintain backward compatibility but be configurable out of module. > Do you have any other better solution? How long do you exactly need to wait? Why not figure out how long the device takes and if it fails, slowly back off until the full time delay happens and then you can abort? thanks, greg k-h