Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp140864lqe; Wed, 27 Mar 2024 01:01:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOLJmE6DB7KDnsFojzbuGDOE56huf2v6U8pJGuX5WE3dik4PY7NfHz8LMVf+LSpi5pdztUD1Mk4yoaBbWt47u4LY+PIey+GY5QFLPKNg== X-Google-Smtp-Source: AGHT+IEbPIgFp+sCrPtQgIPc/eDflOcMwJA26SGSaQhV3LsyHZ7sPdK+7LkqyI07xu5Gm1pHVHsI X-Received: by 2002:ad4:5c8c:0:b0:696:2390:6eba with SMTP id o12-20020ad45c8c000000b0069623906ebamr587525qvh.60.1711526474924; Wed, 27 Mar 2024 01:01:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711526474; cv=pass; d=google.com; s=arc-20160816; b=k3wKTI+EJiQD+HmCQVDx9p/zEzjxtli5c2HLLT4rH5GroeR6sP8s3Iq+YulxqcRWno yYpPosOdevn9ieZZTfvhIz9C2GEuz1WpPfOn5MJHYmfWMXUf0zfJKAdo/IJEATvYvSru KP20KccpZ4FiGFfx6edHfPnyD+/4bp5qcoclg6y/tkpeX/ComzkiCVD+TGHdL8ldIJ/d sVa3dosb9eoqZHFYjyMvhmV2abiw+ligwwXhA0D6Ro3AicF/2Rb/wqYwcaM41gAcm1VP s7LpaE//OCADpNY1o41o3HAz6Pnop0GPQyWXQjbJKsf6ESwuNgxtmsFp4ZCymY4gLZ+Y ogcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TDy5Illrx70H+5XvK63d5lpudD3g0VrV2VxsSwir7fI=; fh=lSxxqiSIpZctf42e3jVoyYUtw1f/pfBJogiL2GfK96U=; b=Bx85HPvOXeRk29hZlnN9GlHT/+sNZJ0/FyQJpImnOGTdRAkI+hgsLDt+p6LVJ5NIsQ S8vgEq3tXRUbUFa+pwgv9FcdzD70zM1No5uaKleMDKugO+VjDZ7buUitp3WpoYcHpS9Z ZRt4SJ+khq+dlSdBI1GLZ68sBEcr4axIsQ9ieVQSHJRfEZ62+xPctiPkYB0epIRj4Twp MRAucMUbgT4Tz/XAIexK+NoJd9p5qAk4sFkz4ECvsKUJZlZYFTaVeQtfZDaeog7xn8eB n1hJZZ/t2vjxZYE8etjmPaltAOaE5TJgylQX82Zs5bxjEhTPOSAuS0E2va01nM/ogdgj WoSQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bky9xrGB; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-120491-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120491-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gs14-20020a056214226e00b0069617a730e8si11540038qvb.518.2024.03.27.01.01.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 01:01:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120491-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bky9xrGB; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-120491-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120491-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A2C4F1C26542 for ; Wed, 27 Mar 2024 08:01:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63E1B4EB44; Wed, 27 Mar 2024 07:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bky9xrGB" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BA34EB2C for ; Wed, 27 Mar 2024 07:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711526292; cv=none; b=oK76D/1PR/dhnQ3DhMcgJo5WAR8VcjYaYq+xKAmE17rSLI5uLTyW7smuLTy7j/L57UbkuMO6bzsB3wsBgXUDF/h/XvUZMu35MMeCCPC9KwvIUKl7OhFNFIQT8/DDTaWfGlbvoy7KSKUT59AOfxikkwP9TtfLirWx1rPWvs6Y3fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711526292; c=relaxed/simple; bh=AdvzqVk7O5Om9zYVogxzKc5FzxJiG73Lmt6jW0x/4ZA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ILtd5DI6Sl3LKtc5kf2Nhe4+0Fo4gho9hndcxW7kVfQY4lr08a4h7zmL6dy9I2/LOj8XXOu36KpG1y9HLXS8P06maSiWbgqteOYaYL/wr31xpvTYrNcKxXDpP1X754YXd2sFB1E5Zw7vgSR2QFJ4ESMIVbWrv0gxg6Py4wjs4TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bky9xrGB; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a4715d4c2cbso810903266b.1 for ; Wed, 27 Mar 2024 00:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711526289; x=1712131089; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TDy5Illrx70H+5XvK63d5lpudD3g0VrV2VxsSwir7fI=; b=bky9xrGBNrfAkhg94g5H1u4pD7IqEDFi9mCnPvfnoXbHGRxw78DK3o1tBOpZuWBApd faaMRakLX79o71Vz8dzusuZ02cfxpMp4B7sGgmoJjvTxxu2XF6bQZma0gcU1EkyWhV0v IqB927ZYr+sz3ZTE7J+PnIQmKpDNiAUUeCqOzTWOwiQ305ZvbbnbgJtlT+D1OEuSKN5x IAgRzhWu/pEqFXPV6029rCr1ilkJp2s552UWlfmzDIQK89rZt9scULBjgqZtRY+3U6yQ D2U1cCjQgrRvwf+M6/5rqDI7MpPdG8n6HKViDz7h8fDo97mpOdFXHC28HRZQU/1NTmSt 3VJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711526289; x=1712131089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TDy5Illrx70H+5XvK63d5lpudD3g0VrV2VxsSwir7fI=; b=ennDNN17pbcLF0ggq6gLK9FykfDvDGrVkjaq3eaFtYhDUJ2zxPeqydJZBW1UutOASa GYFV09lT6qfr72II9AflhFCU+n1RlmipY+J3SAZlmVfXwfYI2LBBXI+/QmpP3jCZ4sQc 5jDvbEEW4TfDUa69Oh1M2ROQUCz6kusmRo8jaCRH8djGU26NwHfftKs275YbdNdNcSAE U2A7NIrXalkN5qIVRkuhga6SIYJ9s/4xVHGQ2LySkML8t0roPpXTC+59TymdJ1MTolbA XCbEec2D5WTxz13Zr3UUrKvAeCPL4eZBa5XaDjwIu/xhQGccPdH8rPaPeox/QNqbPVvD WVoA== X-Forwarded-Encrypted: i=1; AJvYcCVw/PFZtdBPknUzHqmuEe8wIr5RLpu2HBkZt3fNfGurLd4eccEstyphZF/pSmtqCMuX01zGHn2/uAFUFkE624rBaEWR3452koi7IniR X-Gm-Message-State: AOJu0YxsIHJOEd5ZyM41m/P3ClWIrvbwhNYG626+ikebVURUl8FCgk+/ LpPU7Up0VAu4MlVHX0tSXyIJ/kAKqNHIZj2b2/n4aQk6xfNfkL6+yAlyg47OrN8= X-Received: by 2002:a17:906:3c8:b0:a4d:fc15:4e36 with SMTP id c8-20020a17090603c800b00a4dfc154e36mr1365984eja.16.1711526288645; Wed, 27 Mar 2024 00:58:08 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id kz18-20020a17090777d200b00a46bdc6278csm5050261ejc.71.2024.03.27.00.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 00:58:08 -0700 (PDT) Date: Wed, 27 Mar 2024 10:58:03 +0300 From: Dan Carpenter To: Prabhakar Cc: Geert Uytterhoeven , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fabrizio Castro , Lad Prabhakar Subject: Re: [RFC PATCH 07/13] pinctrl: renesas: pinctrl-rzg2l: Validate power registers for SD and ETH Message-ID: References: <20240326222844.1422948-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240326222844.1422948-8-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326222844.1422948-8-prabhakar.mahadev-lad.rj@bp.renesas.com> On Tue, Mar 26, 2024 at 10:28:38PM +0000, Prabhakar wrote: > From: Lad Prabhakar > > On RZ/V2H(P) SoC, the power registers for SD and ETH do not exist, > resulting in invalid register offsets. Ensure that the register offsets > are valid before any read/write operations are performed. If the power ^^^^^^^^^^^^ > registers are not available, both SD and ETH will be set to -EINVAL. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Where does this happen? It doesn't seem to be a part of this patchset. -EINVAL seems weird here, but it's hard to judge without actually seeing it. regards, dan carpenter