Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp191957lqe; Wed, 27 Mar 2024 03:00:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWo7zTHT+ssHQJtEys9jQ4m/WOLfnuIZPcZfcykzGCXSgNw2+ZmFgQ8s1rffrbkJkKMvT0FCMbKqjHt9VTEPxitKv/dwrwi4viVQVraIw== X-Google-Smtp-Source: AGHT+IGXngkXHYWo7BXLU+1CTrzJroQHg3z9WQSi4xSWasTbgGn835VpcpDKk3iwIsJainuGIUhU X-Received: by 2002:a17:906:6c99:b0:a46:61e0:d99 with SMTP id s25-20020a1709066c9900b00a4661e00d99mr662240ejr.54.1711533623819; Wed, 27 Mar 2024 03:00:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711533623; cv=pass; d=google.com; s=arc-20160816; b=dF+z7Nqj3rrAirlJ83eIUVxlXBvFqx0lzJ28vYNOQ44o5Kzoz/4kbtMcaVU188wgBf IZQK76hfl185pr/ud7P6fjVHtYFZUCn6OEmxpykl+R9sDEkqmP0kkpC6jxDZFW8/vYng 3fbze0Ks2LZbvymUmDuH50c+cLbj1Q2/kvW7Ge9ct8z5YNNWzsrYDFbvPc0eRpdlJDZb MOVTaAFE+ezC9JkuFMhkAnzgEwPGw0O/kx2o3iSC7jQ34dVunqhV79BROZE2MOttBG0H tTSOQ9Y6P90Psy0t/Er/l7vf4hvZkMEp1+t1qLH5JU9Iuy30QeVdsG6aHqjQsjYjOCLN OxQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=MoBrVSCCzORNlcYamECHwS9FzN3bIfKWERYKgpRsWGA=; fh=5s4l4GDzydZ/wNQiaVrKermG3tyUGytDz9WAMZXeMC8=; b=V3Ll3HbQ0zBeV+to+vE3nbguu9Xc7IlqLx8zjDEaI1mDSn997ufb/zJtUxa9jQxo2V gNSoGxl9NKqlJu1nQ2AFytGejCnRYZMCmtSvwHKJ7sLK5r2ZabOJO/f7rvgcShiX9bT5 zcX6ixsHQKN15ty8hbptOwdgteEwuDzkLy0dwZIS9Q7h1hq/kRxwZ5QK/BWWbllSUCTs 7fxj9QrcEuWVkTW1p3y8ISDU9CtzN3ButO3n/+D6zrk2ompvczE9ZPM9mD0IWtYmSXpX rWMEa2UuZWwJl7zSwtGwW43gee7sxhi45Yjbux5EEFYLPt44ZPI/ZwOewz6JONWjCUuI eN+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fzhwRqSP; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-120642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lx2-20020a170906af0200b00a4a389e3777si2528292ejb.223.2024.03.27.03.00.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 03:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fzhwRqSP; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-120642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120642-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 69F2B1F2A7BA for ; Wed, 27 Mar 2024 10:00:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 19E9447F4B; Wed, 27 Mar 2024 09:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fzhwRqSP" Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34FC31401F for ; Wed, 27 Mar 2024 09:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711533597; cv=none; b=ozIis1DQ13+RnZVdxArLA7VKsdiXK1+dmvkSyjt6DHwR/n4mdD/+KxFjRhd/Vm5Bj4EUH8vvuRThDjJC+iFXwMgidRqmQCSiBzr3ewzOjY9EIr84crECvjFuIDl8J74IxqTK8m/URLhmKSDEZPrQf2zUKm3zQ6lewmsXmXRplt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711533597; c=relaxed/simple; bh=0YlEp1cs2nZL2D7/SETxSHgWEPK4YDbzPsXmPajn1zk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a9NqpLD2HF88tq4GAeAPxXTQYFxzU/U7PC8TeVXjASvdEyckCCDsFSvtgIzH5fCMS4DSnpdWXrICWHMcamopSL7P/AAKmlsuRp3Sv/mPuMARtVkHZh6hQLButh73fkysvsmRwMfvVfwwWqnUI/uO5/scRuFNJXq4z1Eg+KhQasg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fzhwRqSP; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a4a3a5e47baso386823166b.2 for ; Wed, 27 Mar 2024 02:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711533593; x=1712138393; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=MoBrVSCCzORNlcYamECHwS9FzN3bIfKWERYKgpRsWGA=; b=fzhwRqSPNYDHtlU+aDDRnaRB3WUF08INh+oOYhDFtH0XMhnOcj06Kj5/vNj+gbVtaY vZLpqoQHkIMmDbv5MzkB4rg/kZUNqyoXuXwzxli2Y6YYSrtVOqB/Wnnl9lS/vTH6X1Qk fkZcVTu93BGLRPior0xeaaEoTwHVkVxHHRb33PUf27ngGnUzEn1jgtbSqZfELmlRes6Q mnQX7wG/X2zlLGTOXYiIWDiJBfVbjSXDP/4K4q0Thu3o69Joz+BP6exBN+BZJo6VW9fU 4Dge8RA41uq24Vffryrcpl/lNfH58/nhnNc6Yd04H6vWAUxnajNhHmtQbtX7ZqXWtzve x3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711533593; x=1712138393; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MoBrVSCCzORNlcYamECHwS9FzN3bIfKWERYKgpRsWGA=; b=PCSqnYgbw50FOurJUk3gr0lxSbpEDmj5jr7SORY8NHIsIfw8ISUR+MynrMBKP5zUwr VYWetLxie9EJRSCsUqaeLQABvzyEjEZ+mxJyzzp8a/M4HE56HpEBjEUL5vixC+7kibEw 0jYAy53ozc9nEFi4Gv6s48UWJMhbMX60AwPodqPh0A0gWHXtod/TZCIgglnVFWwmGIC0 24JaLk+N2D2T7Su2uGy7ge8ydWsqFiK5UUERZx90916+wGlw5WKbQhY3Sl+iqW39ygE5 YYWiTQfACmvHeQ3e8OvHZ6eGREEVVRhDDix+AIEShtAcPtKhE5dknDqtSt1n5/rSO/Hn v/Sg== X-Gm-Message-State: AOJu0Yz+1klRT1xPCNpuFIKR8bahUAYe0Nt3G+28rdwsXRA4msvsaZvx LRzGZdR7DQ8chTSozBmGr0UWBB6qo8XLdNyZQbKhCAguoNWpDAELu3oD5o1y2Vc= X-Received: by 2002:a17:906:798:b0:a4a:3441:2e2a with SMTP id l24-20020a170906079800b00a4a34412e2amr582078ejc.55.1711533593476; Wed, 27 Mar 2024 02:59:53 -0700 (PDT) Received: from [192.168.1.20] ([178.197.206.205]) by smtp.gmail.com with ESMTPSA id du1-20020a17090772c100b00a4da28f42f1sm2371128ejc.177.2024.03.27.02.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 02:59:52 -0700 (PDT) Message-ID: <7ff9c4c7-3b56-4a5b-95b7-c37cbf8bcd6d@linaro.org> Date: Wed, 27 Mar 2024 10:59:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] dt-bindings: power: Add mediatek larb definition To: =?UTF-8?B?WXUtY2hhbmcgTGVlICjmnY7nprnnkosp?= , =?UTF-8?B?TWFuZHlKSCBMaXUgKOWKieS6uuWDlik=?= , "conor+dt@kernel.org" , "robh@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "ulf.hansson@linaro.org" , "angelogioacchino.delregno@collabora.com" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , Project_Global_Chrome_Upstream_Group , =?UTF-8?B?WGl1ZmVuZyBMaSAo5p2O56eA5bOwKQ==?= , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?RmFuIENoZW4gKOmZs+WHoSk=?= References: <20240327055732.28198-1-yu-chang.lee@mediatek.com> <20240327055732.28198-3-yu-chang.lee@mediatek.com> <6dd9959e-f741-47af-b10a-1894f72ae78f@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/03/2024 10:34, Yu-chang Lee (李禹璋) wrote: > On Wed, 2024-03-27 at 10:23 +0100, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 27/03/2024 09:39, Krzysztof Kozlowski wrote: >>> On 27/03/2024 06:57, yu-chang.lee wrote: >>>> Add Smart Multimedia Interface Local Arbiter to mediatek >>>> power domain. >>>> >>>> Signed-off-by: yu-chang.lee >>>> --- >>>> .../devicetree/bindings/power/mediatek,power-controller.yaml | 4 >> ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git >> a/Documentation/devicetree/bindings/power/mediatek,power- >> controller.yaml >> b/Documentation/devicetree/bindings/power/mediatek,power- >> controller.yaml >>>> index 8985e2df8a56..228c0dec5253 100644 >>>> --- a/Documentation/devicetree/bindings/power/mediatek,power- >> controller.yaml >>>> +++ b/Documentation/devicetree/bindings/power/mediatek,power- >> controller.yaml >>>> @@ -125,6 +125,10 @@ $defs: >>>> $ref: /schemas/types.yaml#/definitions/phandle >>>> description: phandle to the device containing the SMI >> register range. >>>> >>>> + mediatek,larb: >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>> + description: phandle to the device containing the LARB >> register range. >>> >>> Why do you need it? >>> >>> Plus I also see mediatek,larbs and mediatek,larb-id... so now we >> have >>> third one similar. >> >> ... and not even tested! >> >> Best regards, >> Krzysztof >> > Hi, > > I will double check the format of yaml for the next version, sorry for > inconvenience. But I did test it on mt8188 chromebook, the reason why How do you test a binding on chromebook? > power domain need larb node is that when mtcmos power on, signal glitch > may produce. Power domain driver must reset larb when this happen to > prevent dummy transaction on bus. That why I need larb node in dts. No one talks here about larb node... Best regards, Krzysztof