Received-SPF: pass (google.com: domain of linux-kernel+bounces-120645-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a84dd52c7ff74f9c8b84ba2ce2f0a9c2c3f20dae.camel@irl.hu>
Subject: Re: [PATCH v1 7/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver
From: Gergo Koteles <soyer@irl.hu>
To: Baojun Xu <baojun.xu@ti.com>, tiwai@suse.de
Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
  lgirdwood@gmail.com, perex@perex.cz,
  pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
  13916275206@139.com, alsa-devel@alsa-project.org,
  linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
  yung-chuan.liao@linux.intel.com, broonie@kernel.org
Date: Wed, 27 Mar 2024 11:02:37 +0100
In-Reply-To: <20240326010905.2147-7-baojun.xu@ti.com>
References: <20240326010905.2147-1-baojun.xu@ti.com>
	 <20240326010905.2147-7-baojun.xu@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Baojun,

On Tue, 2024-03-26 at 09:09 +0800, Baojun Xu wrote:
> Firmware binary load lib code for tas2781 spi driver.
>=20
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
> ---
>  sound/pci/hda/tas2781_spi_fwlib.c | 2374 +++++++++++++++++++++++++++++
>  1 file changed, 2374 insertions(+)
>  create mode 100644 sound/pci/hda/tas2781_spi_fwlib.c
>=20

Is this firmware loading logic the same as the already merged tas2781-
fmwlib? If yes, why don't you use that?

Thanks,
Gergo