Received: by 2002:ab2:23c8:0:b0:1f2:fdbc:cb93 with SMTP id a8csp204679lqe; Wed, 27 Mar 2024 03:25:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVxGtjI3cInAGv05s+E4URQc1wldo+hIdDEfnKScgN6jvVuDUpzC3I4o0OTrfgnPCopHeGjmcaiP27bZUUCpVCgiR12bv3U/gsMaqi82g== X-Google-Smtp-Source: AGHT+IGCMBbdOtxUj/ZmonRXHY2i7zXpe6rJLo7oDWQ24RDDpwe0falQOJYDBliOGwyPnrN/m8KQ X-Received: by 2002:a17:906:43c5:b0:a4d:f9b1:6e7e with SMTP id j5-20020a17090643c500b00a4df9b16e7emr1577436ejn.27.1711535142471; Wed, 27 Mar 2024 03:25:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711535142; cv=pass; d=google.com; s=arc-20160816; b=xWcPzudYRha/XoIIDt9qlyppnHz/EEWYDVVZ/nJFjA42/7ueCdvAxICGUSh+UcePXS ZB++xx58qc2ncF0+tcumY962yRAf7CIG6lhq+eqfKi2JSvjnx4S29w910uPTOPplJLJr b+0a3KIpXzuZpSSBLoSn2O8QqTlHdW5rwl3/YDIdBJAqJ/5FyL9ZKXmbPdY8U+KgLcfH LBSV0hTpbIKMir0N5TqiGieoiyqOzEoANAEhi+N1BtzF8OxYBAOioPJ/EvSDrtLErLiX jkufO2ZRsXcHYlkW7rRucx7RrCcJayMnNNliZxtnwHpPxHo58QIpDAXN8siElP1omPcx VmoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=/AkKqHDoToHVeJHWi3Rlrg9RTE/Xa/qdhkLZfkTRhEs=; fh=XkRLTcq3wSFSKLR36CbR4l8fE44gS81LwsN8fpmjobo=; b=WBfXJfAJYIWSnNxEmoldr1F+VAFoSPqAjt+91TcmEVg2J+GNdcSmuBDumwlz+taO0Z JmNznZ0E0lzAcIkKrsp3XNbuJi24GBej3tICpwRwV8vdCVi03pofqCIgKSyg9IeCckKU MfkkfcEIZeYMW0x6WCYF+gBZ1Tp17GUaKgqdcHN/caM6UokIXvyf7na+GOil+FH3LXol 7syNgAmi82fAJUU/+GNvnX2y3eiYqK9ZmA5upN6LE2jWgKPVpuYm7HM9Uqbw3bhXlwhD yUScQ3CRfI/bWefNjhAHxqoYWs0D4+GNVTACR1DL7eTRQCfyc7raV4lOGQ/UFGl4uQ4n X49w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FwWQbeBu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FwWQbeBu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-120663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120663-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i14-20020a1709064fce00b00a4df683614asi1508809ejw.615.2024.03.27.03.25.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 03:25:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-120663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FwWQbeBu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FwWQbeBu; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-120663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-120663-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 36CF01F29B10 for ; Wed, 27 Mar 2024 10:25:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AD244AEF7; Wed, 27 Mar 2024 10:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="FwWQbeBu"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="fqycNERe"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="FwWQbeBu"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="fqycNERe" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1E028DD3; Wed, 27 Mar 2024 10:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711535135; cv=none; b=Q1qKyhh478xGUCqLbuzPbFbRSisaR6CMd3K1snKvzwvVREc6O4iGhDtsJrwVI1WLzMesGzbSEviw3c3BaaCQgDtNogXY5mnJD/VrCdM3Qr+S+bQ5MdogT2TdMzqjffXKuCVcBJB/+DfbyhCm9R/O9PTG+A6MBOw61re730hLKH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711535135; c=relaxed/simple; bh=0e2xfwb4U2fZ5mQQeSTGhasWsRxBW8LMen2Dviag7co=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=YL1nIhw4esbKDa2O6H2Tz2Bnq5GW2R0ckrDDOC3MYZpiyiNoMmxIFpBaOqnPwn2KsKeHIHp/EStAmrcV/GC+dBCWRZgz8kiuMHsPEWPj0hbuHM+oAPhgUqI3Q68On0r3NaGOvn3JTRQH4ty2QrFWY7qR49P6N7GNSj9ljZMtbYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=FwWQbeBu; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=fqycNERe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=FwWQbeBu; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=fqycNERe; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CEF59383BC; Wed, 27 Mar 2024 10:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711535131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AkKqHDoToHVeJHWi3Rlrg9RTE/Xa/qdhkLZfkTRhEs=; b=FwWQbeBu+jNh1KgAazBTY2eynypTX7882xhyrUyYy2h23a5I/AQsdGpN+lhrubcyKbeBSF Zv4x3bnYWFaH8b3wOO/OaYVRFjn5aAGj/jOJ2DiluOKYdc3RI10nL4QnjBZnhfdU+fBbK/ lMveg3Mbc1HVuJArUmRXjkljhkx2Apc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711535131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AkKqHDoToHVeJHWi3Rlrg9RTE/Xa/qdhkLZfkTRhEs=; b=fqycNEReW9SYIVyZliwWgZ11xC8NN9G6smTEkaAZxpF30up457SWgKj1GzyI2Z+jlsNMOm VOGCYR3Xu/A7BPDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711535131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AkKqHDoToHVeJHWi3Rlrg9RTE/Xa/qdhkLZfkTRhEs=; b=FwWQbeBu+jNh1KgAazBTY2eynypTX7882xhyrUyYy2h23a5I/AQsdGpN+lhrubcyKbeBSF Zv4x3bnYWFaH8b3wOO/OaYVRFjn5aAGj/jOJ2DiluOKYdc3RI10nL4QnjBZnhfdU+fBbK/ lMveg3Mbc1HVuJArUmRXjkljhkx2Apc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711535131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AkKqHDoToHVeJHWi3Rlrg9RTE/Xa/qdhkLZfkTRhEs=; b=fqycNEReW9SYIVyZliwWgZ11xC8NN9G6smTEkaAZxpF30up457SWgKj1GzyI2Z+jlsNMOm VOGCYR3Xu/A7BPDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76B1A1369F; Wed, 27 Mar 2024 10:25:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id J6ZxGxv0A2afJQAAD6G6ig (envelope-from ); Wed, 27 Mar 2024 10:25:31 +0000 Date: Wed, 27 Mar 2024 11:25:33 +0100 Message-ID: <87edbw7yzm.wl-tiwai@suse.de> From: Takashi Iwai To: Gergo Koteles Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] ALSA: hda/tas2781: fixes for 6.9-rc1 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.34 X-Spamd-Result: default: False [-0.34 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.04)[57.58%] X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Spam-Flag: NO On Tue, 26 Mar 2024 17:18:44 +0100, Gergo Koteles wrote: > > Hi, > > This series removes the no longer needed digital gain kcontrol, which > caused problems in tas2563, because the register does not exists there. > > This series also adds locking and debug statements to the other > kcontrols. They sometimes ran in parallel with tasdev_fw_ready, and > caused weird sound problems. > https://github.com/tomsom/yoga-linux/issues/58 > > Regards, > Gergo > > Changes in v2: > - Do not remove dvc_tlv scale from tas2781-tlv.h as it is also used by > sound/soc/codecs/tas2781-i2c.c > - Add kcontrol name to debug statements > - Add a new patch to remove a useless debug statement. > > [1]: https://lore.kernel.org/all/cover.1711401621.git.soyer@irl.hu/ > > Gergo Koteles (4): > ALSA: hda/tas2781: remove digital gain kcontrol > ALSA: hda/tas2781: add locks to kcontrols > ALSA: hda/tas2781: add debug statements to kcontrols > ALSA: hda/tas2781: remove useless dev_dbg from playback_hook Applied now. Thanks. Takashi