Received-SPF: pass (google.com: domain of linux-kernel+bounces-120755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID:
 <MA0P287MB2822B846CE45D0A97D120725FE342@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 27 Mar 2024 19:32:50 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v12 2/5] dt-bindings: clock: sophgo: add RP gate clocks
 for SG2042
To: Chen Wang <unicornxw@gmail.com>, aou@eecs.berkeley.edu,
 chao.wei@sophgo.com, conor@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 mturquette@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com,
 richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
 devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org,
 jszhang@kernel.org, inochiama@outlook.com, samuel.holland@sifive.com
Cc: Rob Herring <robh@kernel.org>
References: <cover.1711527932.git.unicorn_wang@outlook.com>
 <78ddd5b127860e110f4c782de90025153cdba083.1711527932.git.unicorn_wang@outlook.com>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <78ddd5b127860e110f4c782de90025153cdba083.1711527932.git.unicorn_wang@outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN2P287MB0537:EE_
X-MS-Office365-Filtering-Correlation-Id: 652a7bfe-7cf7-48d3-b279-08dc4e51a576
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5xoukYaQ+76rmitZx5xRZEtyvZxlRXRRndxjmvmsupIPva9Jenz223Yo8fLQLUmerl2TboUI8U+azR4MEr7SeJwPmmyHNcKAiIZjZP9mxOZ2RsG+OnVuw2AqyPU1EZRuxGWYo53CUjDYB9JIGxTw02eOf08Ad+UaAkcDvDmCg2bezeBsoDEX2l+QMTkPOnTyDci5NcsVpwMB0pvc9OhIOIyN0DYz0mo7+LNwwWyC3GHHzUHIHdqBpTe9b1PPiLJaRJtwfddlIStyz1ARb4zr3A9SVx7NPS6G29e6hmwO5QnnNcX1CpdwmPzJmAOf5bAssY/JJIw0hNgJmA9B4YA1d+j1B7RKkMA8opCWsPfxQRtS98mrkaqRSRS1f+ftTXRnycWBSbF+5QvAlfxKyai3er79S1owaWV+aBXEyWfvUEBgqP79ByDAo4xbLELa65nze1A0kutCxgQy1OPjqtwgqUyzmnG+slPC8xW10kkNEOxvcq5kMRrC2iRD2XyjF1ERkTRLtcv6zppHb37chTybxEVWvlMeBX7jAzwi7YZb9GD2bNREffP1U3ZzglWbmBYOAtBC+6GWgiKQ3xiC6CIMwPTrTfRsia3g3dw9MKxQ/zZTLVgcbg1CDgcykRqwY8Pn58np1x3My5ioBQj/6YLeobyIlbrQxcGb76uJIe4EVDM=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnl2dElSTzl6dCtrOWh4YkZoSVFJUFRSOU9XQ3AvdjNZM0xxZHdLeGJaOVlt?=
 =?utf-8?B?TUtmamhPRENmTndjTjZpS05PV3hTQUJuTUpHVUVYeVpyMXphRUtkMHBNUGxD?=
 =?utf-8?B?dDM1Z1l0d1l5VXBqWThwRmtTN3BRSjlvd28rUVhWd0hxL0Y2MzRMWElmN0Vv?=
 =?utf-8?B?MldRM0tBK1BlaWNCUWpxY2NBamZnT3hMZUhXcjVTdVRTblV1ZFJTSy95SWVn?=
 =?utf-8?B?MU16UDNPS0RWcHVqNm1RVUJHd0k2S1FNVytySGIxU0Vad0ZadzN6Nkp0d1dV?=
 =?utf-8?B?M3hDbDZEWkg5TVd0c0VHV082Z3RVQ05wa3lnZFlIQU5rV3hyYU41RExDZ0l5?=
 =?utf-8?B?b0Zvd3p6RlBNMHoySXVFbFJJSFVjRmhGbkJKbEVCam8zWGZ1UnlZSmRnaC9k?=
 =?utf-8?B?K2xTSnJnc3ZCQ08xaEtYY2EvcTM4bGVFb3ZqOEdPNVpWVFRocW5pUkdnamFa?=
 =?utf-8?B?OXBYeWtnU3I3MGtsUHl5UUZnckpGcmZyZHRZbmk3RTU5eDR5MDVWMW1lNVRU?=
 =?utf-8?B?NFlEVS9FWFVSR1FudnROVlFZMUNzYlZ2NzdkMVk3TGRQbnM1cFgxOUdIUnYr?=
 =?utf-8?B?S3BRdkR3Y0g1UDVCd1lYWlN1Zi9jc0dJRjBqcWsxcStna2I5TnY5bE5pL1FG?=
 =?utf-8?B?RERTckRUL0hPUWdkcEpIckRibW50bCtrcHVIeGlMcFBCSUQzSVVwd21ZSE9G?=
 =?utf-8?B?eVpuVTI2ZHF3dzRJc3U0cVU3Uy8rNWZ0SktGYWtWaHBKSTY0SHgrakFjWWVp?=
 =?utf-8?B?Q3psMnBHTkxVcTNTelhBSnB0ME53cEV1ZmZhYmdiOTV6WnhjdDduc3laZEZG?=
 =?utf-8?B?WEJXNzk2Z1VOSVdtUkxpTitjNnYrZ2J2NktpYUxFTWVyMHR0Y3JkdjQrT0Mv?=
 =?utf-8?B?T3FxNjZNTkhMeTF0eE93dEttVmhKZTFmR3NiYTZRSjVxelhzQW1MbkpIQXdn?=
 =?utf-8?B?RjdMZ05mY0QvQzQ4ME01dTlDdStvVVBOTmh6YlJGUVNsa2REbGJiVFdJWDJz?=
 =?utf-8?B?N1MraUJvTzhGdVFPU0RlMjFtYU1NME8vWDdkSkw3cXBzNzZFYmQzUXA2S08v?=
 =?utf-8?B?eUZ3aEZLTW5FalVRTVFTaFYyNTF3dlNaLzRWbmhUNEFiTzRuTmg1RCtDUTND?=
 =?utf-8?B?TUF3a3lMbWw0ZVRqaDVBTldzdnUxU2tINkVLT1B2VVNLL3RNSE0zZnpvd2VM?=
 =?utf-8?B?RGNiNE0rakJmS0QvWitxT2RrQUR1WGViS0dwcXZQbzZseE5FOGttWVRQUDMz?=
 =?utf-8?B?Z2NGUXNnVm9TZ0xManltYWJCV2hPTG5NenNMUWpzclNOK01yQ0tuMEZneFJq?=
 =?utf-8?B?U2pTcTBXb1lGVFlkOFhaMlkwUDRrSHFuNnU4U29BTUJGRHBxS1NvV0tlQWsr?=
 =?utf-8?B?aUowV2lSZVNsSmxSczNydTRCam5sbXR3WVlIKzA1a0phRTQrVW54d2hSM1k1?=
 =?utf-8?B?dnp3KzBtd1dUQ2IyeGdMd3I0TGU4YWE1emhESnZaWkszRmZWRjc5WXRPc2Ft?=
 =?utf-8?B?L0xNa2FoL1RzVVh1ZGRDaThpSklBd045bXZja1FYaXVsWnVLNVkxbEUxSUhj?=
 =?utf-8?B?NGN3Rk5sWUtDeGVVOWc0Ty9OWW9hQmZWR2FmbUJwSU5mUGdRZ2VEWktLZmNv?=
 =?utf-8?B?TUZGS2p0KzNoRzlUM2dkN1BPZ3hYQnd3dzR5VXZXUmx6MDdwK0NiZTZJOUNu?=
 =?utf-8?Q?CRxxTw5wI8om4VtCvROt?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 652a7bfe-7cf7-48d3-b279-08dc4e51a576
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 11:32:55.8092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2P287MB0537

hi, Stephen,

I updated the address in the example of this bindings as per your input 
from 
https://lore.kernel.org/linux-riscv/066c6fa4b537561ae6b20388a5497d9e.sboyd@kernel.org/.

I checked the 
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/log/?h=clk-next 
and seems you have not picked the 3 bindings patches, so please use v12 
when you pick them.

Thanks, Chen

On 2024/3/27 16:30, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> Add bindings for the gate clocks of RP subsystem for Sophgo SG2042.
>
> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>   .../bindings/clock/sophgo,sg2042-rpgate.yaml  | 43 ++++++++++++++
>   .../dt-bindings/clock/sophgo,sg2042-rpgate.h  | 58 +++++++++++++++++++
>   2 files changed, 101 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
>   create mode 100644 include/dt-bindings/clock/sophgo,sg2042-rpgate.h
>
> diff --git a/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml b/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
> new file mode 100644
> index 000000000000..9a58038b3182
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sophgo,sg2042-rpgate.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/sophgo,sg2042-rpgate.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo SG2042 Gate Clock Generator for RP(riscv processors) subsystem
> +
> +maintainers:
> +  - Chen Wang <unicorn_wang@outlook.com>
> +
> +properties:
> +  compatible:
> +    const: sophgo,sg2042-rpgate
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Gate clock for RP subsystem
> +
> +  '#clock-cells':
> +    const: 1
> +    description:
> +      See <dt-bindings/clock/sophgo,sg2042-rpgate.h> for valid indices.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock-controller@20000000 {
> +      compatible = "sophgo,sg2042-rpgate";
> +      reg = <0x20000000 0x10000>;
> +      clocks = <&clkgen 85>;
> +      #clock-cells = <1>;
> +    };
> diff --git a/include/dt-bindings/clock/sophgo,sg2042-rpgate.h b/include/dt-bindings/clock/sophgo,sg2042-rpgate.h
> new file mode 100644
> index 000000000000..8b4522d5f559
> --- /dev/null
> +++ b/include/dt-bindings/clock/sophgo,sg2042-rpgate.h
> @@ -0,0 +1,58 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> +/*
> + * Copyright (C) 2023 Sophgo Technology Inc. All rights reserved.
> + */
> +
> +#ifndef __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__
> +#define __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__
> +
> +#define GATE_CLK_RXU0			0
> +#define GATE_CLK_RXU1			1
> +#define GATE_CLK_RXU2			2
> +#define GATE_CLK_RXU3			3
> +#define GATE_CLK_RXU4			4
> +#define GATE_CLK_RXU5			5
> +#define GATE_CLK_RXU6			6
> +#define GATE_CLK_RXU7			7
> +#define GATE_CLK_RXU8			8
> +#define GATE_CLK_RXU9			9
> +#define GATE_CLK_RXU10			10
> +#define GATE_CLK_RXU11			11
> +#define GATE_CLK_RXU12			12
> +#define GATE_CLK_RXU13			13
> +#define GATE_CLK_RXU14			14
> +#define GATE_CLK_RXU15			15
> +#define GATE_CLK_RXU16			16
> +#define GATE_CLK_RXU17			17
> +#define GATE_CLK_RXU18			18
> +#define GATE_CLK_RXU19			19
> +#define GATE_CLK_RXU20			20
> +#define GATE_CLK_RXU21			21
> +#define GATE_CLK_RXU22			22
> +#define GATE_CLK_RXU23			23
> +#define GATE_CLK_RXU24			24
> +#define GATE_CLK_RXU25			25
> +#define GATE_CLK_RXU26			26
> +#define GATE_CLK_RXU27			27
> +#define GATE_CLK_RXU28			28
> +#define GATE_CLK_RXU29			29
> +#define GATE_CLK_RXU30			30
> +#define GATE_CLK_RXU31			31
> +#define GATE_CLK_MP0			32
> +#define GATE_CLK_MP1			33
> +#define GATE_CLK_MP2			34
> +#define GATE_CLK_MP3			35
> +#define GATE_CLK_MP4			36
> +#define GATE_CLK_MP5			37
> +#define GATE_CLK_MP6			38
> +#define GATE_CLK_MP7			39
> +#define GATE_CLK_MP8			40
> +#define GATE_CLK_MP9			41
> +#define GATE_CLK_MP10			42
> +#define GATE_CLK_MP11			43
> +#define GATE_CLK_MP12			44
> +#define GATE_CLK_MP13			45
> +#define GATE_CLK_MP14			46
> +#define GATE_CLK_MP15			47
> +
> +#endif /* __DT_BINDINGS_SOPHGO_SG2042_RPGATE_H__ */