Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756536AbYARFHK (ORCPT ); Fri, 18 Jan 2008 00:07:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751057AbYARFG4 (ORCPT ); Fri, 18 Jan 2008 00:06:56 -0500 Received: from wa-out-1112.google.com ([209.85.146.177]:53850 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbYARFGz (ORCPT ); Fri, 18 Jan 2008 00:06:55 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=VAHylLcz7sWagy5yuCBeHafrFU5e99/S8GLpnjlHGviXqkfoeSKc6cKrlD94gs7w47brITaJSiPhKT0B/aKfiJyofI7vzkoBPkVKU1LLuAK4ns2kDT+d7MY9D8sxDsDwfn+fXOC1p8u/g09/3GtYEki7xucpd0e0X2yU2rplPm4= Message-ID: <661de9470801172106t61c702b8ue9610fe66362965a@mail.gmail.com> Date: Fri, 18 Jan 2008 10:36:54 +0530 From: "Balbir Singh" To: "Siddha, Suresh B" Subject: Re: 2.6.24-rc8-mm1 Cc: "Pallipadi, Venkatesh" , "Andrew Morton" , linux-kernel@vger.kernel.org, "Linux ACPI mailing list" , "Intel E/100 mailing list" , "Ingo Molnar" , "Thomas Gleixner" , andreas.herrmann3@amd.com In-Reply-To: <20080118014223.GB25389@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080117104021.25a8e562.akpm@linux-foundation.org> <924EFEDD5F540B4284297C4DC59F3DEE5E909A@orsmsx423.amr.corp.intel.com> <20080117230403.GA5411@balbir.in.ibm.com> <20080118014223.GB25389@linux-os.sc.intel.com> X-Google-Sender-Auth: 71ce9470c8eef83a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 49 On Jan 18, 2008 7:12 AM, Siddha, Suresh B wrote: > > On Thu, Jan 17, 2008 at 03:04:03PM -0800, Balbir Singh wrote: > > I think I found the root cause of the problem and a fix for it. > > The fix works for me. > > > > Thanks Balbir. But the appended fix is more clean and appropriate. Can you > please check if it works. > --- > > From Balbir Singh: > > > With the introduction of reserve_mattr() and free_mattr(), the ioremap* > > routines > > started exploiting it. The recent 2.6.24-rc8-mm1 kernel has a peculiar > > problem > > where in, certain devices disappear. In my case for example > > > > e100: Intel(R) PRO/100 Network Driver, 3. 5.23-k4-NAPI > > e100: Copyright(c) 1999-2006 Intel Corporation > > ACPI: PCI Interrupt 0000:04:08.0[A] -> GSI 20 (level, low) -> IRQ 20 > > modprobe:2584 conflicting cache attribute 50000000-50001000 > > uncached<->default > > e100: 0000:04:08.0: e100_probe: Cannot map device registers, aborting. > > ACPI: PCI interrupt for device 0000:04:08.0 disabled > > > > On further analysis, it was discovered that quirk_e100_interrupt() calls > > ioremap(), which reserves memory attributes for the e100 card, but > > iounmap() > > does not free it. > > Fix the iounmap() to call free_matrr() unconditionally. > > Signed-off-by: Suresh Siddha > > Signed-off-by: Balbir Singh Yes, it looks better. p->flags is always set, so the check was not doing much. I also tested it and it works for me! Tested-by: Balbir Singh Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/