Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp36117lqo; Wed, 27 Mar 2024 06:25:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVgg7ZiT+8MBvQs2YE/HIQM7HJ+me+TNobm3Or1YJFZz1UIiXj2cEEicZ0sP1dftOWAkY299IQD04mGTZyWUe/2t+Ibu+fJaW0de5n0iA== X-Google-Smtp-Source: AGHT+IGIbYugqr9Wf70ToeE6KerAAgzvSDgVPnsvjLRxyyadilS7az0B9AKBjqKEVOY4sCaHHO2u X-Received: by 2002:ac8:7d83:0:b0:431:5c20:f0cf with SMTP id c3-20020ac87d83000000b004315c20f0cfmr2596335qtd.6.1711545919920; Wed, 27 Mar 2024 06:25:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711545919; cv=pass; d=google.com; s=arc-20160816; b=vYZwhTsIHumCvU2mfxmwd6ieHFT4C2AOTysA3VsE5GpcWD6tgowpjk1KLtK1LA0YfX K95pJ65NkSfq9x3cpFb42rR7//4p/Z9NO6U+rqf8sq6cyF+D2KX9bijQpG7S2tyULaK4 X1vpsAtZddFmk/lrapK8idnTYW406TEHwsF2+8tYxUG2W/42LUmOSBg7O4kOgBydT3Um YdEOkRQcnYJ8IqUKw6dVgb+O23lwzQIJNsbSdI0W1YWV7FMDR+X4EIGtC+6H7pMoQO+z NI9lN5DQ1V4onm4IaOBq+UJ7OrTUx0WM/7na+osYIySal5Bz7K+GM4OIV+3qjgq0uxJB 8MYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=gZl0pkP4Xrj9rEybWrIF8jIBu3Whfb6eygqjOqTuUYw=; fh=VuAueRrQP1O5B5rab+so0sKFYfmW1qpq+AbQdYY0BwQ=; b=Wbz8B9d3FDZtoNKw1EyuslbIGFJQc/s1GyUGVEUFcRNITPCSp69rbRbeYlpn5SoQ4K ViuQA+U3m7XywsDk7vHhonwm4DqzTs1Mxaj3XIrUxtru8JoUUp3YLGwKwDwEt9YyrLOK r8JesqbWi6bmQMNuDuxd9BewXYC5GUNzDySPE+J1tY0jyUtowbOnRfRLXgOCW2C4hy8f n/YOPx0QGJXsi1vtGUSMfCJUsmlL0EoXChyIZPq4lqrtLf3dR1HFy1W9g/wLs0pUxbgi IEUajJcGF30V0Dzh+D7fQyIO7mVRI9LMWpvXHlLGWLuZCPxSnltOJtzG04VTEdZvlUA/ zy3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PHq9L0O5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f13-20020a05622a104d00b00431627d735asi5341280qte.548.2024.03.27.06.25.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 06:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PHq9L0O5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8428C1C2AB04 for ; Wed, 27 Mar 2024 13:25:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E63C1703AD; Wed, 27 Mar 2024 12:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PHq9L0O5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477B613B7A4; Wed, 27 Mar 2024 12:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542087; cv=none; b=RgyREQ/nopiTfIO/uXCCX+lustPy8K5VcD8a58fpWdMx//tRImO3GuVgzkp0DX2ikb0V8gvzzgLbOQd+gqatEvUaVFdKCNa07XyTabsNK7episY0aEvBazcSWFTQysCKXKW9LQb7cNCluibWRQYHqe3gbLE3bWVUcTphWcUYrFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542087; c=relaxed/simple; bh=i7LxVuQ3soT04MoMpPwzwpi44u034c9RglpD/f//odk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QQ1t3yCQ0IEqD+S/Wo+S6vAPnTdx7XCk1J0R2rmSfZQFpod/M+m7ifsqCm8LDDPOGHwUIusGfg4MpCbf40RhZX901L+WflROiJesiCZ7vVJI/U+/qyCuoH9+B15ml/Z9raRj+wgISlycvU1ybxWUZSdJZdrIDHM5Hux04yoUmeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PHq9L0O5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41D15C433F1; Wed, 27 Mar 2024 12:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711542087; bh=i7LxVuQ3soT04MoMpPwzwpi44u034c9RglpD/f//odk=; h=From:To:Cc:Subject:Date:From; b=PHq9L0O5eBNyyzS646Y26GghhTVKZJLS56b9O5cqJcKekMKBJELfSgWolXPjw2siu RpPGhetEzOUhYuZp2rc3CIEukJ9baX2qjtDhroUc+CeQ1Fedmo18Aw08ucS6PyAVBQ h2fOVtEoeldvgh1vCRydsJoiIeyePOTU1L6bvxcs65K0n8IZmmqy2ZuFjBA5JNSwG0 PaH0RpFj27Bs3zvsPQ+8oNDW2FUSbutlYqoVyf2sfwz+6nlVg8t9yVo1v+wKW6cgcf wyZuIXgfGfzvgo/PVLWyFbe3VyYY/l/V3LDgDyxXDMVulIF7HrYtKXzzZ9xn+rYaBj UAgxTVx8WvwOA== From: Sasha Levin To: stable@vger.kernel.org, willy@infradead.org Cc: Rik van Riel , Mel Gorman , Peter Zijlstra , Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org Subject: FAILED: Patch "bounds: support non-power-of-two CONFIG_NR_CPUS" failed to apply to 5.4-stable tree Date: Wed, 27 Mar 2024 08:21:25 -0400 Message-ID: <20240327122125.2836828-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ From f2d5dcb48f7ba9e3ff249d58fc1fa963d374e66a Mon Sep 17 00:00:00 2001 From: "Matthew Wilcox (Oracle)" Date: Tue, 10 Oct 2023 15:55:49 +0100 Subject: [PATCH] bounds: support non-power-of-two CONFIG_NR_CPUS ilog2() rounds down, so for example when PowerPC 85xx sets CONFIG_NR_CPUS to 24, we will only allocate 4 bits to store the number of CPUs instead of 5. Use bits_per() instead, which rounds up. Found by code inspection. The effect of this would probably be a misaccounting when doing NUMA balancing, so to a user, it would only be a performance penalty. The effects may be more wide-spread; it's hard to tell. Link: https://lkml.kernel.org/r/20231010145549.1244748-1-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) Fixes: 90572890d202 ("mm: numa: Change page last {nid,pid} into {cpu,pid}") Reviewed-by: Rik van Riel Acked-by: Mel Gorman Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Signed-off-by: Andrew Morton --- kernel/bounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bounds.c b/kernel/bounds.c index b529182e8b04f..c5a9fcd2d6228 100644 --- a/kernel/bounds.c +++ b/kernel/bounds.c @@ -19,7 +19,7 @@ int main(void) DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS); DEFINE(MAX_NR_ZONES, __MAX_NR_ZONES); #ifdef CONFIG_SMP - DEFINE(NR_CPUS_BITS, ilog2(CONFIG_NR_CPUS)); + DEFINE(NR_CPUS_BITS, bits_per(CONFIG_NR_CPUS)); #endif DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t)); #ifdef CONFIG_LRU_GEN -- 2.43.0