Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp51770lqo; Wed, 27 Mar 2024 06:48:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWw4/B+flioeGlUg6CHjLBE/XcdNOA8+fa8D+gE9BN9uShglHwXIO34xXXsNp0DaUcv2oVnxhv9qeCYU2sYrM9CzJWoCW8l7/FHBgGEQw== X-Google-Smtp-Source: AGHT+IHtoEmUhhrueh/eFXBKxuBw5AFRxqfN+npXeqWu0rdW56rMnRAo/1x2zKGL2ySzRfXVol2Z X-Received: by 2002:a17:907:9445:b0:a4e:df0:9d8 with SMTP id dl5-20020a170907944500b00a4e0df009d8mr440581ejc.48.1711547324415; Wed, 27 Mar 2024 06:48:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711547324; cv=pass; d=google.com; s=arc-20160816; b=BYyRBE5RI1KXP5jfv1nrUM2P33d/SjUuTZKDcnYOZsZIRkKAF+QGwvrKL9Bl4NzXvP MKEMdhfBm4Smt/3unbiUHfRv6h6hF/pujdPYWlpHvH2qmf5vzCbycga4YQWfkogEzOWK cpqrGTWJGp/hvqZkwb2KdUv6uc5ceQnGOPJo2ZD7oIejE9v5Qf3U2iEkHdyElXcPF4dS lW8AlVjym2Uz/AANXIgp3aLuKjHzsm2WNqLem/K9L0OJwleRouDhhTW8xnn4hYoEfNRM +TS/+M09wEJZExSNirWNwuNG8bDZxuwnJyQy9L3Oyn8HPmUIbS3j5Jr9KM3PB6efxJr0 Zotw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=gRYCClxof8Z/x5Y7mAdWY43FiiYhA0iARVad4Tt5RU8=; fh=VuAueRrQP1O5B5rab+so0sKFYfmW1qpq+AbQdYY0BwQ=; b=uk227RrlO3e8VHrrL/D8szgPqekk37nzZpMpGUTsDQ6MMhdSC4aRXo6BAbMMMlCSlb 87zSZ7sqSGZYlqtBie1lmGq6MbwBNR1ft/ZDnEf+rX4jT3PwPNVXbnEwXcgb2VOV+kBR yD5MjYFnHQTwBlI0o162Wuws/Y+/wpinDTBAX9uhA+G8+85xyJHGjRJFO4ar/dMNaD6b GarjcxbokfEBAfOESIyEnIG7byBQP/XklMsThoq5wMCPekXPRyBA5V8aCkQ6Ta0uRmB3 kYB/DBGysqspbg13RvnCcRlAbb9ex2gLd8IdR6U8BeuhPT82Zvw2e8+zXdIrfPPf8HIK jVFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYKbZNc1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121198-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121198-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id kt4-20020a170906aac400b00a466972e903si4771057ejb.891.2024.03.27.06.48.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 06:48:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121198-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYKbZNc1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121198-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121198-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2A9641F2E039 for ; Wed, 27 Mar 2024 13:48:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA14813F42F; Wed, 27 Mar 2024 12:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sYKbZNc1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEE4D1836E0; Wed, 27 Mar 2024 12:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542323; cv=none; b=p6gC08eN+UqkWNdFSdWa3w3uBV9ZpLK6BUYfvlaYCHPihwUScZTjlCRBAdyuSODnZs17XIutR4pZamNGlKn4kH1SZexgcSLTc6nJ+C/oTde3QSacGR07YFACrWl6ukRohv+ax9/cW+SSV2jWb9Tpx/SPSh86YQ7enYrk/xnKvIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542323; c=relaxed/simple; bh=fNuHaD+igTEh2V9ZsL9Jv5vHw8hQvqrYp0L7YbeWvnE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YcYJKbQCiTPDBFtC4xZR5XEL8gEhsmhbmetQbRqIkyZIfIn4tct5U99BTrT1Pfg60oIbm+wXjfFzrMEAr298BJYrMyyDB7mQ39Xn+Bx6GoAi3kPASQiSY6IJm9uAkHklAa3trKeU+gDuVNaS+b0IfsRdS1S1GW4yzP5p1nPkSOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sYKbZNc1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6DFDC43390; Wed, 27 Mar 2024 12:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711542322; bh=fNuHaD+igTEh2V9ZsL9Jv5vHw8hQvqrYp0L7YbeWvnE=; h=From:To:Cc:Subject:Date:From; b=sYKbZNc1kwYDu2T69h1K1DgDiNh8LAm4lixj4EGqle28s4RGMPNAj2WbyZnEBBf+y cAKsJoRP0caKO9GYA8ikSyvk0fvECNDsOJCphbz99M5D9HZhL9qJ+rokojp/wAxDoa C+hV06GpRf2ca6wqg8V30dYsWBqLN7NqRP6NMpcktN5lsgZNCw0bq+HJeyEXswELQu HlmwdpMN1E5QEAhONVEk6KlQlbFTpBggNk0A4igbzP/sXmMukXcAHKsjZSk1WXNdUw glpENrBH8pGmCDX1zVueRsCKXk6C0ycD0YN0EwTD5MhpQ+OC2yGGYeEo5F0bfJ0rt0 plD0vaMC5bp9A== From: Sasha Levin To: stable@vger.kernel.org, willy@infradead.org Cc: Rik van Riel , Mel Gorman , Peter Zijlstra , Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org Subject: FAILED: Patch "bounds: support non-power-of-two CONFIG_NR_CPUS" failed to apply to 4.19-stable tree Date: Wed, 27 Mar 2024 08:25:20 -0400 Message-ID: <20240327122521.2840152-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ From f2d5dcb48f7ba9e3ff249d58fc1fa963d374e66a Mon Sep 17 00:00:00 2001 From: "Matthew Wilcox (Oracle)" Date: Tue, 10 Oct 2023 15:55:49 +0100 Subject: [PATCH] bounds: support non-power-of-two CONFIG_NR_CPUS ilog2() rounds down, so for example when PowerPC 85xx sets CONFIG_NR_CPUS to 24, we will only allocate 4 bits to store the number of CPUs instead of 5. Use bits_per() instead, which rounds up. Found by code inspection. The effect of this would probably be a misaccounting when doing NUMA balancing, so to a user, it would only be a performance penalty. The effects may be more wide-spread; it's hard to tell. Link: https://lkml.kernel.org/r/20231010145549.1244748-1-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) Fixes: 90572890d202 ("mm: numa: Change page last {nid,pid} into {cpu,pid}") Reviewed-by: Rik van Riel Acked-by: Mel Gorman Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Signed-off-by: Andrew Morton --- kernel/bounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bounds.c b/kernel/bounds.c index b529182e8b04f..c5a9fcd2d6228 100644 --- a/kernel/bounds.c +++ b/kernel/bounds.c @@ -19,7 +19,7 @@ int main(void) DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS); DEFINE(MAX_NR_ZONES, __MAX_NR_ZONES); #ifdef CONFIG_SMP - DEFINE(NR_CPUS_BITS, ilog2(CONFIG_NR_CPUS)); + DEFINE(NR_CPUS_BITS, bits_per(CONFIG_NR_CPUS)); #endif DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t)); #ifdef CONFIG_LRU_GEN -- 2.43.0