Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp81397lqo; Wed, 27 Mar 2024 07:30:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX5mY5UKdHpIt4nzxPHtDJtj1D1SLjzySsUQX6I4CKvpKjOXE6+pHWLUCotsEnFY2f7uqHIZJZUru442ggEDZvFEORMydgzDSVUdTYToA== X-Google-Smtp-Source: AGHT+IGmtPhR8Gme5vanXD/qgij4X/dd7dvpMm5dNIhyGR8JW+qfOR3saUk3vAvC/iT3n8Gt8cJk X-Received: by 2002:a19:2d16:0:b0:513:5c68:9891 with SMTP id k22-20020a192d16000000b005135c689891mr1949859lfj.44.1711549828070; Wed, 27 Mar 2024 07:30:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711549828; cv=pass; d=google.com; s=arc-20160816; b=tsN6nq2UY+eok0/DdRhrPY9nvN/Nxt+XABDerLxAEnHjJOcjuUArFAHFYGGuY8anML DCF7h9EZGMn3RpFNPDgFJ3SNZ1ZzMeBUikpDhmumKXmljJIff+eP6FIjcFlB58rB6P81 SsxRWCrT4dAM9o3f/EAzVWx49SEQhPFGmpj5wg50JUz5MBRvMr5UsW7jZGJ8qvoXepD3 q7gmwrJaMU+fCcLGCD9ykRzYxCMU4QrwR2Kaiv8paUSZi1eNkSZ2379WSByWmtN6RLFZ rBhjHKvP6pS0DGWbyS/RODar9d+nLk6+zkDehrkJ2T+uJMkSLFqvhBg33XsjRLoCPdmA Ai7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=juagHBrCdF9hgGjxx5gSo6nd2Q08XD9tQ9kO3JMrqOk=; fh=xETd/IFrSJYTwXbK21b6KQVU3g+4fmBWRXFwDV5DiMc=; b=zwwgztOByN8Q5W8FJqkBBe7sLhbSG/m/5V0523hbDpXRhHzrZ4oCEqcJci+y5Nl7RP WVe7m18Er1BDOkgG21Q9KzDfF9vVUOWxDusAFcyZjB5b9oruHWXY+G/GPZfNKMOF3kFI cWndxFbIP0hzbJu2Okw6mG4HpCioCUUj7pH4QtOLtoNNSif/Zi6GDQFNDZrtyYyemQOB bixWiCwn8r7IPNi30Mo/SQQp8WmzxEB4xdfby5zqabFCHJ9jBwuEFDsnczv0TFRy2hAC jx4s1R9jjPFWfZdxinTTRSvBZGenbwefvHlql0+5SzoTHDkd9O/wQ4yiigxMOqP+LvUR zBmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-121324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qk37-20020a1709077fa500b00a474540f1besi4376759ejc.128.2024.03.27.07.30.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 07:30:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-121324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E95731F27F2A for ; Wed, 27 Mar 2024 14:30:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E1B3815217F; Wed, 27 Mar 2024 12:55:41 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF8EC12F37F; Wed, 27 Mar 2024 12:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711544141; cv=none; b=K6E2oLhunFnQvbQNSRXveswcGDCAFo+gPypiUctUEd9Fyi5MsHVqm0/7+IesB9avRbGiPIr3UyjloE+urt/AyEle9FDTY8ZmWoUGynGAdR08f53gQpOD2f9yOGR2bh18uNg4mcW+uvH2HEFUO3VC1IWCWCbvsoL4HtAeE5cCmmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711544141; c=relaxed/simple; bh=3K5FY9zYoZ9NIYrs8JeXAE2pagjbwPp+dZ93De3oyV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EK9zmRbNONZeGke3kZ1HaNlR6pkeGZsagmRjRX7c6yD3qbYeHbagALPCEYFJrquVd1AVQZDaSDxYNkAUjUeKgN1bJ7qhV6Lp2cNNCZsvK2lbi6xeSkqxnJB84EROndmZM8amMtff6lhKhdQwMsc91k9PH0EFy0so/SrbWvxZRxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27C1E2F4; Wed, 27 Mar 2024 05:56:12 -0700 (PDT) Received: from [192.168.178.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CD983F7C5; Wed, 27 Mar 2024 05:55:35 -0700 (PDT) Message-ID: <410c5da7-c79c-4607-9aa3-2e78d991d2d7@arm.com> Date: Wed, 27 Mar 2024 13:55:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND][PATCH v2 3/4] PM: EM: Add em_dev_update_chip_binning() Content-Language: en-US To: Lukasz Luba Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240322110850.77086-1-lukasz.luba@arm.com> <20240322110850.77086-4-lukasz.luba@arm.com> <30ee98e9-3d9a-4be8-8127-043f68a7dcb1@arm.com> From: Dietmar Eggemann In-Reply-To: <30ee98e9-3d9a-4be8-8127-043f68a7dcb1@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26/03/2024 21:32, Lukasz Luba wrote: > > > On 3/26/24 10:09, Dietmar Eggemann wrote: >> On 22/03/2024 12:08, Lukasz Luba wrote: [...] >>> +    return em_recalc_and_update(dev, pd, em_table); >>> +} >>> +EXPORT_SYMBOL_GPL(em_dev_update_chip_binning); >> >> In the previous version of 'chip-binning' you were using the new EM >> interface em_dev_compute_costs() (1) which is now replaced by >> em_recalc_and_update() -> em_compute_costs(). >> >> https://lkml.kernel.org/r/20231220110339.1065505-2-lukasz.luba@arm.com >> >> Which leaves (1) still unused. >> >> That was why my concern back then that we shouldn't introduce EM >> interfaces without a user: >> >> https://lkml.kernel.org/r/8fc499cf-fca1-4465-bff7-a93dfd36f3c8@arm.com >> >> What happens now with em_dev_compute_costs()? >> > > For now it's not used, but modules which will create new EMs > with custom power values will use it. When such a module have > e.g. 5 EMs for one PD and only switches on one of them, then > this em_dev_compute_costs() will be used at setup for those > 5 EMs. Later it won't be used. > I don't wanted to combine the registration of new EM with > the compute cost, because that will create overhead in the > switching to new EM code path. Now we have only ~3us, which > was the main goal. > > When our scmi-cpufreq get the support for EM update this > compute cost will be used there. OK, I see. I checked the reloadable EM test module and em_dev_compute_costs() is used there like you described it.