Received-SPF: pass (google.com: domain of linux-kernel+bounces-121326-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e02ca745-52df-4210-b175-f4ef278d81d8@arm.com>
Date: Wed, 27 Mar 2024 13:56:09 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RESEND][PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy
 Model after adjusting voltage
Content-Language: en-US
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com,
 linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org,
 rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
 alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org,
 linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
References: <20240322110850.77086-1-lukasz.luba@arm.com>
 <20240322110850.77086-5-lukasz.luba@arm.com>
 <59d37960-cf19-4b10-802f-59d42496c133@arm.com>
 <d5d6ae17-3ba1-4cb8-909f-865e47bfa45b@arm.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
In-Reply-To: <d5d6ae17-3ba1-4cb8-909f-865e47bfa45b@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 26/03/2024 21:12, Lukasz Luba wrote:
> Hi Dietmar,
> 
> On 3/26/24 11:20, Dietmar Eggemann wrote:
>> On 22/03/2024 12:08, Lukasz Luba wrote:
>>
>> [...]
>>
>>> @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct
>>> exynos_asv *asv)
>>>               last_opp_table = opp_table;
>>>                 ret = exynos_asv_update_cpu_opps(asv, cpu);
>>> -            if (ret < 0)
>>> +            if (!ret) {
>>> +                /*
>>> +                 * When the voltage for OPPs successfully
>>> +                 * changed, update the EM power values to
>>> +                 * reflect the reality and not use stale data
>>
>> At this point, can we really say that the voltage has changed?
>>
>>    exynos_asv_update_cpu_opps()
>>
>>      ...
>>      ret = dev_pm_opp_adjust_voltage()
>>      if (!ret)
>>        em_dev_update_chip_binning()
>>      ...
>>
>> dev_pm_opp_adjust_voltage() also returns 0 when the voltage value stays
>> the same?
>>
>> [...]
> 
> The comment for the dev_pm_opp_adjust_voltage() says that it
> returns 0 if no modification was done or modification was
> successful. So I cannot distinguish in that driver code, but
> also there is no additional need to do it IMO (even framework
> doesn't do this).

Precisely. That's why the added comment in exynos_asv_update_opps():
"When the voltage for OPPs successfully __changed__, ..." is somehow
misleading IMHO.