Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp93311lqo; Wed, 27 Mar 2024 07:49:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX8KK1u7/kfzQsFL/Gwip3fxSiDBivYefhIwlU8OAY4a5FRf2IordJHEHXf89u8FqtJxOOwHhHNh0M3bCKBGRANgH4OapNGzM+E9DX8yg== X-Google-Smtp-Source: AGHT+IEQH+TRqZq+RAfbQZFFn4OyDocmTMejJI/SxO+FtOeJfKz+rKqgX6WQF/WrD+IfO8B9LnR+ X-Received: by 2002:a17:907:7676:b0:a4a:3679:5506 with SMTP id kk22-20020a170907767600b00a4a36795506mr3014312ejc.68.1711550956164; Wed, 27 Mar 2024 07:49:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711550956; cv=pass; d=google.com; s=arc-20160816; b=zGNxJvER6QDeAKknO4KB5gOeShhe6v/LyJ5BtO4AeHmVKzBmwv+kGdi1wSj8w9/5MG CHCbJrx15fofWrg7hopayBpAAl1udBnVEOcG5/vMpxA1egUCtGt2pFccns5vM/GJfSiG C+gXw99EPPQ5vX6rOzEVCzLGHWdHSFkXcIK7HNviPatFPljEjAc8IwxCTZ+SEc82xQTV JbL2q5D7RGE+jA7wzQftKbkBOsUdJcEdc/RUL4YUEI47CkqsedfdHXWil8w18RBgQnXi N5RkvSVez90ShncZSGgRXcgMxseJ234CdnU1s0N2hOKudOA8wID52vTg0xIz5OIyW7t9 Cfww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=A2Rc8poG3eY+pKXbxkZU6vc2CLTr8pLqO7GgK4oVrFw=; fh=6s6ytHZ5fbt/0Rci8Av9znUGQKGUoC1ubYUNrsX7sjY=; b=eYCLFMe7llf0eHwk6atX4Jay/iL5W0HkI5G8ElGijB995kTqbIjFvQdRq/cCHYJctK KSknxGHL6mqC0k/4XviYd+xl5dGUehI2enOM0TFVhK/tT2R5z0Fr1sWZJV4BzY+AlEgJ NnX9cD9n2MVMUbu6fR0Znlwpqf0dglI3kz1ogdgoL1JwROruk1hlpUh8GDFBok2xfSLy BQE3jEhFXSxJoll5S+zXYd+pwTGCAIyynm0UuTDCqqO+ihIvKSuk6A8D3owqqq0XiLYw ySfqtobnTRu8hCnIv8zqJ/bAmPtN+4xnByM1DZ/4svWqdcyhSA//jW14dm+4BMeDRBVR QAwA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-121375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121375-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id bh11-20020a170906a0cb00b00a4df809e03asi1524625ejb.36.2024.03.27.07.49.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 07:49:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-121375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121375-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CA2341F2BFB4 for ; Wed, 27 Mar 2024 14:48:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A872C15A499; Wed, 27 Mar 2024 13:39:21 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 693D313049D; Wed, 27 Mar 2024 13:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546761; cv=none; b=q78ASltJtYLlNey57Kz5HFDtzHnTrwYkae+2e2oGxKFWwiNJk5FhQqe9lsdzRIqVYMmDYHtUbb3Ao2LK7trPaf9ykaFfskh0Be0AblvnAfsaUJXA6iMFS4Cif9bgu0BM2oHutEcpdd3aEHfrnOPc95C61Vhfhh1/aJRBJhGhRxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711546761; c=relaxed/simple; bh=QMWV3ihNRz0mDxS6+fJ38ErgxdJliWpfb4IEPJW63YI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KwVUuDitiJGGRCBrAj3GFu27VA5ltnijHOOo3FCkrPqsoCOLCznzNJ/XO9HcJKPQtx2hvgfRi1yz9ICrTizeMm0++rXRH89zrmSskek8OxT+RUnMBcrdchclFC21DSH/ynDZMUgA/hDQolsn0DdhMIype+/3AxgjEke1zC+L0uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 347892F4; Wed, 27 Mar 2024 06:39:52 -0700 (PDT) Received: from [10.57.72.20] (unknown [10.57.72.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D48CD3F7BD; Wed, 27 Mar 2024 06:39:15 -0700 (PDT) Message-ID: <37e593f3-22f3-4270-8e92-80e9a6187f55@arm.com> Date: Wed, 27 Mar 2024 13:39:14 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND][PATCH v2 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Content-Language: en-US To: Dietmar Eggemann Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20240322110850.77086-1-lukasz.luba@arm.com> <20240322110850.77086-5-lukasz.luba@arm.com> <59d37960-cf19-4b10-802f-59d42496c133@arm.com> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/27/24 12:56, Dietmar Eggemann wrote: > On 26/03/2024 21:12, Lukasz Luba wrote: >> Hi Dietmar, >> >> On 3/26/24 11:20, Dietmar Eggemann wrote: >>> On 22/03/2024 12:08, Lukasz Luba wrote: >>> >>> [...] >>> >>>> @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct >>>> exynos_asv *asv) >>>>               last_opp_table = opp_table; >>>>                 ret = exynos_asv_update_cpu_opps(asv, cpu); >>>> -            if (ret < 0) >>>> +            if (!ret) { >>>> +                /* >>>> +                 * When the voltage for OPPs successfully >>>> +                 * changed, update the EM power values to >>>> +                 * reflect the reality and not use stale data >>> >>> At this point, can we really say that the voltage has changed? >>> >>>    exynos_asv_update_cpu_opps() >>> >>>      ... >>>      ret = dev_pm_opp_adjust_voltage() >>>      if (!ret) >>>        em_dev_update_chip_binning() >>>      ... >>> >>> dev_pm_opp_adjust_voltage() also returns 0 when the voltage value stays >>> the same? >>> >>> [...] >> >> The comment for the dev_pm_opp_adjust_voltage() says that it >> returns 0 if no modification was done or modification was >> successful. So I cannot distinguish in that driver code, but >> also there is no additional need to do it IMO (even framework >> doesn't do this). > > Precisely. That's why the added comment in exynos_asv_update_opps(): > "When the voltage for OPPs successfully __changed__, ..." is somehow > misleading IMHO. > I got your point. Let me re-phrase that comment to reflect this OPP function return properly.