Received-SPF: pass (google.com: domain of linux-kernel+bounces-121358-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 27 Mar 2024 13:17:11 +0000
From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mateusz K <mateusz.kaduk@gmail.com>, Bjorn Helgaas <helgaas@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Switch over to MSI interrupts
Message-ID: <20240327131711.GR13211@google.com>
References: <20240312165905.1764507-1-andriy.shevchenko@linux.intel.com>
 <20240325211915.GA1449994@bhelgaas>
 <CAPf=4Rc2vQrWqcs=-ND3iOZFJyKE7FdPoqU9w6DKjoSaJo6KaQ@mail.gmail.com>
 <ZgLefFQanbq-ozKM@smile.fi.intel.com>
 <ZgLooJa1JVKEMOtf@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZgLooJa1JVKEMOtf@smile.fi.intel.com>

On Tue, 26 Mar 2024, Andy Shevchenko wrote:

> On Tue, Mar 26, 2024 at 04:41:01PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 26, 2024 at 11:06:38AM +0100, Mateusz K wrote:
> > > I tried the patch that changes PCI_IRQ_LEGACY into PCI_IRQ_ALL_TYPES
> > > and it seems I get some other error now
> > > 
> > > [    1.477341] intel-lpss 0000:00:15.0: enabling device (0004 -> 0006)
> > > [    1.477466] intel-lpss 0000:00:15.0: can't derive routing for PCI INT A
> > > [    1.477468] intel-lpss 0000:00:15.0: PCI INT A: not connected
> > > [    1.477488] intel-lpss 0000:00:15.0: probe with driver intel-lpss
> > > failed with error -2147483648
> > > [    1.489572] intel-lpss 0000:00:15.2: enabling device (0004 -> 0006)
> > > [    1.489688] intel-lpss 0000:00:15.2: can't derive routing for PCI INT C
> > > [    1.489689] intel-lpss 0000:00:15.2: PCI INT C: not connected
> > > [    1.489715] intel-lpss 0000:00:15.2: probe with driver intel-lpss
> > > failed with error -2147483648
> > > [    1.501886] intel-lpss 0000:00:19.0: enabling device (0004 -> 0006)
> > > [    1.502034] intel-lpss 0000:00:19.0: can't derive routing for PCI INT A
> > > [    1.502036] intel-lpss 0000:00:19.0: PCI INT A: not connected
> > > [    1.502067] intel-lpss 0000:00:19.0: probe with driver intel-lpss
> > > failed with error -2147483648
> > > [    1.514288] intel-lpss 0000:00:19.1: enabling device (0004 -> 0006)
> > > [    1.514535] intel-lpss 0000:00:19.1: can't derive routing for PCI INT B
> > > [    1.514538] intel-lpss 0000:00:19.1: PCI INT B: not connected
> > > [    1.514570] intel-lpss 0000:00:19.1: probe with driver intel-lpss
> > > failed with error -2147483648
> > > [    1.526291] intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006)
> > > [    1.526555] intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A
> > > [    1.526557] intel-lpss 0000:00:1e.0: PCI INT A: not connected
> > > [    1.526604] intel-lpss 0000:00:1e.0: probe with driver intel-lpss
> > > failed with error -2147483648
> > > [    1.538130] intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006)
> > > [    1.538233] intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D
> > > [    1.538235] intel-lpss 0000:00:1e.3: PCI INT D: not connected
> > > [    1.538253] intel-lpss 0000:00:1e.3: probe with driver intel-lpss
> > > failed with error -2147483648
> > 
> > Hmm... I have a unique board to test :-)
> > Let's revert it then.
> > 
> > Bjorn, in such case your tree should keep conversion one.
> > 
> > Lee, do you prefer a revert or can you simply drop this from the queue?
> 
> Hold on, but IIUC this is the report about new hardware that never had
> a support by Linux before.

So a revert is no longer required?

-- 
Lee Jones [李琼斯]